400 Error Loading Fonts

  • Resolved xXZ3R0x

    (@xxz3r0x)


    8 years, 1 month ago

    SAB is generating css font URL for Google Fonts that results in a 400 response:
    <link rel="stylesheet" id="sab-font-css" href="https://fonts.googleapis.com/css?family=Open+Sans:400,700,400italic,700italic|Open+Sans:400,700,400italic,700italic&subset=None" type="text/css" media="all">

    Google generates this url as:
    <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,400i,700,700i" rel="stylesheet">

    My theme already loads these fonts, it would be nice to be able to disable Google Fonts being loaded in the same way that you can with Font Awesome.

    • This topic was modified 8 years, 1 month ago by xXZ3R0x.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter xXZ3R0x

    (@xxz3r0x)

    8 years, 1 month ago

    Found the cause of the 400

    class-simple-author-box.php line 146:
    if ( 'none' != $sab_box_subset ) {
    should be
    if ( 'none' != strtolower($sab_box_subset) ) {

    Still would be good to disable loading of redundant fonts loaded by my theme

    • This reply was modified 8 years, 1 month ago by xXZ3R0x.
    Miha

    (@mplusb)

    8 years, 1 month ago

    Thank you so much for your feedback, @xxz3r0x!
    I have created a ticket with our development team so they can investigate and fix in our next update.

    Thank you,
    Mihaela

    Macho Themes

    (@machothemes)

    8 years, 1 month ago

    @@xxz3r0x – thanks for this.

    Setting the font family to “none” should actually disable loading SAB’s fonts. Were you looking for a way to disable your theme’s fonts as well?

    Let me know 🙂

    I’ll make sure your suggestion gets added to the next plugin update (expect it to hit sometime this week).

    Thanks,
    Cristian.

    Thread Starter xXZ3R0x

    (@xxz3r0x)

    8 years, 1 month ago

    @machothemes according to the code setting it to none just setssubset=latin on the URL (Google defaults to this and isn’t really needed).

    I’m not looking to disable our theme’s fonts. Since our theme is more central and loading a more comprehensive list I was hoping for SAB not to load fonts. Currently, when inspecting our site you can see google fonts trying to be loaded 3 times because of the theme, this plugin, and another plugin. They’re all loading Open Sans so it’s just extra calls the client is making to Google.

    Macho Themes

    (@machothemes)

    8 years, 1 month ago

    @xxz3r0x – ah, ok, now this makes sense.

    I’ll make a ticket for our dev team to handle this.

    Thanks,
    Cristian.

    Macho Themes

    (@machothemes)

    8 years, 1 month ago

    @xxz3r0x – this should be handled better in v2.0.4 (just released today)

    Thank you for reporting these issues.

    Have a great day,
    Cristian.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘400 Error Loading Fonts’ is closed to new replies.