404 error for jquery.smookie.js | ww.wp.xz.cn

doublesharp
(@doublesharp)

10 years, 10 months ago

After upgrading to version 1.0 I noticed 404 errors for /wp-content/plugins/wp-crm/third-party/jquery.smookie.js. Looking at the filesystem I saw that the correct location was /wp-content/plugins/wp-crm/lib/third-party/jquery.smookie.js, and that this seemd to be what was being registered in /wp-content/plugins/wp-crm/lib/class_core.php via the call to ud_get_wp_crm()->path() however inspecting that function shows that it has a preg_replace() that explicitly removes /lib and /classes from the path, thus resulting in the 404. Commenting out this line will allow the proper path to be used and the file can be loaded. Because this seemed to be done explicitly, I had a couple of questions…

1 – Will commenting out this line cause any issues? If so what is the best way to resolve the 404 error?
2 – Is it necessary to load these scripts on the client side or can they be limited to the wp-admin?

Thanks!

https://ww.wp.xz.cn/plugins/wp-crm/

Viewing 9 replies - 1 through 9 (of 9 total)

Thread Starter doublesharp
(@doublesharp)

10 years, 10 months ago

For the second question I just realized that you are not enqueueing them, but you are registering the path to your plugin for the key jquery-cookie which is used by other plugins (Admin Menu Editor Pro, Popup Maker, WooCommerce, etc). Ideally the calls to wp_register_script would only be made when is_admin() is true…

Daniel Iser
(@danieliser)

10 years, 10 months ago

@doublesharp – Popup Maker no longer uses jquery-cookie. We have rolled our own version of it into our core JS with some enhancements. Partially to reduce dependencies, and partially to reduce conflicts.

Thread Starter doublesharp
(@doublesharp)

10 years, 10 months ago

You’re including the file, but you are referring to it by the same handle as other plugins, so even when it’s not being enqueued by WP-CRM, it is still (trying) to use the static file from your plugin, however because the path() method is removing /lib from the URL, it is producing a 404 error on the front end of my site.

Please note the same handle being used by the latest version of WooCommerce here: http://docs.woothemes.com/wc-apidocs/source-class-WC_Frontend_Scripts.html#123

Thread Starter doublesharp
(@doublesharp)

10 years, 10 months ago

WP-CRM registers the script, regardless of it being the front-end or back-end during the init here: https://plugins.trac.ww.wp.xz.cn/browser/wp-crm/trunk/lib/class_core.php#L91

But the path() method it uses explicit removes “/lib” from the path here: https://plugins.trac.ww.wp.xz.cn/browser/wp-crm/trunk/vendor/usabilitydynamics/lib-wp-list-table/lib/classes/class-utility.php#L43

Even though the file actually has “/lib” in the path: https://plugins.trac.ww.wp.xz.cn/browser/wp-crm/trunk/lib/third-party/jquery.smookie.js

Because WooCommerce is enqueuing “jquery-cookie” and WP-CRM has registered it to a bad path, it is resulting in a 404 on the front end of my site.

Plugin Contributor Eric Sopp
(@ideric)

10 years, 10 months ago

Gents – I just flagged this on our end for a technical review. Max or Anton should check back here within a few days. It’s the weekend, so it may be Monday until we can take a closer look.

Plugin Contributor Maxim Peshkov
(@maximpeshkov)

10 years, 10 months ago

Hello,

Thank you for pointing to the issue.
We will troubleshoot the issue related to replacing path to file.
Also, we will fix name conflicts in next release, which we are going to launch in a week or so.

We will keep you updated.

Regards.

Plugin Contributor Anton Korotkoff
(@anton-korotkoff)

10 years, 10 months ago

Hey doublesharp,

could you please tell me what combination of UsabilityDynamics product you use and what is version of each? I need to setup the same test environment to be able to replicate you issue.

Thanks.

Thread Starter doublesharp
(@doublesharp)

10 years, 9 months ago

Sorry, I didn’t see this message until just now. The only UsabilityDynamics product I am using is WP-CRM, but there are many other plugins being used on the site in question.

Thanks!

Plugin Contributor MariaKravchenko
(@mariakravchenko)

10 years, 9 months ago

Hello. Sorry for the delay.

Thank you for the information. Can you replicate the issue at the moment? Try to deactivate all third party plugins in order to investigate the issue.

Regards.

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘404 error for jquery.smookie.js’ is closed to new replies.

9 replies
6 participants
Last reply from: MariaKravchenko
Last activity: 10 years, 9 months ago
Status: not resolved