Hi Jason,
thanks for the reply.
Sorry, but I cannot get involved – we paid for the plugin, as we did for several others – just to find out I need to start optimizing it.
I’ll give you a small idea what I’m talking about:
1. On every page load about 10-15 get_option calls which hit the DB because the result is sometimes empty and hence will not get cached by WP Object
2. Updating the different page_views, by user, by week, alone this has 3 update statements on every pageload.. I removed those via custom functions:
remove_action(“wp”, “pmpro_report_login_wp_visits”);
remove_action(“wp_head”, “pmpro_report_login_wp_views”);
remove_action(“wp_login”, “pmpro_report_login_wp_login”, 10 ,2);
3. pmpro_is_ready():
// check if there is at least one level
$pmpro_level_ready = (bool) $wpdb->get_var( "SELECT id FROM $wpdb->pmpro_membership_levels LIMIT 1" );
// check if the gateway settings are good. first check if it's needed (is there paid membership level)
$paid_membership_level = $wpdb->get_var( "SELECT id FROM $wpdb->pmpro_membership_levels WHERE allow_signups = 1 AND (initial_payment > 0 OR billing_amount > 0 OR trial_amount > 0) LIMIT 1" );
$paid_user_subscription = $wpdb->get_var( "SELECT user_id FROM $wpdb->pmpro_memberships_users WHERE initial_payment > 0 OR billing_amount > 0 OR trial_amount > 0 LIMIT 1" );
If one sets up the plugin and configures it – why have 3 queries on EVERY damn page load? If it’s really required, just update ONE flag in the DB which indicates which readiness the plugin has. But not 3 queries in the frontend on every pageload.
4. There are dozens of functions done like pmpro_affiliates_checkdb() (which is an plus-addon=) which perform several queries, like SHOW TABLE, dbDelta, etc on EVERY pageload instead of just ONCE when updating / installing it
5. For a lot of things, there’s no use of WP Object at all. E.g. getting categories, reading the membership levels etc – it’s basically a “one time setup” and often, you dont change it anymore. We use W3 TC but nothing of this is cached at all in memcache.
6. There are quirks and bugs here and there, e.g. the filter pmpro_bp_bp_get_add_friend_button. A guest cannot even “delete” a friendship, e.g. unfriending?
/**
* Fix PMPro issue with restrictions: Unfriend button disappearing for guests
*/
if(function_exists('pmpro_bp_user_can')) {
remove_filter('bp_get_add_friend_button', 'pmpro_bp_bp_get_add_friend_button' );
}
7. This action is a joke:
add_action(‘init’, ‘pmpro_bp_directory_init’, 20);
pmpro_bp_directory_init usees a SUPER expensive function pmpro_bp_get_members_in_directory(). getting ALL levels. Than ONE BY ONE in a loop getting the level options. It’s just crazy.
And I have dozens of findings more.
I’m willing to contribute, you can engage my freelancing which makes your plugin useable on a 10k+ users membership page.
