Bug in Kadence Blocks Free code (table cell)

  • Resolved Mirco Babini

    (@mirkolofio)


    8 months ago

    I’ve found a bug 🙂

    The issue is that the table cells are not closed with </td> tag, because of a wrong string replacement in php code. Then, this is basically the HTML you are generating for a couple of cells: https://i.snipboard.io/jXCKh5.jpg

    This is not valid HTML; modern browsers like Chrome are NOT showing this (because they auto-fix the issue). Still, using cache plugins with HTML minification can break everything (indeed, one of our production website page broken because of this).

    The affected file is: kadence-blocks/includes/blocks/class-kadence-blocks-table-data-block.php
    Rows: 98-104

    Super easy fix 🙂 https://gist.github.com/mircobabini/cc2eb737b6bc235e7dfc6e7549bff792/revisions
    https://i.snipboard.io/MIRwuP.jpg

    Thank you if you can forward this to the devs and patch it in the next upcoming release.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Support victormonk

    (@victormonk)

    8 months ago

    Hey Mirco,

    Thanks for reporting this. I did some tests on my end, but I couldn’t reproduce the HTML structure shown in your screenshot. For example, please see this screenshot from my end.

    On my end, the Table Cells all have closing tags. Can you share a link to the website in question? This way, I can inspect your page to better reproduce your exact table.

    You can also try sharing a screenshot of your Block Settings so I can better replicate this issue.

    Can you also ensure your plugin is up-to-date and try clearing your browser cache?

    Thanks!

    Thread Starter Mirco Babini

    (@mirkolofio)

    8 months ago

    Thanks for your reply. I can clearly see that you can reproduce the issue, actually.

    Let me clarify:
    1. Do not trust the Chrome console. That one is not the real DOM. That one is the one Chrome auto-fixes for you, to show it not top messy.
    2. Use CMD+U instead and see the REAL dom.

    I’m 100% sure you will the that the ending td tag is missing.

    Thanks,
    Mirco

    Plugin Support victormonk

    (@victormonk)

    8 months ago

    Hey Mirco,

    You are correct. Thanks for the insights. I was able to see exactly what you are referring to. I have successfully reported this to our dev team to explore. I don’t have a direct ETA for when a fix will be released. However, you can keep an eye on the Kadence Blocks Changelog here.

    Additionally, if you would like to keep track on this report, feel free to open a support ticket with us and link to this thread. We can keep you up to date with the progress of this bug.

    Thanks again!
    Victor

    Thread Starter Mirco Babini

    (@mirkolofio)

    8 months ago

    You are most welcome.

    And thank you for keeping up open source software. Really appreciate.

    Mirco

    Thread Starter Mirco Babini

    (@mirkolofio)

    6 months ago

    Hey @victormonk,

    2 months are past now. And the bug is still there.
    It’s a one-line bugfix with a patch already provided in my first message.

    Why still not fixed? Can you please mark it as high priority?
    We can’t just patch our sites forever. We want to keep you plugin updated.

    Thanks.

    Thread Starter Mirco Babini

    (@mirkolofio)

    3 months, 3 weeks ago

    @victormonk the patch has not yet release. Please, fix this.
    Every single update of your plugin is breaking our sales page.

    Plugin Support aapc

    (@aapc)

    3 months, 3 weeks ago

    Hi @mirkolofio

    Just a quick update…a fix is in the works. I’ll let you know when it’s released. Appreciate your patience.

    Thanks,
    Anthony

    Plugin Support aapc

    (@aapc)

    2 months, 1 week ago

    @mirkolofio this was fixed in Kadence Blocks v3.6.5. Thank you for your patience.

    I’ll go ahead and mark this as resolved.

    All the best,
    Anthony

Viewing 8 replies - 1 through 8 (of 8 total)

You must be logged in to reply to this topic.