Hi @jasmines
Thanks for the bug reports.
I can confirm the first bug with the Bulk Edit.
We can’t replicate the ordering issue. Could you share more details, please?
Regarding the bulk edit bug, can you say when will it be fixed more or less? I can’t believe there aren’t other plugins to achieve the expiration on wordpress… So yours is a must have it!
Regarding the ordering bug, I’m using Admin Columns Pro by https://www.admincolumns.com/ to add sortable/filterable columns to backend list tables. It works with all kind of fields, from several plugins, except of yours…
And I can’t find out why…
Thanks @jasmines
The Bulk Edit should get fixed in the next release.
With the columns, please try without that extra Admin Columns plugin.
I deactivated the Admin Columns plugin, but I’m still having the bug.
Hi @jasmines. Sorry, we don’t see this in testing.
Can you see this problem on a second site? If so, please share specific details of the ordering problem.
I’m using your plugin on a single site.
Sorting by “expires” column definitely doesn’t work as expected.
The records are “moving”, when I click on the sorting arrow near “Expires” field, but I can’t understand what logic is used for the obtained sequence.
So I tried to have a deeper look in the database, where everything seems ok: I found out your plugin is adding a few post_meta to expiring posts, and I saw the meta_value is a timestamp-like value, so sorting is quite obvious.
I executed the query
SELECT p.ID, p.post_title, p.post_type, pm.meta_value FROM wp_postmeta as pm inner join wp_posts as p on pm.post_id = p.ID where pm.meta_key like “_expiration-date” order by pm.meta_value
Mysql is ordering the records as expected.
Really I don’t understand why the table list is behaving so strangely…
I really would like to help with further details…
I fixed it the ordering bug for you!
In post-expirator.php, find
function my_expirationdate_orderby( $query ) {
if( ! is_admin() )
return;
$orderby = $query->get( 'orderby');
if( 'expirationdate' == $orderby ) {
$query->set('meta_query',array(
'relation' => 'OR',
array(
'key' => '_expiration-date',
'compare' => 'EXISTS'
),
array(
'key' => '_expiration-date',
'compare' => 'NOT EXISTS',
'value' => ''
)
));
$query->set('orderby','meta_value_num');
}
}
and replace with:
function my_expirationdate_orderby( $query ) {
if( ! is_admin() )
return;
$orderby = $query->get( 'orderby');
if( 'expirationdate' == $orderby ) {
$query->set( 'meta_key', '_expiration-date' );
$query->set('meta_query',array(
'relation' => 'OR',
array(
'key' => '_expiration-date',
'compare' => 'EXISTS'
),
array(
'key' => '_expiration-date',
'compare' => 'NOT EXISTS',
'value' => ''
)
));
$query->set('orderby','meta_value_num');
}
}
Note the addition:
$query->set( 'meta_key', '_expiration-date' );
You’re welcome, however:)
Thanks for reporting this @jasmines. We’ll get it fixed in the next release.
How much longer do we have to wait for the next release???
Please provide estimation time!
Hi @jasmines
You reported the possible fix 6 days ago.
We are working to validate and release it quickly. Sorry, no ETA yet.
We have just taken over managing this plugin and still have a little setup work to do.
Ehy, you are the developer… Aren’t you?
That bug is 8 years old and it was FIXED.
You should think about this little particular: your plugin is not the first handling date formatted postmeta.
Hi @jasmines
Please follow up on that Github issue. It is the best place to discuss code issues like this.
