Code refactoring

  • Resolved lvfxbr

    (@lvfxbr)


    7 years, 3 months ago

    Hello there!

    Well, I was reading the code of the plugin and I noticed some things to improve:

    1. The way you commented the code is not following the PHPDoc standard and as you see, it is breaking the syntax highlight of any colorful text-editor and that difficults debug:

    https://pasteboard.co/I1gR7R1.png

    2. The index.php have 3k of lines, can you please split it in small files? The good code is not that only run and just works, the good code is that is readable, mantainable and objective.

    Thank you, the plugin is working fine but need these improvements.

Viewing 5 replies - 1 through 5 (of 5 total)
  • pavloborysenko

    (@pavloborysenko)

    7 years, 3 months ago

    Hello

    1) Use another IDE. A good editor should recognize comments. Looks like you are using VS code

    2) Yes of course. But this is class size. And it is impossible to divide it into several files. the same file size does not affect readability

    Thread Starter lvfxbr

    (@lvfxbr)

    7 years, 3 months ago

    1) Tell me the IDE that is not breaking in the comment, because I tested in VSCode and in Sublime Text, two code editors can’t be wrong.

    2) Yes, you can, maybe you don’t want to waste your time organizing it because it’s too big and it’s working as expected. See WooCommerce code and tell me you can’t split a class in two or in twenty.

    • This reply was modified 7 years, 3 months ago by lvfxbr.
    • This reply was modified 7 years, 3 months ago by lvfxbr.
    pavloborysenko

    (@pavloborysenko)

    7 years, 3 months ago

    Hello

    1) Notepad++, bluefish, netbeans, PHPstorm – these plugins have intelligent recognition of comments

    2) Do you want to offer your services? Please give me a link to your product in production.

    Thread Starter lvfxbr

    (@lvfxbr)

    7 years, 3 months ago

    1) You are using the IDE change as excuse, you don’t want to use PHPDoc Standard, I don’t understand your reluctance. You are nesting the a single line comment in a block comment and that is a bad code practice. If you don’t believe me, see: http://php.net/manual/en/language.basic-syntax.comments.php.

    2) I will be interested in contribute to plugin with two conditions:

    2.1 – IF the plugin is open source, I will be happy to send pull requests, just give me the link of repository (I didn’t found in Google).

    2.2 – IF the plugin has a commercial license, I want a percentage of it. But we can talk more if you wish.

    3) As I can see, you don’t accept my opinions so I will use another plugin to make the filter of my theme. I lost my time here. Have a nice day!

    pavloborysenko

    (@pavloborysenko)

    7 years, 3 months ago

    Hello

    1)Did you read the article to which you threw me a link?

    PHPDoc – Yes, I do not use it! But this is not the rule, and there is no need to use it if I do not want automatic documentation.

    2) If you do not have serious products in production. Of course I will not cooperate with you

    3) Yes you are right. Let’s not waste each other’s time

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Code refactoring’ is closed to new replies.