Conflict with Jetpack Backups

  • Resolved verysiberian

    (@verysiberian)


    3 years, 6 months ago

    Hello! I have been going back and forth with support from Automattic regarding repeated failed backups using their plugin. They have narrowed down the issue to one involving Really Simple SSL:

    Our developers took a look at this and the issue is that the plugin using the line:
 
if ( ($_SERVER["HTTPS"] && ("on" === $_SERVER["HTTPS"] || "1" == $_SERVER["HTTPS"])
 
in advanced-headers.php. This causes WordPress to give errors. Our developers fixed the issue in the working backup by changing the line to:
 
if (isset($_SERVER["HTTPS"]) && ("on" === $_SERVER["HTTPS"] || "1" == $_SERVER["HTTPS"])
 
However, when the plugin was updated, it reset the line back to what it originally was which caused the backups to fail.

    I wanted to report this to you since I use the plugin and its pro counterpart on this site. Please let me know if this could be fixed.

    Thanks,
    Rob

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Rogier Lankhorst

    (@rogierlankhorst)

    3 years, 6 months ago

    Hi Rob,

    Thanks for reporting the issue.

    It was reported earlier this week, so we have a fix ready. After further testing it will be released on Tuesday, you can apply the above fix until then.

    This issue can occur on some environments which do not have the ‘https’ key in the $_SERVER variable.

    Sorry for the inconvenience caused!

    Thread Starter verysiberian

    (@verysiberian)

    3 years, 6 months ago

    Thank you for your quick and encouraging reply! Am I correct in that changing that one line in wp-content/advanced-headers.php is the current workaround?

    Line 13 (old):
    if (($_SERVER[“HTTPS”] && (“on” === $_SERVER[“HTTPS”] || “1” == $_SERVER[“HTTPS”]) )

    Line 13 (new):
    if (isset($_SERVER[“HTTPS”] && (“on” === $_SERVER[“HTTPS”] || “1” == $_SERVER[“HTTPS”]) )

    Just confirming and thanks again,
    Rob

    Plugin Contributor Rogier Lankhorst

    (@rogierlankhorst)

    3 years, 6 months ago

    Hi Rob, yes, but please note that your last post contains a bracket error, your first post was correct:

    if (isset($_SERVER["HTTPS"]) && ("on" === $_SERVER["HTTPS"] || "1" == $_SERVER["HTTPS"]) )

    The first $_SERVER[“HTTPS”] has to be wrapped in isset()

    Thread Starter verysiberian

    (@verysiberian)

    3 years, 6 months ago

    Thank you!

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Conflict with Jetpack Backups’ is closed to new replies.