Various comments
-
Hi Fernando,
Some bulk comments.
Often you use “Data User” term to identify a “Data Owner”.
May be it would be timely to modify, if it’s correct.Problem with this string
User was removed from the %s request list by admin., uncompleted translation of variable.Regards.
-
Hi @bonaldi,
I’m going to pass this data user data owner thing through my colleagues here at Trew Knowledge since they know more about these terms than I do. I’ll update as required. Thanks for bringing it to my attention.
Can you clarify the problem with this string?
This is how I’ve set it.
/* translators: The type of request i.e 'delete' */ sprintf( esc_html__( 'User was removed from the %s request list by admin.', 'gdpr' ), $type )Turns out we were both wrong.
The correct legal term is Data Subject. I’ve updated the readme filesWith the string: User was removed from the AND request list by admin. are translated. But %s stays in English (delete)
In Log Audit (in French):
[2018/04/27 22:21:08] L’utilisateur a été supprimé de la liste de demandes delete par l’administrateur.“Consent Given” is a missing string for translation too.
gdpr\admin\class-gdpr-admin.phpline 382OK, I’ll check for Data Subject.
“Privacy Policy” has no translation string neither in admin consents header pop up nor front-end window header.
Front-end.
The right link Opt Out in privacy-preferences-modal.php:115
Is it really an opt-out link or must it be a link to third parties Privacy ?
Because opt-out seems to be set in consents tab with buttons.
In cookies tab, you give informations about used ones, but can’t opt-out, only have information about third parties.
May be I’m wrong, I don’t know…Thank you @bonaldi, for identifying all these strings.
When registering third-party cookies, you should link back to their instructions on how to opt out of their cookies or if that information is not available you should at least link to their privacy policy.
For instance, when registering third party facebook.com because we have facebook share button on the site.
Facebook cookies mustn’t be written on visitor computer before he consent to.
If he doesn’t consent, we don’t display facebook buttons, with
has_consent( 'facebook' )plugin helper function.When he looks frontend cookies tab, he sees the facebook used cookies list.
What is, for example, the utility ofis_allowed_cookie( 'datr' )plugin helper function in this case ?It is difficult to understand how the plugin works and how it should be set up, despite the knowledge base.
It would be very useful to put concrete examples in this one, concerning the main related third-party apps like Google Analytics or the Facebook, Twitter and Google+ buttons.
And, maybe, have a demo on the site http://gdpr-wp.comYes. I agree that it is not easy to understand how all this works. I am trying to come up with examples, demos, and more stuff on the knowledge base but I need more time.
Think of consent and cookies this way.
Consent is an overview and cookies is more granular.
I can consent to Analytics, but I can block GA cookies. That means I allow you to keep track using other services.
If you registered a consent called facebook, then you can hide the buttons until consent is given. For cookies, you need to figure out what each cookie does and where it is being set. After that, you wrap them in the is_allowed_cookie function to prevent them from loading if necessary.
The topic ‘Various comments’ is closed to new replies.