Title: delete function changed
Last modified: August 31, 2016

---

# delete function changed

 *  [denfie](https://wordpress.org/support/users/denfie/)
 * (@denfie)
 * [10 years, 5 months ago](https://wordpress.org/support/topic/delete-function-changed/)
 * Hey,
 * your plugin is really nice but I think, that the delete function is not perfect.
   
   Because every time when we delete a redirection, all positions for all other 
   redirects are set again. With our example we have 3000 redirects and when we 
   not delete a bulk number of redirects is for each delete action 3000 updates.
 * My new code for the file models/redirect.php => Line: 215
 *     ```
       public function delete() {
       		global $wpdb;
   
       		$wpdb->query( $wpdb->prepare( "DELETE FROM {$wpdb->prefix}redirection_items WHERE id=%d", $this->id ) );
   
       		RE_Log::delete_for_id( $this->id );
   
       		// Reorder all elements (new)
       		$wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->prefix}redirection_items SET position = position - 1 WHERE position=%d", (int)$this->position ) );
   
       		Red_Module::flush( $this->group_id );
       	}
       ```
   
 * [https://wordpress.org/plugins/redirection/](https://wordpress.org/plugins/redirection/)

The topic ‘delete function changed’ is closed to new replies.

 * ![](https://ps.w.org/redirection/assets/icon-256x256.jpg?rev=983639)
 * [Redirection](https://wordpress.org/plugins/redirection/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/redirection/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/redirection/)
 * [Active Topics](https://wordpress.org/support/plugin/redirection/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/redirection/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/redirection/reviews/)

 * 0 replies
 * 1 participant
 * Last reply from: [denfie](https://wordpress.org/support/users/denfie/)
 * Last activity: [10 years, 5 months ago](https://wordpress.org/support/topic/delete-function-changed/)
 * Status: not resolved