Title: Edit link not inserted Last modified: May 2, 2021 --- # Edit link not inserted * Resolved [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [5 years, 1 month ago](https://wordpress.org/support/topic/edit-link-not-inserted/) * Hi Ronald, happened on your plugin by chance and thought: Great, that will be a real help. So today I installed it on 2 sites, one is still in development ( so without any caching plugins), the other is my own business website, see link above. The plugin is active and its JS is being loaded to the page. But no “sce_” has been added to the page when I submit a comment from another browser (so not the one where I’m logged in as admin). I looked at the code briefly, it looks really well structued and not to mention a lot of work. Would be much obliged if you could have a look and check it out. I’m using a very minimalistic theme which I wrote myself, it uses absolutely vanilla WordPress functions to output the comment stuff. Cheers, Tim * The page I need help with: _[[log in](https://login.wordpress.org/?redirect_to=https%3A%2F%2Fwordpress.org%2Fsupport%2Ftopic%2Fedit-link-not-inserted%2F%3Foutput_format%3Dmd&locale=en_US) to see the link]_ Viewing 9 replies - 1 through 9 (of 9 total) * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [5 years, 1 month ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14394662) * It does work if I’m logged in to the site. Howcome not when I’m not logged in? The description states for anonymous users… * Does the plugin set cookies? My site normally otherwise does not (I strive for that), but I see three domain cookies, with cryptic names. * Looking at the code, it seems to try to inspect a cookie “SimpleCommentEditing”, but I don’t see any such cookie )-: * The function generate_cookie_data() looks to be (trying to) set a cookie like this: $cookie_name = ‘SimpleCommentEditing’ . $comment_id . $hash; * I expect that the editing would work if the cookie were there – but it’s not… * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [5 years ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14459955) * Sorry Ronald, * in fact the cookie is there – with a name like SimpleCommentEditing14210081828b22b637bf3bd24ca5b37d03d * I suppose I missed it as it’s only valid for 5 minutes 🙂 * I have done some debugging and found the reason: My theme anonymises the stored IP address of the commenter, like this: * ``` // Anonymize commenter IPs - this is non-negotiable :) function pre_comment_anon_ip($address) { $packedAddress = inet_pton($address); if (strlen($packedAddress) == 4) { return inet_ntop($packedAddress & inet_pton('255.255.255.0')); } elseif (strlen($packedAddress) == 16) { return inet_ntop($packedAddress & inet_pton('ffff:ffff:ffff:ffff:0000:0000:0000:0000')); } else { return "127.0.0.1"; } } add_filter('pre_comment_user_ip', 'pre_comment_anon_ip'); ``` * Your cookie functions use the IP in the hash used in the cookie name – so they do not match. * I can think of at least 3 ways out of this: - You stop putting the IP in the hash - You use the above anonymising function on the hash, both times (would work for me) - You provide an option to say if and how much anonymising should be done to mirror what someone else may be doing (would need “expert” users) * I really hope you find a good way through, as in the age of GDPR the anonymising is really important, to be able to avoid needing a cookie banner on the website. * Thanks in advance, * Tim * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [5 years ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14461648) * Things are often that much clearer after a nights sleep. The fix is easy. Insert this as line 1096: * `$comment_author_ip = apply_filters( 'pre_comment_user_ip', $comment_author_ip);` * I have tested it, works. * Would be very grateful if you could get a new version out soon, as my security plugin (WP Cerber) will now be complaining about a modified file every 6 hours… * Best, * Tim * Plugin Author [Ronald Huereca](https://wordpress.org/support/users/ronalfy/) * (@ronalfy) * [5 years ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14503779) * Heya [@tim-reeves](https://wordpress.org/support/users/tim-reeves/) * Sorry for not responding. * Would you be able to create a PR here? * [https://github.com/MediaRon/simple-comment-editing](https://github.com/MediaRon/simple-comment-editing) * I’ll have to test this out pretty thoroughly. For the most part, the IP verification hasn’t been touched for quite some time. * Thanks, * Ronald Huereca * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14606965) * Hi [@ronalfy](https://wordpress.org/support/users/ronalfy/) * I’m not so fit with Github but I did try to make a PR – I don’t know if it worked. * But in fact we’re only talking about inserting one line of code… (see above). * On the one hand I understand about you being careful changing something long untouched. But on the other hand, if you really look at it the fix is obviously right and neccessary: We know that before storing the IP, WP **will** apply the filter (see above). So it’s only logical that if we need a match, we must also apply it before using the IP. * I suppose one could imagine that a truncated IP is not an exact match – but ( a) little chance of someone with an IP in the same (truncated) address range adding a comment to a particluar website at the same time; and (b) there’s the cookie requirement anyway. So I really don’t see any problem. And it’s been working for me for a month now. * Currently I’m in the sad position that I have had to switch off auto-updates to the plugin (as I have an edited file in place), and also I don’t want to install it at client websites as it’s then too much work with the manual file update. * Would be very grateful if you could address the issue – many thanks! * Tim * Plugin Author [Ronald Huereca](https://wordpress.org/support/users/ronalfy/) * (@ronalfy) * [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14607262) * [@tim-reeves](https://wordpress.org/support/users/tim-reeves/) would adding am option and/or filter to enable it? * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14607459) * Hi Ronald, * yes, adding an option would be fine. Thanks! * Tim * Plugin Author [Ronald Huereca](https://wordpress.org/support/users/ronalfy/) * (@ronalfy) * [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14620787) * [@tim-reeves](https://wordpress.org/support/users/tim-reeves/) I merged the code in and will leave it turned on by default. * I added in a filter `sce_pre_comment_user_ip` that is true by default and will run the `pre_comment_user_ip` filter on every new comment. * I added the filter just in case someone needs to disable it. If there are any problems with editing, I’ll have to change the `sce_pre_comment_user_ip` to false and an option to turn it on. I don’t foresee this happening. If anything, it should make the comment editing more reliable. * Thanks for the PR and fix. I’ve attempted to credit you in the code as well as the readme. If you need further credit, please let me know. * Regards, * Ronald Huereca * Thread Starter [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * (@tim-reeves) * [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14627739) * Hi Ronald, * many thanks indeed for the fix – I confirm that it now works for me. * I didn’t do it for creds, but to support the work of both of us – but many thanks, appreciated. * Best for you, * Tim Viewing 9 replies - 1 through 9 (of 9 total) The topic ‘Edit link not inserted’ is closed to new replies. * ![](https://ps.w.org/simple-comment-editing/assets/icon-256x256.png?rev=2863851) * [Comment Edit Core - Simple Comment Editing](https://wordpress.org/plugins/simple-comment-editing/) * [Frequently Asked Questions](https://wordpress.org/plugins/simple-comment-editing/#faq) * [Support Threads](https://wordpress.org/support/plugin/simple-comment-editing/) * [Active Topics](https://wordpress.org/support/plugin/simple-comment-editing/active/) * [Unresolved Topics](https://wordpress.org/support/plugin/simple-comment-editing/unresolved/) * [Reviews](https://wordpress.org/support/plugin/simple-comment-editing/reviews/) * 9 replies * 2 participants * Last reply from: [Tim Reeves](https://wordpress.org/support/users/tim-reeves/) * Last activity: [4 years, 11 months ago](https://wordpress.org/support/topic/edit-link-not-inserted/#post-14627739) * Status: resolved