Event title all messed up!

  • Resolved schulz

    (@schulz)


    11 years ago

    I was investigating why Facebook was not picking up any of my event posts since the beginning of may, and I came across this:

    With your plugin activated:
    <a itemprop="url" href="http://807.events/commuter-challenge/" rel="bookmark" title="Commuter Challenge <span class=" dashicons="" dashicons-calendar"="">">Commuter Challenge <span class="dashicons dashicons-calendar"></span></a>

    With your plugin deactivated:
    <a itemprop="url" href="http://807.events/commuter-challenge/" rel="bookmark" title="Commuter Challenge">Commuter Challenge</a>

    It seems when you go to one of my event posts URL the title is broken causing Facebook to reject the post.

    https://ww.wp.xz.cn/plugins/event-post/

Viewing 4 replies - 1 through 4 (of 4 total)
  • mepmepmep

    (@mepmepmep)

    11 years ago

    @Shulz: My guess is that the title becomes messed up because of the icons for date and location that are added to it (on my request). But I think you can turn the icons off in the settings for Event Post, as a quick fix?

    @bastien: Perhaps it would be better to add the icons inside the entry-meta div, something like the following?:

    <div class="entry-meta">
	...
	<span class="event-date"><span class="dashicons dashicons-calendar"></span><time class="start-date" datetime="...">...</time> - <time class="end-date" datetime="...">...</span>
	<span class="event-location"><span class="dashicons dashicons-location"></span></span>
</div>

    instead of adding them to the title? A suggestion anyway..

    mepmepmep

    (@mepmepmep)

    11 years ago

    As a future enhancement the icons could then also be used to filter out posts that has event-dates, and posts that has a location, or to quick view a map or other nice stuff. 🙂

    Thread Starter schulz

    (@schulz)

    11 years ago

    Why I said it is ‘messed up’ is because it is trying to insert the dashicons span inside the anchor title breaking both the dashicons span and the post title anchor.

    Thank you for the suggestion on disabling the dashicons, it seemed to clean up the problem.

    Event Settings -> Add icons for events in the loop : No

    Plugin Author Bastien Ho

    (@bastho)

    10 years, 8 months ago

    Actually there is no way to check if the title is displayed in an HTML tag’s attribute or outside.

    The correct behavior in a theme is to use esc_attr(get_the_title) for inclusion in an attribute.
    In other case, it’s better to disable the option.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Event title all messed up!’ is closed to new replies.