Title: Fatal error in admin (with patch)
Last modified: August 18, 2023

---

# Fatal error in admin (with patch)

 *  [Roy Orbitson](https://wordpress.org/support/users/lev0/)
 * (@lev0)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/)
 * Your plugin attaches to the `admin_footer_text` filter like it’s an action, and
   returns nothing (`null`), clearing the existing content. This can cause other
   plugins that expect a string to throw a type error. There is a better action 
   hook that fires after the footer.
 * Here’s [the patch](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/application/octet-stream;base64,LS0tIGEvd3AtY29udGVudC9wbHVnaW5zL3VwbG9hZC1tZWRpYS1ieS11cmwvdXBsb2FkbWVkaWFieXVybC5waHAKKysrIGIvd3AtY29udGVudC9wbHVnaW5zL3VwbG9hZC1tZWRpYS1ieS11cmwvdXBsb2FkbWVkaWFieXVybC5waHAKQEAgLTIwLDcgKzIwLDcgQEAKIGRlZmluZSgnVU1CVV9QTFVHSU5fVVJMRElSJywgcGx1Z2luX2Rpcl91cmwoX19ESVJfXykpOw0KIGRlZmluZSgnVU1CVV9QTFVHSU5fTkFNRScsIHBsdWdpbl9iYXNlbmFtZShVTUJVX1BMVUdJTl9ESVIpKTsNCiANCi1hZGRfYWN0aW9uKCAnYWRtaW5fZm9vdGVyX3RleHQnLCAndW1idV9tZWRpYScgKTsNCithZGRfYWN0aW9uKCAnYWRtaW5fZm9vdGVyJywgJ3VtYnVfbWVkaWEnICk7DQogYWRkX2FjdGlvbignd3BfZW5xdWV1ZV9zY3JpcHRzJywgJ3VtYnVfY2FsbGJhY2tfY3NzJyk7DQogYWRkX2FjdGlvbiggJ2FkbWluX2luaXQnLCd1bWJ1X2NhbGxiYWNrX2NzcycpOw0KIGZ1bmN0aW9uIHVtYnVfY2FsbGJhY2tfY3NzKCkgew0KQEAgLTk4LDE4ICs5OCwxOSBAQAogDQogZnVuY3Rpb24gdW1idV9tZWRpYSgpIHsNCiAJZ2xvYmFsICRwYWdlbm93Ow0KLSAgICBpZiAoICEgY3VycmVudF91c2VyX2NhbiggJ3VwbG9hZF9maWxlcycgKSApIHJldHVybjsNCiAgICAgaWYgKCAkcGFnZW5vdyAhPSAndXBsb2FkLnBocCcgKSByZXR1cm47IC8vZml4IGlzc3VlIG9mIHBsdWdpbiBiZWluZyBsb2FkZWQgb24gb3RoZXIgYWRtaW4gcGFnZXMNCiAgICAgaWYgKCAkcG9zdF90eXBlID09ICdzaG9wX29yZGVyJyApIHJldHVybjsgLy8gZml4IGlzc3VlIG9mIHBsdWdpbiBiZWluZyBsb2FkZWQgb24gV29vQ29tbWVyY2UgcGFnZXMNCiAgICAgLy8JbWFrZSBzdXJlIHBsdWdpbiBpcyBub3QgY29uZmxpY3Rpbmcgd2l0aCBXb29Db21tZXJjZSBhdCBhbGwNCiAgICAgaWYoIGZ1bmN0aW9uX2V4aXN0cygiaXNfc2hvcCIpICkgew0KIAlyZXR1cm47DQogICAgIH0NCisgICAgaWYgKCAhIGN1cnJlbnRfdXNlcl9jYW4oICd1cGxvYWRfZmlsZXMnICkgKSByZXR1cm47DQogDQogICAgIC8vCWNoZWNrIGZvciBtdWx0aXVybA0KLSAgICBpZihpc3NldCgkX1JFUVVFU1RbIm11bHRpdXJsIl0pKSB7ICRtdWx0aXVybCA9IGV4cGxvZGUoUEhQX0VPTCwgJF9SRVFVRVNUWyJtdWx0aXVybCJdKTsgfQ0KKwlpZiAoICEgZW1wdHkoICRfUkVRVUVTVFsnbXVsdGl1cmwnXSApICkgew0KKwkJLy8gc3BsaXQgJiB0cmltIGlucHV0LCBhbmQgZGlzY2FyZCBibGFuayBsaW5lcyBpbiBvbmUgZ28NCisJCSRtdWx0aXVybCA9IHByZWdfc3BsaXQoICcvXEFccyt8XHMqP1xSXHMqK3xccytcei8nLCAkX1JFUVVFU1RbJ211bHRpdXJsJ10sIC0xLCBQUkVHX1NQTElUX05PX0VNUFRZICk7DQogDQotICAgIGlmKCFlbXB0eSgkbXVsdGl1cmwpKSB7IA0KICAgICAgICAgICAvLyAJbmF2aWdhdGUgdGhyb3VnaCBhbnkgdXJscw0KICAgICAgICAgICBmb3JlYWNoKCRtdWx0aXVybCBhcyAkbXUpIHsgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgICAgLy8JZG93bmxvYWQgYW5kIGluc2VydCBhcyBtZWRpYSBhdHRhY2htZW50DQpAQCAtMTE4LDcgKzExOSw3IEBACiAgICAgfQ0KIA0KIA0KLSAgICBlY2hvIF9fKCAnPGRpdiBpZD0ib3BlblVNQlUiIGNsYXNzPSJtb2RhbERpYWxvZyI+PGRpdj48YSBocmVmPSIiIHRpdGxlPSJDbG9zZSIgY2xhc3M9ImNsb3NlIj5YPC9hPjxoMj5VcGxvYWQgTWVkaWEgQnkgVVJMPC9oMj48cD48Zm9ybSBhY3Rpb249IiIgbWV0aG9kPSJwb3N0Ij48dGV4dGFyZWEgc3R5bGU9IndpZHRoOjEwMCU7aGVpZ2h0OjMwMHB4OyIgbmFtZT0ibXVsdGl1cmwiIHJlcXVpcmVkLz48L3RleHRhcmVhPjxicj48c21hbGw+U2VwYXJhdGUgZWFjaCBVUkwgYnkgYSBuZXcgbGluZTwvc21hbGw+PHA+PGlucHV0IHR5cGU9InN1Ym1pdCIgY2xhc3M9ImJ1dHRvbiI+IDxhIGhyZWY9IiIgY2xhc3M9ImJ1dHRvbiI+Q2FuY2VsPC9hPjwvcD48L2Zvcm0+PC9wPjwvZGl2PjwvZGl2PicpOw0KKyAgICBlY2hvIF9fKCAnPGRpdiBpZD0ib3BlblVNQlUiPjxkaXY+PGEgaHJlZj0iIyIgdGl0bGU9IkNsb3NlIiBjbGFzcz0idW1idS1jbG9zZSI+WDwvYT48aDI+VXBsb2FkIE1lZGlhIEJ5IFVSTDwvaDI+PHA+PGZvcm0gYWN0aW9uPSIiIG1ldGhvZD0icG9zdCI+PHRleHRhcmVhIHN0eWxlPSJ3aWR0aDoxMDAlO2hlaWdodDozMDBweDsiIG5hbWU9Im11bHRpdXJsIiByZXF1aXJlZC8+PC90ZXh0YXJlYT48YnI+PHNtYWxsPlNlcGFyYXRlIGVhY2ggVVJMIGJ5IGEgbmV3IGxpbmU8L3NtYWxsPjxwPjxpbnB1dCB0eXBlPSJzdWJtaXQiIGNsYXNzPSJidXR0b24iPiA8YSBocmVmPSIjIiBjbGFzcz0iYnV0dG9uIj5DYW5jZWw8L2E+PC9wPjwvZm9ybT48L3A+PC9kaXY+PC9kaXY+Jyk7DQogfQ0KIA0KIA0KLS0tIGEvd3AtY29udGVudC9wbHVnaW5zL3VwbG9hZC1tZWRpYS1ieS11cmwvYXNzZXRzL2Nzcy9wb3B1cC5jc3MKKysrIGIvd3AtY29udGVudC9wbHVnaW5zL3VwbG9hZC1tZWRpYS1ieS11cmwvYXNzZXRzL2Nzcy9wb3B1cC5jc3MKQEAgLTEgKzEgQEAKLS5tb2RhbERpYWxvZ3twb3NpdGlvbjpmaXhlZDtmb250LWZhbWlseTpBcmlhbCwgSGVsdmV0aWNhLCBzYW5zLXNlcmlmO3RvcDowO3JpZ2h0OjA7Ym90dG9tOjA7bGVmdDowO2JhY2tncm91bmQ6cmdiYSgwLDAsMCwwLjgpO3otaW5kZXg6OTk5OTk7b3BhY2l0eTowOy13ZWJraXQtdHJhbnNpdGlvbjpvcGFjaXR5IDQwMG1zIGVhc2UtaW47LW1vei10cmFuc2l0aW9uOm9wYWNpdHkgNDAwbXMgZWFzZS1pbjt0cmFuc2l0aW9uOm9wYWNpdHkgNDAwbXMgZWFzZS1pbjtwb2ludGVyLWV2ZW50czpub25lfS5tb2RhbERpYWxvZzp0YXJnZXR7b3BhY2l0eToxO3BvaW50ZXItZXZlbnRzOmF1dG99Lm1vZGFsRGlhbG9nID4gZGl2e3RvcDotNTBweDt3aWR0aDo1MCU7cG9zaXRpb246cmVsYXRpdmU7bWFyZ2luOjEwJSBhdXRvO3BhZGRpbmc6NXB4IDIwcHggMTNweDtib3JkZXItcmFkaXVzOjEwcHg7YmFja2dyb3VuZDojZmZmO2JhY2tncm91bmQ6LW1vei1saW5lYXItZ3JhZGllbnQoI2ZmZiwgIzk5OSk7YmFja2dyb3VuZDotd2Via2l0LWxpbmVhci1ncmFkaWVudCgjZmZmLCAjOTk5KTtiYWNrZ3JvdW5kOi1vLWxpbmVhci1ncmFkaWVudCgjZmZmLCAjOTk5KX0uY2xvc2V7YmFja2dyb3VuZDojNjA2MDYxO2NvbG9yOiNmZmYhaW1wb3J0YW50O2xpbmUtaGVpZ2h0OjI1cHg7cG9zaXRpb246YWJzb2x1dGU7cmlnaHQ6LTEycHg7dGV4dC1hbGlnbjpjZW50ZXI7dG9wOi0xMHB4O3dpZHRoOjI0cHg7dGV4dC1kZWNvcmF0aW9uOm5vbmU7Zm9udC13ZWlnaHQ6Ym9sZDstd2Via2l0LWJvcmRlci1yYWRpdXM6MTJweDstbW96LWJvcmRlci1yYWRpdXM6MTJweDtib3JkZXItcmFkaXVzOjEycHg7LW1vei1ib3gtc2hhZG93OjFweCAxcHggM3B4ICMwMDA7LXdlYmtpdC1ib3gtc2hhZG93OjFweCAxcHggM3B4ICMwMDA7Ym94LXNoYWRvdzoxcHggMXB4IDNweCAjMDAwfS5jbG9zZTpob3ZlcntiYWNrZ3JvdW5kOiMwMGQ5ZmZ9QG1lZGlhIG9ubHkgc2NyZWVuIGFuZCAobWF4LXdpZHRoOiA3NjhweCl7I3dwZm9vdGVye2Rpc3BsYXk6YmxvY2s7fX0KKyNvcGVuVU1CVXtwb3NpdGlvbjpmaXhlZDtmb250LWZhbWlseTpBcmlhbCwgSGVsdmV0aWNhLCBzYW5zLXNlcmlmO3RvcDowO3JpZ2h0OjA7Ym90dG9tOjA7bGVmdDowO2JhY2tncm91bmQ6cmdiYSgwLDAsMCwwLjgpO3otaW5kZXg6OTk5OTk7b3BhY2l0eTowOy13ZWJraXQtdHJhbnNpdGlvbjpvcGFjaXR5IDQwMG1zIGVhc2UtaW47LW1vei10cmFuc2l0aW9uOm9wYWNpdHkgNDAwbXMgZWFzZS1pbjt0cmFuc2l0aW9uOm9wYWNpdHkgNDAwbXMgZWFzZS1pbjtwb2ludGVyLWV2ZW50czpub25lfSNvcGVuVU1CVTp0YXJnZXR7b3BhY2l0eToxO3BvaW50ZXItZXZlbnRzOmF1dG99I29wZW5VTUJVID4gZGl2e3RvcDotNTBweDt3aWR0aDo1MCU7cG9zaXRpb246cmVsYXRpdmU7bWFyZ2luOjEwJSBhdXRvO3BhZGRpbmc6NXB4IDIwcHggMTNweDtib3JkZXItcmFkaXVzOjEwcHg7YmFja2dyb3VuZDojZmZmO2JhY2tncm91bmQ6LW1vei1saW5lYXItZ3JhZGllbnQoI2ZmZiwgIzk5OSk7YmFja2dyb3VuZDotd2Via2l0LWxpbmVhci1ncmFkaWVudCgjZmZmLCAjOTk5KTtiYWNrZ3JvdW5kOi1vLWxpbmVhci1ncmFkaWVudCgjZmZmLCAjOTk5KX0udW1idS1jbG9zZXtiYWNrZ3JvdW5kOiM2MDYwNjE7Y29sb3I6I2ZmZiFpbXBvcnRhbnQ7bGluZS1oZWlnaHQ6MjVweDtwb3NpdGlvbjphYnNvbHV0ZTtyaWdodDotMTJweDt0ZXh0LWFsaWduOmNlbnRlcjt0b3A6LTEwcHg7d2lkdGg6MjRweDt0ZXh0LWRlY29yYXRpb246bm9uZTtmb250LXdlaWdodDpib2xkOy13ZWJraXQtYm9yZGVyLXJhZGl1czoxMnB4Oy1tb3otYm9yZGVyLXJhZGl1czoxMnB4O2JvcmRlci1yYWRpdXM6MTJweDstbW96LWJveC1zaGFkb3c6MXB4IDFweCAzcHggIzAwMDstd2Via2l0LWJveC1zaGFkb3c6MXB4IDFweCAzcHggIzAwMDtib3gtc2hhZG93OjFweCAxcHggM3B4ICMwMDB9LnVtYnUtY2xvc2U6aG92ZXJ7YmFja2dyb3VuZDojMDBkOWZmfQo=?output_format=md).
   It also fixes a few things with the uploader: later permission check; close &
   cancel buttons not reloading page; and better input parsing.

Viewing 5 replies - 1 through 5 (of 5 total)

 *  Thread Starter [Roy Orbitson](https://wordpress.org/support/users/lev0/)
 * (@lev0)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16982174)
 * Looks like this forum breaks `data:` URIs, but you can just add the scheme back
   to that link’s `href` to fix it.
 *  Plugin Author [notetoservices](https://wordpress.org/support/users/notetoservices/)
 * (@notetoservices)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16984129)
 * Thanks for pointing out the error and supplying a fix. I applied your patch and
   sent the update to the SVN repository.
 *  Thread Starter [Roy Orbitson](https://wordpress.org/support/users/lev0/)
 * (@lev0)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16987605)
 * Thanks but you missed a bunch of the fixes in that patch: moving the permission
   check to after page check (permissions are irrelevant if you’re on the wrong 
   page, and they’re slower to check); you lost the `href="#"` on the close/cancel
   buttons that avoid a full page reload; and you still have the `@media` CSS that’s
   no longer needed because the popup markup is now outside the footer.
 * Any reason you excluded the other improvements? Did you have problems with the
   patch as it was?
 *  Plugin Author [notetoservices](https://wordpress.org/support/users/notetoservices/)
 * (@notetoservices)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16990528)
 * Your changes were implemented. There was one thing you proposed that broke the
   code where the openUMBU div is, so I couldn’t implement it, and I wasn’t exactly
   sure what you were doing.
 * The page reload comes to refresh the page data. I hadn’t realized you had changed
   some CSS so that was updated as well. It should be in the latest version coming
   soon.
 *  Thread Starter [Roy Orbitson](https://wordpress.org/support/users/lev0/)
 * (@lev0)
 * [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16990686)
 * Oh, sorry about that. I added `admin_url('upload.php')` for the form action in
   my patched version and it works again. I used `printf` with `esc_attr__()` and`
   esc_html__()`, as it’s not advisable to pass raw HTML for translation.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Fatal error in admin (with patch)’ is closed to new replies.

 * ![](https://s.w.org/plugins/geopattern-icon/upload-media-by-url.svg)
 * [Upload Media By URL](https://wordpress.org/plugins/upload-media-by-url/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/upload-media-by-url/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/upload-media-by-url/)
 * [Active Topics](https://wordpress.org/support/plugin/upload-media-by-url/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/upload-media-by-url/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/upload-media-by-url/reviews/)

 * 5 replies
 * 2 participants
 * Last reply from: [Roy Orbitson](https://wordpress.org/support/users/lev0/)
 * Last activity: [2 years, 9 months ago](https://wordpress.org/support/topic/fatal-error-in-admin-with-patch/#post-16990686)
 * Status: not a support question