invalid HTML around class attribute in links

  • Resolved oboklob

    (@oboklob)


    11 years, 6 months ago

    Hi, the function cff_autolink adds additional tags to links, but its default does not consider that spaces are required between attributes. So you get invalid HTML such as:

    <span class="cff-text" rel=""><a target='_blank' style='color:#' href="http://www.mysite.com/"class="cff-break-word">

    You may wish to look at this close as this could be either an issue with the above function, or that the function cff_autolink_do should be adding a space itself, Looking at the code briefly I think the former is more suitable, but this will affect all calls to cff_autolink where a tagfill is specified.

    Perhaps add some small code to add a leading space to the variable if none exists?

    The following change though on line 1784 of custom-facebook-feed.php solves my immediate issue:

    function cff_autolink($text, $link_color='', $span_tag = false, $limit=100, $tagfill=' class="cff-break-word"', $auto_title = true){

    BTW this is present in version 2.2.1

    https://ww.wp.xz.cn/plugins/custom-facebook-feed/

Viewing 1 replies (of 1 total)
  • Plugin Author smashballoon

    (@smashballoon)

    11 years, 6 months ago

    Hey oboklob,

    Thanks for letting me know. I’ll actually be changing the way the links are formed in the next update which should solve this problem. Glad to hear you were able to track down where to fix this. Thanks again for reporting the bug! 🙂

    John

Viewing 1 replies (of 1 total)

The topic ‘invalid HTML around class attribute in links’ is closed to new replies.