jquery fix needed to prepare for wordpress 5.7

  • mjvito

    (@mjvito)


    3 years, 4 months ago

    Hi-

    Everything is fine for the moment, but giving you a heads up for a fix that will need to happen before the next wordpress core update. wordpress 5.6 brings the change to jQuery 3.5.1, with jQuery Migrate 3.3.2 also included as a bridge. When I disable jQuery Migrate I get the following in console:

    Uncaught TypeError: e.indexOf is not a function
    load jQuery
    <anonymous> https://likeafishinwater.com/wp-content/wptouch-data/cache/wptouch-6e3adf72269dcd3f290cda07634fabdfa824d98e.js:15

    Line 15 in that script is this:

    function bindTappableEls(e){jQuery(e).each(function(){jQuery(this).tappable({touchDelay:74})})}jQuery(window).load(function(){bindTappableEls(".tappable, .show-hide-toggle, .slide-toggle, .menu-btn")}),jQuery(document).ajaxComplete(function(){bindTappableEls(".tappable, .show-hide-toggle, .slide-toggle, .menu-btn")});

    Thanks

    • This topic was modified 3 years, 4 months ago by mjvito.
    • This topic was modified 3 years, 4 months ago by mjvito.

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • kitchin

    (@kitchin)

    3 years, 2 months ago

    Agreed, but it’s worse. Even with the bridge script in code, WPTouch cannot do some things, like change menu icons. For now, that feature will work via the official WP plugin “Enable jQuery Migrate Helper” from https://ww.wp.xz.cn/plugins/enable-jquery-migrate-helper/

    kitchin

    (@kitchin)

    3 years, 2 months ago

    Note, WPTouch Pro has a feature called “jQuery Enhanced.” That may explain the delay in fixing jQuery in the free version.

    Thread Starter mjvito

    (@mjvito)

    3 years, 2 months ago

    Thanks for the additional details. I should have been clearer in my post, this is with WPTouch Pro. (jQuery Enhanced is not installed.)

    I can understand the utility of jQuery Enhanced back when WP core was in the jQuery stone age, but now that it’s finally getting current, I’d think WPTouch Pro (and free) should just work with it out of the box.

    Thread Starter mjvito

    (@mjvito)

    2 years, 11 months ago

    I upgraded to WPTouch Pro 4.3.38, which corresponds to WPTouch free 4.3.41. The developer has not fixed the deprecated code which is the underlying problem, only added a call for jQuery Migrate 3.3.2.

    This isn’t a fix, just a band-aid. Please do better.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘jquery fix needed to prepare for wordpress 5.7’ is closed to new replies.