Title: JS code improvement
Last modified: August 22, 2016

---

# JS code improvement

 *  Resolved [Igor Jerosimić](https://wordpress.org/support/users/x64igor/)
 * (@x64igor)
 * [11 years, 2 months ago](https://wordpress.org/support/topic/js-code-improvement/)
 * I noticed that your Javascript code assumes that product has either all select
   boxes or all input fields. I have worked on several websites that have one select
   and one input which fails with your current JS code.
 * I propose Javascript change to amend this:
 *     ```
       $( '.ajaxerrors' ).remove();
       var item = {},
           check = true,
           variations = $variation_form.find( '[name^=attribute]' );
   
       variations.each( function() {
   
           var $this = $( this ),
               attributeName = $this.attr( 'name' ),
               attributevalue = $this.val(),
               index,
               attributeTaxName;
   
           $this.removeClass( 'error' );
   
           if ( attributevalue.length === 0 ) {
               index = attributeName.lastIndexOf( '_' );
               attributeTaxName = attributeName.substring( index + 1 );
   
               $this
                   //.css( 'border', '1px solid red' )
                   .addClass( 'required error' )
                   //.addClass( 'barizi-class' )
                   .before( '<div class="ajaxerrors"><p>Please select ' + attributeTaxName + '</p></div>' )
   
               check = false;
           } else {
               item[attributeName] = attributevalue;
           }
   
           // Easy to add some specific code for select but doesn't seem to be needed
           // if ( $this.is( 'select' ) ) {
           // } else {
           // }
   
       } );
   
       if ( !check ) {
           return false;
       }
       ```
   
 * [https://wordpress.org/plugins/woocommerce-ajax-add-to-cart-for-variable-products/](https://wordpress.org/plugins/woocommerce-ajax-add-to-cart-for-variable-products/)

Viewing 1 replies (of 1 total)

 *  Plugin Author [Rishi Mehta](https://wordpress.org/support/users/rcreators/)
 * (@rcreators)
 * [11 years, 2 months ago](https://wordpress.org/support/topic/js-code-improvement/#post-5885216)
 * Hi,
 * Thanks for the sharing code. i will update jquery as per your inputs and will
   update it in upcoming update.

Viewing 1 replies (of 1 total)

The topic ‘JS code improvement’ is closed to new replies.

 * ![](https://s.w.org/plugins/geopattern-icon/woocommerce-ajax-add-to-cart-for-
   variable-products_fbfbfa.svg)
 * [Woocommerce Ajax add to cart for variable products](https://wordpress.org/plugins/woocommerce-ajax-add-to-cart-for-variable-products/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/woocommerce-ajax-add-to-cart-for-variable-products/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/woocommerce-ajax-add-to-cart-for-variable-products/)
 * [Active Topics](https://wordpress.org/support/plugin/woocommerce-ajax-add-to-cart-for-variable-products/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/woocommerce-ajax-add-to-cart-for-variable-products/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/woocommerce-ajax-add-to-cart-for-variable-products/reviews/)

 * 1 reply
 * 2 participants
 * Last reply from: [Rishi Mehta](https://wordpress.org/support/users/rcreators/)
 * Last activity: [11 years, 2 months ago](https://wordpress.org/support/topic/js-code-improvement/#post-5885216)
 * Status: resolved