Viewing 7 replies - 1 through 7 (of 7 total)
  • Michael

    (@alchymyth)

    line 394 in style.css:

    li {
    	line-height: 0.1em;
    	}

    btw:
    working with a child theme or at least with a custom css plugin makes finding errors in edited styles much easier.

    Thread Starter carnelian

    (@carnelian)

    Thanks!

    Why is it easier working with a child theme?

    Michael

    (@alchymyth)

    Why is it easier working with a child theme?

    this is obviously open to debate.

    in my opinion, in a child theme, you only have the changed styles, which are genrally much less than the 2000+ lines of style.css in the parent theme.

    you also only have the few templates you might have been edited.

    child themes, particular those of the default themes that come with a WordPress installation, also benefit from the ongoing upgrading of the theme’s coding to keep track with the latest WordPress functionalities.

    only with large customisations, where most of the templates are changed and many of the styles are edited, there will be a point where it would be easier to ‘fork’ the theme, i.e. save it under a new theme name in a new theme folder.

    Thread Starter carnelian

    (@carnelian)

    But I do large customisations. I change a lot in my themes. I work in a text editor where I can look at both the original code and my own code.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    What about the obvious one – Alchymyth – When the theme updates? I ask because her theme still has its original name.

    Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    It’s a judgement call on the part of the designer. Meaning if the designer is making wholesale PHP changes to the original theme then it’s advantageous to fork (make a new copy with a new name) that theme.

    The majority of changes that people want to make to a theme are just to the CSS. Occasionally that may include some minor template changes and that’s a good candidate for a child theme.

    When the child theme has modified copies of the parent template files (say 5 or more) than that’s a good time to consider making a fork. 😉

    Michael

    (@alchymyth)

    +1 to @jan Dembowski

    @carnelian
    one last thing: if your original question is anwered, please mark this topic as ‘resolved’ – thanks 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Line-height issue with comments’ is closed to new replies.