• Resolved jsowers897

    (@jsowers897)


    The other thread has been marked resolved, but the problem has not been resolved, the fix linked does not apply to Ad Groups that are not using Block or Dynamic, so I have posted this here since the other thread is mistakenly marked as Resolved.

    Your updates completely screwed up the ads sizes and alignment. And before you post a link to that we need to set our group sizes, you need to consider that not all groups have the same size banners, and also group size is only for block mode, which I do not use, and the ads are still be cut off and moved to the left, so your solution is not a solution at all. Please fix.

    These DIVs seem to be causing the issue
    <div class="g g-1"><div class="g-single a-18">

    After looking at the styles added, seems as though you are adding block style to ads that are not using block mode. My ads do not use block and this style have been added to the header along with the divs wrappers listed above.

    .g { position:relative; margin:0px; padding:0px; overflow:hidden; line-height:1; zoom:1; }
    	.g-dyn { display:none; }
    	.g-col { position:relative; float:left; }
    	.g-col:first-child { margin-left: 0; }
    	.g-col:last-child { margin-right: 0; }
    	.g-1 { margin:1px; min-width:1px; max-width:127px; min-height:1px; max-height:127px; }
    @media only screen and (max-width: 480px) {
    		.g-col, .g-dyn, .g-single, .g-postinject { width:100%; margin-left:0; margin-right:0; }
    	}

    This is where the problem lies. You are applying Block styles even though Block is not selected in the Group Settings.

    I said it before, but I’ll say it again. Ad Groups do not necessarily have the same size banners in them, i.e. some are 468×60, 468×80, 600×250, etc, because the area that they are put may allow a variety of sizes.

    I was able to fix the problem by adding this to my child theme style.css file

    /* AdRotate Fix */
    .g { position:relative; margin:0px; padding:0px; overflow:visible !important; line-height:1; zoom:1; }
    	.g-1 { margin:1px; min-width:1px; max-width:100% !important; min-height:1px; max-height:100% !important; }

    The changes were the max-width & max-height to 100% !important in the .g-1 class, and also the overflow: visible !important in the .g class.

    I am assuming that .g-1 is for group 1 and .g-2 is for group 2, etc, so you will need to change each one for each group you have. I only posted .g-1 to keep it short.

    But with over 100 sites running ads, this is a huge task to fix this way.

    https://ww.wp.xz.cn/plugins/adrotate/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Arnan

    (@adegans)

    Right, but to have responsive themes handle the ads better you *do* need to set the size for all modes now. This is new in AdRotate 3.10 and onwards.

    If you have a lot of sites this may be a daunting task and may seem like a annoying thing – But that changes nothing about the new requirement.

    If your ads are not equally sizes you can try to use ‘auto’ for the sizing but not all themes can handle that. (as noted as an option in your dashboard.)

    If you show several ads for example 468×60 mixed with 728×90 you can pick the larger advert for the size if the ‘auto’ setting doesn’t work. Using something like <center> or <div class="aligncenter"> or <div style="margin: 0 auto;"> in the group wrapper will make sure the ads are properly centered if you need it (or they may align to the left).

    So yes, it is related to your issue and yes, following the suggestion *does* fix the issue – https://www.adrotateplugin.com/2014/07/group-sizing-and-cut-off-adverts-and-group-sizing/

    Thread Starter jsowers897

    (@jsowers897)

    Sorry but you are wrong. I know how to make styles for my ads to make them work on Responsive Themes, I don’t need you to force your sizes upon me. Your DIVs are breaking the ads, plain and simple.

    Like it says in the dashboard? You mean this?
    Dynamic and Block Mode
    Only required if your group is in Dynamic or Block mode.

    Why don’t you just simply fix your plugin so that your block DIVS are only added when they are needed and Block Mode is selected? Seems like a pretty simple solution to me.

    Thread Starter jsowers897

    (@jsowers897)

    Also responsive themes, well ones that work correctly anyway, automatically resize images, that’s why they are called Responsive. As long as you do not include a width= and height= in the img tag the theme will resize the images appropriately. So your update for responsive themes is not even necessary for the non-block ads.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Non Block & Dynamic Ad Groups are broken’ is closed to new replies.