Notices if WP_DEBUG is enabled

Resolved

(@papik81)

It throws notices if the variable is not found: from 139 to 144: Id recomend update this code:

public function woocommerce_formatted_address_replacements( $replace, $args) {
		extract( $args );
		return $replace += array(
			'{company_number}' => $company_number == '' ? '' : __('Company number: ', 'custom-account-fields') . $company_number,
			'{vat_number}' => $vat_number == '' ? '' : __('VAT number: ', 'custom-account-fields') . $vat_number,
			'{vat_number_2}' => $vat_number_2 == '' ? '' : __('VAT number 2: ', 'custom-account-fields') . $vat_number_2,
			'{company_number_upper}' => strtoupper($company_number == '' ? '' : __('Company number: ', 'custom-account-fields') . $company_number),
			'{vat_number_upper}' => strtoupper($vat_number == '' ? '' : __('VAT number: ', 'custom-account-fields') . $vat_number),
			'{vat_number_upper_2}' => strtoupper($vat_number_2 == '' ? '' : __('VAT number 2: ', 'custom-account-fields') . $vat_number_2),
		);
	}

public function woocommerce_formatted_address_replacements( $replace, $args) {
		 return $replace += array(
			'{company_number}' => isset($args['company_number']) ?  __('Company number: ', 'custom-account-fields') .$args['company_number'] : '',
     	    '{vat_number}' => isset($args['vat_number']) ?  __('VAT number: ', 'custom-account-fields') . $args['vat_number'] : '',
			'{vat_number_2}' => isset($args['vat_number_2']) ?  __('VAT number 2: ', 'custom-account-fields') . $args['vat_number_2'] :'',
			'{company_number_upper}' => strtoupper(isset($args['company_number']) ?__('Company number: ', 'custom-account-fields') . $args['company_number'] : '' ),
			'{vat_number_upper}' => strtoupper(isset($args['vat_number']) ? __('VAT number: ', 'custom-account-fields') . $args['vat_number'] : ''),
			'{vat_number_upper_2}' => strtoupper(isset($args['vat_number_2']) ? __('VAT number 2: ', 'custom-account-fields') . $args['vat_number_2'] : '') ,
			);
	}

I also recomend to remove the extract function cause here it is not the best idea.

https://ww.wp.xz.cn/plugins/custom-account-fields/

Viewing 2 replies - 1 through 2 (of 2 total)

Thread Starter

Papik81

(@papik81)

11 years, 4 months ago

CZ: Pokud je zapnutý debug a není zcela vyplněný profil fakturační adresy, vypisuje to hlášky :variable is not found: from 139 to 144: Id doporučil bych aktualizovat kód:

public function woocommerce_formatted_address_replacements( $replace, $args) {
		extract( $args );
		return $replace += array(
			'{company_number}' => $company_number == '' ? '' : __('Company number: ', 'custom-account-fields') . $company_number,
			'{vat_number}' => $vat_number == '' ? '' : __('VAT number: ', 'custom-account-fields') . $vat_number,
			'{vat_number_2}' => $vat_number_2 == '' ? '' : __('VAT number 2: ', 'custom-account-fields') . $vat_number_2,
			'{company_number_upper}' => strtoupper($company_number == '' ? '' : __('Company number: ', 'custom-account-fields') . $company_number),
			'{vat_number_upper}' => strtoupper($vat_number == '' ? '' : __('VAT number: ', 'custom-account-fields') . $vat_number),
			'{vat_number_upper_2}' => strtoupper($vat_number_2 == '' ? '' : __('VAT number 2: ', 'custom-account-fields') . $vat_number_2),
		);
	}

public function woocommerce_formatted_address_replacements( $replace, $args) {
		 return $replace += array(
			'{company_number}' => isset($args['company_number']) ?  __('Company number: ', 'custom-account-fields') .$args['company_number'] : '',
     	    '{vat_number}' => isset($args['vat_number']) ?  __('VAT number: ', 'custom-account-fields') . $args['vat_number'] : '',
			'{vat_number_2}' => isset($args['vat_number_2']) ?  __('VAT number 2: ', 'custom-account-fields') . $args['vat_number_2'] :'',
			'{company_number_upper}' => strtoupper(isset($args['company_number']) ?__('Company number: ', 'custom-account-fields') . $args['company_number'] : '' ),
			'{vat_number_upper}' => strtoupper(isset($args['vat_number']) ? __('VAT number: ', 'custom-account-fields') . $args['vat_number'] : ''),
			'{vat_number_upper_2}' => strtoupper(isset($args['vat_number_2']) ? __('VAT number 2: ', 'custom-account-fields') . $args['vat_number_2'] : '') ,
			);
	}

Také doporučuji nepoužívat funkci extract a přistupovat přímo do pole.

Plugin Author

tomas.slavik

(@tomasslavik)

11 years, 4 months ago

Ok. Thank you for recommendation. Updated.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Notices if WP_DEBUG is enabled’ is closed to new replies.