Plugin Breaks Another Plugin's Featured Image – It's Back

polybearsfootball
(@polybearsfootball)

10 years, 1 month ago
Hey Mark,

We chatted about three years ago on a Featured Image issue, and it was happening again recently so I wanted to bring it to your attention.

Below is the original thread, but the summary is I am using a ThemeFuse them that does not use Featured Images, I have enabled it through the child theme functions.php using:

add_theme_support('post-thumbnails');

Last time the issue was some code, listed below, in Team Rosters that was a conflict with Simple Staff List.

‘add_action( ‘after_setup_theme’, ‘mstw_tr_add_feat_img’ );
function mstw_tr_add_feat_img( ) {
if ( function_exists( ‘add_theme_support’ ) )
add_theme_support( ‘post-thumbnails’, array( ‘player’ ) );
}’

As the symptoms were exactly the same this time I checked the original thread and found the current version has this code again:
```
add_action( 'after_setup_theme', 'mstw_tr_add_feat_img' );
 function mstw_tr_add_feat_img( ) {
	add_theme_support( 'post-thumbnails', array( 'mstw_tr_player' ) );
 }
```
Removing that code fixes the issue.

Here is our original thread:

https://ww.wp.xz.cn/support/topic/plugin-breaks-another-plugins-featured-image?replies=12

Love the plugin, and thanks again. Also, this recent thread may be related.

https://ww.wp.xz.cn/support/topic/cannot-set-featured-image-4?replies=2

https://ww.wp.xz.cn/plugins/team-rosters/

Viewing 7 replies - 1 through 7 (of 7 total)

Thread Starter polybearsfootball
(@polybearsfootball)

10 years ago

Hey Mark,

Any thoughts on this issue? I am concerned about updates breaking it again.

Thanks!

Plugin Author Mark O’Donnell
(@markodonnell)

10 years ago

Hey Razz,
Thanks for the update. This issue has been bouncing around ever since you seemed to figure it out. The challenge is that if I remove the lines you suggest, then the player photos won’t work at all in themes that do not have post-thumbnails enabled. There seem to be a couple of other issues going on in some (“premium”) themes as well. As a result, I have tried a number of things, none of which seem to work “everywhere”. I think the dev trunk has some of them in there, and you might try it if you are in the mood to play around.

It remains unclear to me why this should break a theme. (It does not break the “standard” WP themes.) But whatevs. I am going to try to condition theme call (which I’d prefer not to make to begin with) and see what I can do (fix? break?).

Stay tuned.
-Mark

Plugin Author Mark O’Donnell
(@markodonnell)

10 years ago

Hey Razz,
I just posted what I believe to be a fix to the development trunk. (Thanks to my man Pippin Williamson. Pippin’s Plugins rock, BTW.) If you would try it out and let me know, I would greatly appreciate it.
Thanks.
-Mark

Thread Starter polybearsfootball
(@polybearsfootball)

10 years ago

Sure thing Mark. Whatever helps you. When you mention the Dev Trunk I assume you me the current Development Version(svn) that is listed under Other Versions?

Do you want me to replace the whole the plugin folder or just the mstw-team-rosters.php file?

UPDATE: Never mind. I am just swapping the whole folder. I will let you know the results.

Thread Starter polybearsfootball
(@polybearsfootball)

10 years ago

Hey Mark,

First, thanks for all you do. Seriously mean that.

OK, So I downloaded the Development Version(svn), but in WP it does still show as 4.0.1. The code does look changed however and I like the look of your solution. I deleted the old plugin folder (after a backup to save my edited version) and uploaded the test version. As best as I can tell all is working OK. I have asked the people that really use the site to test it too and report back.

If I hear anything from them I will post back here. I am assuming the plugin will update as needed still even though the Dev ver is installed, so I have a backup of my fix just in case your solution isn’t included in the next version.

Thanks Mark!

Plugin Author Mark O’Donnell
(@markodonnell)

10 years ago

Well, this sounds promising. You only needed the one file. The version will not change (because it is not released). Please let me know what you here back from your users. If the solution works, it will be in the next version.

Thanks.
-Mark

P.S. Are you a Gold Support member?
-M

Thread Starter polybearsfootball
(@polybearsfootball)

10 years ago

Hey Mark,

The Team answered back that they are seeing the same result, meaning it seems to be working as expected.

I / We are not Gold Support members. It’s a HS Football Team, so they’re non-profit. I actually am not part of the team, but I help as a favor for a friend when they need it with email or site updates etc. (I have a good deal of dev experience, and I am an MCSE by trade) Your plugin was one of the first I used for them, and one of the rare occasions I have ever given a plugin a 5 star rating.

I did just donate to you, on their behalf. Thanks for your work in solving this man.

Razz

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Plugin Breaks Another Plugin's Featured Image – It's Back’ is closed to new replies.

Tags