Title: Plugin developer advice
Last modified: August 20, 2016

---

# Plugin developer advice

 *  [Yaron Guez](https://wordpress.org/support/users/yguez/)
 * (@yguez)
 * [13 years, 7 months ago](https://wordpress.org/support/topic/plugin-developer-advice/)
 * Hi, great plugin! I’ve got some advice on changes to implement within your code.
 * 1. On line 39 of plugin.ui.php you should check isset($_SERVER[“HTTPS”]) before
   seeing if it is on. A lot of servers don’t have this set at all which causes 
   an error. See [http://stackoverflow.com/questions/4911532/undefined-index-error-using-serverhttps](http://stackoverflow.com/questions/4911532/undefined-index-error-using-serverhttps)
 * 2. You should include filters that will allow a developer to use a different 
   png image for the login. Asking us to replace the pngs in the plugin folder is
   bad practice. This will break the moment we upgrade it. Better yet, check if 
   a folder like wordpress-social-login exists in the theme folder and use that 
   for $assets_base_url if it does.
 * 3. You give instructions on manually inserting the social login buttons but don’t
   provide instructions on removing them from where they are inserted automatically.
   I presume this can be done with remove_action( ‘login_form’, ‘wsl_render_login_form_login’);
   but I haven’t tried it yet.
 * Those are my only complaints so far. Thanks and keep up the good work!
 * [http://wordpress.org/extend/plugins/wordpress-social-login/](http://wordpress.org/extend/plugins/wordpress-social-login/)

Viewing 3 replies - 1 through 3 (of 3 total)

 *  Thread Starter [Yaron Guez](https://wordpress.org/support/users/yguez/)
 * (@yguez)
 * [13 years, 7 months ago](https://wordpress.org/support/topic/plugin-developer-advice/#post-3143162)
 * Another piece of feedback…shortcodes are supposed to return content not output
   it. Otherwise the content does not get displayed in within the flow of the post
   rather at the top. I wrote my own shortcode to display the login buttons properly:
 *     ```
       function output_social_login($atts)
       {
       	ob_start();
       	do_action( 'wordpress_social_login' );
       	$output = ob_get_clean();
       	return $output;
       }
       add_shortcode('social_login','output_social_login');
       ```
   
 *  [joo1976](https://wordpress.org/support/users/joo1976/)
 * (@joo1976)
 * [13 years ago](https://wordpress.org/support/topic/plugin-developer-advice/#post-3143222)
 * Seems that the developer doesn’t read the feedbacks … 🙁
 *  [esmi](https://wordpress.org/support/users/esmi/)
 * (@esmi)
 * [13 years ago](https://wordpress.org/support/topic/plugin-developer-advice/#post-3143223)
 * Try posting your own topic instead of tagging onto a 7 month old one.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Plugin developer advice’ is closed to new replies.

 * ![](https://s.w.org/plugins/geopattern-icon/wordpress-social-login_a1a2bc.svg)
 * [WordPress Social Login](https://wordpress.org/plugins/wordpress-social-login/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/wordpress-social-login/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/wordpress-social-login/)
 * [Active Topics](https://wordpress.org/support/plugin/wordpress-social-login/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/wordpress-social-login/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/wordpress-social-login/reviews/)

 * 3 replies
 * 3 participants
 * Last reply from: [esmi](https://wordpress.org/support/users/esmi/)
 * Last activity: [13 years ago](https://wordpress.org/support/topic/plugin-developer-advice/#post-3143223)
 * Status: not resolved