Good catch, fwaggle. This might just be an oversight from ogre, but given the nature of the code, I find that really hard to believe. Still grateful for the fix, as it DID solve the problem… But I have removed the offending code now. I would have supported ogre’s efforts if he had been clear on this, but this lack of transparency is unacceptable.
Glad you came through and cleaned it, fwaggle. Thank you.
thank you so much for updating this!!
I still have an issue though, when i try to insert a photoset, i hit the ‘insert into post’ button, and it won’t do anything. i tried this in chrome and IE and got the same results. i’m on wordpress 2.8.1 and just uploaded the plugin.
@1ayah: wordpress-flickr-manager/js/media-panel.php, line #143, take the @ symbol out:
var imgHTML = '[flickrset id="' + id + '" thumbnail="' + jQuery("input[@name='flickr-size...
becomes:
var imgHTML = '[flickrset id="' + id + '" thumbnail="' + jQuery("input[name='flickr-size...
Seems to work for me now. I’ll update the one for download on my site.
Edit: Updated the download @ fwaggle.org so that inserting photosets works.
@teampl4y4: Inserting arbitrary HTML in a surreptitious way remotely without any disclosure is most definitely not the same as “this theme designed by XXX”.
@triseult: Indeed, if only the insertion of links was as transparent as the sockpuppet that teampl4y4 is.
Fwaggle: Another feature which ogre fixed was Lightbox overlay… It doesn’t seem to be working with your version of the plugin, however.
@triseult: in wordpress-flickr-manager/js/wfm-lightbox.php, on or around line #91, change:
wfmJS('a[@rel*=flickr-mgr]').each(function(){
to:
wfmJS('a[rel*=flickr-mgr]').each(function(){
It appears to work for me. Let me just double check I didn’t miss anything else stupid, and I’ll update this post. I must confess I don’t use too much of the features of this plugin and only originally tested the bit I use (vanilla inserting photo into a post).
Nope, I believe that’s it. I fixed the package on my site also.
Fwaggle: Works like a charm!!!!! THANK YOU for the fix, and for being on the watch for sneaky code. You rock!!
@valkyrie66: Thanks, and I’ll simply reiterate here because I’ve gotten a couple emails and one ping-back about it… credit for the fix still 100% lays with ogrethegreat – I don’t know enough about jQuery to have fixed it myself.
The truth is if @ogrethegreat submitted a theme like this to WordPress, full of spammy SEO links, they would have rejected it.
@fwaggle, you rock for looking into the code and you stand on that rock because you stayed up with this thread to explain to people what was going on.
Hooray for WordPress Heros!
Adria
Um, I love all this–especially the spelunking for bad code. But I don’t like that I can’t edit posts if either of these plugins are active? Anybody else have this issue??
WEIRD. I seem to have “cleared” some sort of blockage? I deactivated it (along with a couple of other plugins which were probably the culprit) and refreshed the edit post menu in another window and it worked! I reactivated Fwaggle’s version and it’s golden! Thanks SO MUCH!
I have this working basically on 2.8.3 thanks to the smarter people above, but there is no play on either highslide or lightbox. Every inserted photo is just a link to the Flickr page.
This may be because I’m not using the plugin properly, so I’m asking for users who have this working to help explain exactly how they activate this. There is a checkbox for “Javascript Viewer” and some other very sparse settings at the bottom of the insertion popup window. Is this related? I haven’t figured out if it is doing anything.
Any suggestions on how to get either highslide or lightbox working correctly would be greatly appreciated! Again I’m thinking it may just be “user error” as I don’t understand how to call these functions from the insert box (or otherwise).
Wow, no this is a mess. I worked on a long post with pictures inserted (which functioned very nicely)…and saved it…went back and its GONE! Yikes. This plugin seems to have some weird issues with WP 2.8.3
I hope a fix comes along soon. Coding pictures the long way really sucks. Thanks for trying to get this fixed, but it doesn’t seem to be working properly.
Wowzers. I’m having the same problem, where thumbnails are linked to Flickr rather than opening in Lightbox. Strange thing is, it’s only happening on a couple of my sites – the others are working fine. The difference between WP 2.8.2 and 2.8.4?
Any help is appreciated!
I don’t know what causes it, but I noticed that the Lightbox doesn’t work with some themes, and works fine with others. Try setting your theme to one with which you know it works, and see if that helps… Unfortunately, I don’t know why certain themes break it.
