Title: Pull request: fix proposal
Last modified: August 30, 2016

---

# Pull request: fix proposal

 *  [eventualo](https://wordpress.org/support/users/eventualo/)
 * (@eventualo)
 * [10 years, 8 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/)
 * Hi,
    I’d like to suggest a fix to the plugin code. I looked for a repo on github
   to make a pull request but I couldn’t find it, so I’m writing here.
 * In `icegram.php` main file, inside `icegram_load_data()` function, there is this
   line (n.521 in v.1.9.7.1) where you set the js object properties:
 * `$icegram_pre_data['post_obj'] = $_GET;`
 * In our environment, the $_GET is not always an array, because of server setup
   and other plugin filters. And when it’s not an array the object properties are
   not properly set and the Icegram retargeting routine does not work as expected.
   
   So simply I suggest an explicit type-casting and the patched line should be:
 * `$icegram_pre_data['post_obj'] = (array)$_GET;`
 * In this way it’s always working.
 * I hope you can accept and include it in next release.
 * [https://wordpress.org/plugins/icegram/](https://wordpress.org/plugins/icegram/)

Viewing 4 replies - 1 through 4 (of 4 total)

 *  Plugin Author [Icegram](https://wordpress.org/support/users/icegram/)
 * (@icegram)
 * [10 years, 8 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/#post-6559714)
 * [@eventualo](https://wordpress.org/support/users/eventualo/)
 * Thank you for pointing out this.
    We will surely look into this and incorporate
   in Icegram. It will be fixed in next release.
 * Thanks,
    Sandhya Team Icegram
 *  Thread Starter [eventualo](https://wordpress.org/support/users/eventualo/)
 * (@eventualo)
 * [10 years, 8 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/#post-6559909)
 * Hi, the fix was not included in 1.9.8.1, isn’t it?
 *  Plugin Author [Icegram](https://wordpress.org/support/users/icegram/)
 * (@icegram)
 * [10 years, 8 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/#post-6559915)
 * Hi,
 * Sorry, we have not included in our last released version.
    Once we verify this
   fix with all use cases then only we will include in our future release version.
 * Thanks,
    Nishit Shah Team Icegram
 *  Thread Starter [eventualo](https://wordpress.org/support/users/eventualo/)
 * (@eventualo)
 * [9 years, 6 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/#post-8497975)
 * News about it? Thanks

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Pull request: fix proposal’ is closed to new replies.

 * ![](https://ps.w.org/icegram/assets/icon-128x128.gif?rev=3469073)
 * [Icegram Engage – Popups, Optins, CTAs & Lead Generation](https://wordpress.org/plugins/icegram/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/icegram/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/icegram/)
 * [Active Topics](https://wordpress.org/support/plugin/icegram/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/icegram/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/icegram/reviews/)

 * 4 replies
 * 2 participants
 * Last reply from: [eventualo](https://wordpress.org/support/users/eventualo/)
 * Last activity: [9 years, 6 months ago](https://wordpress.org/support/topic/pull-request-fix-proposal/#post-8497975)
 * Status: not resolved