Title: Recomendations for plugin
Last modified: May 13, 2018

---

# Recomendations for plugin

 *  Resolved [ttremain](https://wordpress.org/support/users/ttremain/)
 * (@ttremain)
 * [8 years ago](https://wordpress.org/support/topic/recomendations-for-plugin/)
 * I installed this last night, and I have a few suggestions.
 * 1) When saving the new salts, add \r\n to each salt line instead of just \n
 * 2) You read and write the files for each salt. You should read once, and write
   once. I’d read in all lines into an array, illiterate through them for each salt,
   then save once.
 * 3) MAJOR!! you are changing the permissions on the file to a read only file, 
   after changing only the first salt. The remaining salts never get changed, nor
   can you change the salts the following week (day or month)
 * 4) in core.class.php you get the name of the config file by checking if the file
   exists, ” ABSPATH . ‘wp-config.php’ “.. This file will ALWAYS exist, even if 
   you move your wp-config.php to a non public folder, because the file still has
   to exist to use to include the “moved” file. There needs to be another way to
   do this, but I’m not sure how yet. Maybe define a constant in the original location
   for your wp-config, before doing the include?
    -  This topic was modified 8 years ago by [ttremain](https://wordpress.org/support/users/ttremain/).

Viewing 1 replies (of 1 total)

 *  Plugin Author [Nagdy](https://wordpress.org/support/users/nagdy/)
 * (@nagdy)
 * [8 years ago](https://wordpress.org/support/topic/recomendations-for-plugin/#post-10376897)
 * Hi,
 * [@ttremain](https://wordpress.org/support/users/ttremain/), I’m moving your suggestions
   and requirements to github repo [https://github.com/amElnagdy/salt-shaker](https://github.com/amElnagdy/salt-shaker)
 * [https://github.com/amElnagdy/salt-shaker/issues/12](https://github.com/amElnagdy/salt-shaker/issues/12)

Viewing 1 replies (of 1 total)

The topic ‘Recomendations for plugin’ is closed to new replies.

 * ![](https://ps.w.org/salt-shaker/assets/icon-256x256.png?rev=2654890)
 * [Salt Shaker](https://wordpress.org/plugins/salt-shaker/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/salt-shaker/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/salt-shaker/)
 * [Active Topics](https://wordpress.org/support/plugin/salt-shaker/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/salt-shaker/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/salt-shaker/reviews/)

 * 1 reply
 * 2 participants
 * Last reply from: [Nagdy](https://wordpress.org/support/users/nagdy/)
 * Last activity: [8 years ago](https://wordpress.org/support/topic/recomendations-for-plugin/#post-10376897)
 * Status: resolved