Redux framework notices

  • Resolved Ewout

    (@pomegranate)


    8 years, 8 months ago

    I often use this excellent plugin on testing sites and get these notices after activating the plugin:

    I think you need to finish some loose ends in setting up the integration with Redux, I don’t think these messages are intended to be shown in the end product.

    Just a minor issue, but since I think this is an awesome plugin I wanted to give you this heads up 🙂 (especially since some people have complained about this, thinking Redux is some sort of adware).

    Additionally, you can remove the redux framework menu (Tools > Redux Framework) with a simple action in your main plugin. For example in WPML_Plugin.php in addActionsAndFilters:

    
add_action( 'admin_menu', array(&$this, 'removeReduxMenu'), 99 );

    adding the function:

    
    public function removeReduxMenu() {
        remove_submenu_page( 'tools.php', 'redux-about' );
    }

    5 star review on the way!

    Ewout

    • This topic was modified 8 years, 8 months ago by Ewout. Reason: added tips for removing redux menu
Viewing 8 replies - 1 through 8 (of 8 total)
  • No3x

    (@no3x)

    8 years, 8 months ago

    Hi @pomegranate,

    I will copy/paste my default text at first:
    The plugin comes with a framework called Redux. Redux adds this additionally menu entry “Redux Framework 3.6” while the plugin is enabled.
    If you deactivate the plugin no files are removed.

    The framework is an implementation detail of the settings for the plugin. It is used for the settings page and everywhere in the plugin where these settings are evaluated. I could develop my own settings mechanism with all the sliders, toggles etc. But I decided to use a sophisticated and very neat framework. The drawback of this is an additional settings page made by the framework “Hi there! This is redux a settings framework. You can also install the redux plugin for updates. Probably even more plugins will use redux in the future because WordPress doesn’t provide a proper settings framework.”

    I understand that’s a bit annoying. I don’t need this redux submenu either but the framework authors made a decision to use it.

    More Details about the redux framework decision and explanation how to remove this submenu: https://github.com/reduxframework/redux-framework/issues/2209

    I think this ads are visible if WP_DEBUG is defined only. As redux might think you’r a developer. I did not intend to show any ads.

    I don’t feel comfortable with removing redux stuff. I use their framework and since they don’t have an option to hide this stuff I don’t think they want it to be removed. Also there would be issues like “I installed your plugin and now the redux page is gone. What are you doing?”

    The plugin is open source and anybody is invited to contribute. There is also discussion about removing redux completely on GitHub. I won’t make the effort to implement a settings framework but would not reject any change on the settings implementation.

    https://ww.wp.xz.cn/support/topic/nice-plugin-but-the-redux-splash-page-is-confusing/
    https://ww.wp.xz.cn/support/topic/installs-unwanted-framework/
    https://ww.wp.xz.cn/support/topic/this-plugin-install-hide-aditional-r-framework-1-star-for-this/
    https://ww.wp.xz.cn/support/topic/thi-plugin-install-hide-redux-framevork/
    https://ww.wp.xz.cn/support/topic/disable-demo-mode-of-redux/

    • This reply was modified 8 years, 8 months ago by No3x.
    • This reply was modified 8 years, 8 months ago by No3x.
    • This reply was modified 8 years, 8 months ago by No3x.
    Thread Starter Ewout

    (@pomegranate)

    8 years, 8 months ago

    @no3x thank you for your response. I see your point about not removing the menu, I just wanted to give a suggestion because I saw so many topics and bad reviews about Redux. My initial question was NOT about removing the redux framework (I just added that as a bonus) but about the error it showed (see screenshot), as even they themselves suggest to change this (red message in the screenshot):

    Redux Framework Notice: There are references to the Redux Framework support site in your config’s admin_bar_links argument. This is sample data. Please change or remove this data before shipping your product.

    Apologies if the additional remarks confused the topic!

    No3x

    (@no3x)

    8 years, 8 months ago

    Oh, I did not read this notices in the screenshot. I assumed another rant about redux notices policy.

    So finally my answer to the actual topic: Actually I don’t remember to see this specific notice. I added (instead of replacing) my link to the one of redux in respect of their work. This was intentionally, but since they seem to don’t want this references from their side I can remove them safely.

    No3x

    (@no3x)

    8 years, 8 months ago

    Thanks for the suggestion. You can track the status of feature here https://github.com/No3x/wp-mail-logging/issues/66

    Dōvy Paukstys

    (@dovyp)

    8 years, 8 months ago

    Lead dev of Redux here. That’s simply to help developers put in their own Facebook/GitHub links that are in the footer. Just either remove them from the sample config, or add your own links. We can’t properly support users of code we didn’t write. 😉

    No3x

    (@no3x)

    8 years, 8 months ago

    Hi @dovyp,

    thanks for joining the discussion. Can you please write about your point of view regarding:
    1. Removing the redux-about submenu in plugin code is permitted.
    2. Removing redux ads (when WP_DEBUG is true) in plugin code is permitted.

    Can you elaborate on

    We can’t properly support users of code we didn’t write.

    I understand that redux is a framework and you can’t control how it’s used. Do you want to change issue management between plugin users and redux?

    Dōvy Paukstys

    (@dovyp)

    8 years, 8 months ago

    @no3x These are questions more for our issue tracker…

    1. Easy enough to remove. Makes it near impossible for users to send us a support URL if you’re not around. Up to you.
    2. Permitted if you support the project: https://reduxframework.com/extension/ad-remover/

    Meaning, please remove the footer links in your config (which point to us) so that users can go to you first for support. That’s what the warning is for. It is related to the mini icons at the bottom of each panel (Facebook, Twitter, GitHub) and we think those should be your URLs, not ours. So we put that warning in.

    When a user comes to us with an issue in your code, there’s really no way for us to know how to debug it except acquire your code which is outside of the scope of our project. Our hope is that you will provide that, instead of us. 😉

    No3x

    (@no3x)

    8 years, 8 months ago

    1. Easy enough to remove. Makes it near impossible for users to send us a support URL if you’re not around. Up to you.

    That’s a global decision. I can’t decide for plugin x that uses redux too.

    2. Permitted if you support the project

    People think I want them to buy redux even when your notices always say “Redux devs: ..”. My plugin is non-commercial.

    It is related to the mini icons at the bottom of each panel (Facebook, Twitter, GitHub) and we think those should be your URLs, not ours.

    These share_icons links were customized and do not contain links to redux. The admin_bar_links are in question! But..

    Meaning, please remove the footer links in your config

    It was decided to remove the admin_bar_links yesterday already.

    I have learned that redux only makes sense if you can buy the ads remover. Otherwise people get distracted by redux notices and pages. This leads to wrong assumptions about the plugin itself and bad reviews complaining about “ads”, “hide”, “bloat”.

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Redux framework notices’ is closed to new replies.