Remove Support for Headers and Background ..[Request]

I’d also like to ask for filters to be added to HEADER_TEXTCOLOR, HEADER_IMAGE and NO_HEADER_TEXT.

Hi esmi,
Looking at the soon to be default theme in the “3.1 beta 2” the standard code is different, giving a chance to define these in the child theme functions.php, this would be outside of any ‘after_theme_setup’ function, as they need to load before the parents function.php file.

When WordPress 3.1 is released we will have in the updated twenty ten theme functions.php

if ( ! defined( 'HEADER_TEXTCOLOR' ) )
	define( 'HEADER_TEXTCOLOR', '' );

if ( ! defined( 'HEADER_IMAGE' ) )
	define( 'HEADER_IMAGE', '%s/images/headers/path.jpg' );

if ( ! defined( 'NO_HEADER_TEXT' ) )
	define( 'NO_HEADER_TEXT', true );

Not sure, but we could add these in an ‘init’ function in the child theme.

add_action( 'init', 'init_child_theme_setup' );

function init_child_theme_setup() {
	define( 'HEADER_IMAGE', get_stylesheet_directory_uri() .'/images/header.jpg' );
}

But add_custom_image_header(); and add_custom_background(); are not conditional so we will not be able to unset these from the Appearance sub menu, unless they were wrapped in a function call.

Regards

David

Note / Warning:
Anyone that has edited the default twenty ten theme, looking at the next beta release the theme folder will be over-written and changes will be lost!

But they’re inside twentyten_setup() – which is conditional – so you can get around it by re-writing the setup function in the child.

Good one, never thought about re-writing the function twentyten_setup() in a child theme, and that would be no problem to me.

It might be a bit daunting for anyone learning theme development to have to copy across 130+ lines, just to edit a single line of the function to disable say custom backgrounds or headers!

I am working on a plugin for automatic creation of 2010 Child Themes, so this idea will be very useful for setting the options, and creating the childs functions.php file.

Many Thanks

David

The only problem with moving the whole function is that as the theme is updated, you lose the new functions.php code and any code changes.

In the upcoming release there is new code in the twentyten_setup() function inside the functions.php file, when the default theme is over-written this code will not be availiable to the child theme.

add_theme_support( 'post-formats', array( 'aside', 'gallery' ) );

This may or may not be relevent to a child theme.

David

Hi Ipstenu,
I know all about “Child Themes” and overwriting functions, conditional functions, remove action and remove filters, the problem is that the header and background support still cannot be removed in the child themes functions.php.

As discussed above we could add a function with the same name as the twentyten_setup() in the child theme, copy the whole function code over and remove lines.

This would then be loaded instead of the parents, but it would be better if we could just, remove_filter(), remove_action(), remove_theme_support() or had wrapper functions for the “Extra Theme Functions”:

Just by wrapping the extra theme function calls, in a parent function would be ok, but something more like this would be ideal:

remove_theme_support( 'Custom Backgrounds' );
remove_theme_support( 'Custom Headers' );
remove_theme_support( 'Editor Style' );
remove_theme_support( 'Automatic Feed Links' );

There might be another way, for the twenty ten authors to split down the calls in the twenty ten functions.php, so we have several ‘after_setup_theme’ functions for different areas.

add_action( 'after_setup_theme', 'twentyten_setup_general' );
add_action( 'after_setup_theme', 'twentyten_setup_headers' );
add_action( 'after_setup_theme', 'twentyten_setup_postimages' );
add_action( 'after_setup_theme', 'twentyten_setup_background' );

Just floating ideas, but we need a way in the child theme to loose the Appearance > Headers and Appearance > Background

Regards

David