Several minor requests

  • Resolved Guido

    (@guido07111975)


    5 years, 3 months ago

    Hi,

    Nice plugin!

    I notice the inline style of the the main map div contains a strange CSS value: display: vis;. Example:

    
<div id="map_ol3js_1" class="map undefined" data-map_name="undefined" data-map="map_ol3js_1" style="width:496px; height:297px; display:vis; overflow:hidden;border:2px solid grey;">

    But this value is not always present, this CSS seems to be generated?

    And this main div has a very common CSS class: map undefined. Are you willing to add a more specific CSS class as wel, such as osm-map? To avoid conflicts when using Custom CSS. Or can I somehow add a custom class while creating a map?

    And can you add a links to the settingspage at the main plugin page? By using filter plugin_action_links_.

    Thanks in advance!

    Guido

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author MiKa

    (@photoweblog)

    5 years, 2 months ago

    Hello @guido07111975

    thank you for your feedback! Of course we are willing to improve 😉 We are going to release on Monday a new version.

    Can you send the WP OSM Plugin shortcode which produced this CSS sample here:

    https://wp-osm-plugin.hyumika.com/contact/

    Br, Michael

    Thread Starter Guido

    (@guido07111975)

    5 years, 2 months ago

    Hi Michael,

    I will send you a message shortly.

    Meanwhile another minor request: can you add max-width:100%; to the .map class so it will scale properly in smaller screens?

    Guido

    Thread Starter Guido

    (@guido07111975)

    5 years, 2 months ago

    Hi again Michael / @photoweblog

    Don’t know whether you received my submission or not, but you can find a screenshot of the page and source code here (temp link).

    The added shortcode is:

    
[osm_map_v3 map_center="52.4866,13.2804" zoom="13.3" width="496"
height="297" file_list="my-domain/wp-content/uploads/gpx/zesmeren.gpx"
file_color_list="blue"]

    Guido

    Plugin Author MiKa

    (@photoweblog)

    5 years, 2 months ago

    Hi @guido07111975

    I got your e-mail.

    To fill your div with the map you can also define the width in the shortcode with percentage – like
    width="100%"

    Br, Michael

    Thread Starter Guido

    (@guido07111975)

    5 years, 2 months ago

    Hi,

    Does it support max-width as well? In smaller screen it can overflow the content section of a website.

    And display:vis comes from file “osm-sc-osm_map_v3”: 'map_div_vis' => 'vis'

    Guido

    Plugin Author MiKa

    (@photoweblog)

    5 years, 2 months ago

    Hello @guido07111975

    some parts of your feedbacks are considered within the latest version, thanks again! Some parts need more attention and will be discussed in upcoming version.

    Anyway – feedback like this is very welcome.

    Br, Michael

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Several minor requests’ is closed to new replies.