Title: Simplified Shortcode Functions
Last modified: July 30, 2017

---

# Simplified Shortcode Functions

 *  [WhoTnT](https://wordpress.org/support/users/wpwho/)
 * (@wpwho)
 * [8 years, 10 months ago](https://wordpress.org/support/topic/simplified-shortcode-functions/)
 * I just thought I would let you know that you can simplify your shortcode functions
   as follows:
    **ORIGINAL**
 *     ```
       function show_ad_camp_1() {
       	$ad_camp_encoded_value_1 = get_option( 'wp_ad_camp_1_code' );
       	$ad_camp_decoded_value_1 = html_entity_decode( $ad_camp_encoded_value_1, ENT_COMPAT );
   
       	if ( !empty( $ad_camp_decoded_value_1 ) ) {
       		$output = " $ad_camp_decoded_value_1";
       	}
       	return $output;
       }
       ```
   
 * **NEW**
 *     ```
       function show_ad_camp_1() {
       		return html_entity_decode(get_option( 'wp_ad_camp_1_code' ));	
       }
       ```
   
 * With your code there is the possibility of trying to return a non-existent $output
   variable if the if condition is false. As far as I can tell, there is no reason
   to check if the value you are returning is empty since if it is empty nothing
   will be displayed anyway.

Viewing 1 replies (of 1 total)

 *  Plugin Support [mbrsolution](https://wordpress.org/support/users/mbrsolution/)
 * (@mbrsolution)
 * [8 years, 5 months ago](https://wordpress.org/support/topic/simplified-shortcode-functions/#post-9769486)
 * Thank you for sharing your modified code.
 * The plugin developers will investigate further your suggestion.
 * Kind regards

Viewing 1 replies (of 1 total)

The topic ‘Simplified Shortcode Functions’ is closed to new replies.

 * ![](https://ps.w.org/wordpress-plugin-for-simple-google-adsense-insertion/assets/
   icon-128x128.png?rev=1135850)
 * [WP Simple Adsense Insertion](https://wordpress.org/plugins/wordpress-plugin-for-simple-google-adsense-insertion/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/wordpress-plugin-for-simple-google-adsense-insertion/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/wordpress-plugin-for-simple-google-adsense-insertion/)
 * [Active Topics](https://wordpress.org/support/plugin/wordpress-plugin-for-simple-google-adsense-insertion/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/wordpress-plugin-for-simple-google-adsense-insertion/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/wordpress-plugin-for-simple-google-adsense-insertion/reviews/)

 * 1 reply
 * 2 participants
 * Last reply from: [mbrsolution](https://wordpress.org/support/users/mbrsolution/)
 * Last activity: [8 years, 5 months ago](https://wordpress.org/support/topic/simplified-shortcode-functions/#post-9769486)
 * Status: not a support question