Title: Subscribe2 HTML issues -> hack
Last modified: August 22, 2016
---
# Subscribe2 HTML issues -> hack
* [Bradley Cummins](https://wordpress.org/support/users/bcummins/)
* (@bcummins)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/)
* Recently took over a number of blogs which have been running Subscribe2 HTML
for years. There was a pending update which I installed. Needless to say, everything
broke. I tried fixing by uninstalling and starting from scratch….no joy. I finally
dove into the code and found php which was coded wrong….and could not possibly
work. I went ahead and hacked/fixed what I needed, but I don’t understand how
we’re the only ones with this issue. I emailed the developer @ Semperplugins.
com and no response.
* Here is one example of what I’m referring to. Please correct me if I’m missing
something, but ‘1’ is a string. The operand === compares value and type. If you
compare the result of intval() and a string it’s always going to prove false.
* Hope to hear from someone on this.
bkc
* file: class-s2-frontend.php
line: 245
* $action = intval( substr( $code, 0, 1 ) );
if ( ‘1’ === $action ) { return __(‘
Subscription Confirmation’, ‘subscribe2’ ); } else { return __( ‘Unsubscription
Confirmation’, ‘subscribe2’ ); }
* [https://wordpress.org/plugins/subscribe2/](https://wordpress.org/plugins/subscribe2/)
Viewing 6 replies - 1 through 6 (of 6 total)
* [Matt Robinson](https://wordpress.org/support/users/mattyrob/)
* (@mattyrob)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366631)
* [@bradley](https://wordpress.org/support/users/bradley/),
* I’ve just checked my responses and I replied to the wrong email address – my
apologies, I’ve sent my response again. Indeed this issue and the other you reports
are glitches introduced in the HTML code only as I’m trying to implement stricter
comparisons there as a way to avoid code vulnerabilities, overall === and !==
are a little more secure and produce fewer unexpected results. Unfortunately
in moving to this I’m finding a few historic and poor coding practices.
* I’ll get these issues fixed in the next version.
* Thread Starter [Bradley Cummins](https://wordpress.org/support/users/bcummins/)
* (@bcummins)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366634)
* Thx for the quick response. We’re up and running on the Subscribe2 HTML v 10.5
after some hacks. Happy to share our updates, but I’m sure you probably have
them documented by now. bkc 😉
* [Matt Robinson](https://wordpress.org/support/users/mattyrob/)
* (@mattyrob)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366648)
* [@bradley](https://wordpress.org/support/users/bradley/),
* I’ve added a few more fixes in the frontend class but email me with anything
you’ve found – two sets of eyes are better than one! (Did you get my email?)
* [Bradley Allen](https://wordpress.org/support/users/bradley/)
* (@bradley)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366687)
* [@mattyrob](https://wordpress.org/support/users/mattyrob/)
* If you use the @ sign, then please reply to the person’s username, not their
first name.
* In this case, reply to [@bcummins](https://wordpress.org/support/users/bcummins/),
and not @ bradley (me).
* Thanks for your understanding. Keep up the great work!
* sincerely,
Bradley
* [Matt Robinson](https://wordpress.org/support/users/mattyrob/)
* (@mattyrob)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366754)
* [@bradley](https://wordpress.org/support/users/bradley/),
* Wow, I had no idea WP.org sent notifications – certainly I’ve never had any.
Anyway, my apologies for copying you into a thread that was irrelevant to you.
* [@bcummins](https://wordpress.org/support/users/bcummins/),
* I’ll still very much like to see a list of the hacks you’ve made so I can compare
and merge as appropriate before pushing a new version.
* [Bradley Allen](https://wordpress.org/support/users/bradley/)
* (@bradley)
* [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366800)
* [@mattyrob](https://wordpress.org/support/users/mattyrob/)
* I didn’t know much about the notification system either, however I just learned
more. Check it out 🙂
* > [WordPress.org Notifications](https://make.wordpress.org/core/2012/08/04/wordpress-org-notifications/)
Viewing 6 replies - 1 through 6 (of 6 total)
The topic ‘Subscribe2 HTML issues -> hack’ is closed to new replies.
* 
* [Subscribe2 - Form, Email Subscribers & Newsletters](https://wordpress.org/plugins/subscribe2/)
* [Frequently Asked Questions](https://wordpress.org/plugins/subscribe2/#faq)
* [Support Threads](https://wordpress.org/support/plugin/subscribe2/)
* [Active Topics](https://wordpress.org/support/plugin/subscribe2/active/)
* [Unresolved Topics](https://wordpress.org/support/plugin/subscribe2/unresolved/)
* [Reviews](https://wordpress.org/support/plugin/subscribe2/reviews/)
## Tags
* [subscribe2 html](https://wordpress.org/support/topic-tag/subscribe2-html/)
* 6 replies
* 3 participants
* Last reply from: [Bradley Allen](https://wordpress.org/support/users/bradley/)
* Last activity: [11 years, 7 months ago](https://wordpress.org/support/topic/subscribe2-html-issues-hack/#post-5366800)
* Status: not resolved