TSX support

  • Resolved perrygovier

    (@perrygovier)


    7 years ago

    Prismic 1.16.0 added support for a few different languages, including TSX. It looks like some files need to be added and the $classes arrays in resources-enqueue.php need to be added for it to work though. I’m not sure if there’s more beyond that needed. I’m trying to get it working w/ my local install.

    Currently, we just use JSX, since it’s “close enough”, but it’d be great if we could use TSX since Prism.js supports it now.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Jeff Starr

    (@specialk)

    7 years ago

    Prismatic includes only a subset of available languages (documented here). Currently TSX is not on the list, but I am happy to add it in the next plugin update. Thank you for the feedback.

    Thread Starter perrygovier

    (@perrygovier)

    7 years ago

    That’d be lovely if you could. Let me know if there’s a way I can help. I got most of the way, I think, but it looks like you’re modifying the language files a bit and I got hung up on that.

    Thread Starter perrygovier

    (@perrygovier)

    7 years ago

    Totally unrelated, I believe something’s up w/ the Paypal donation link on your site. I’m getting an error when I try to send some $ your way.

    Plugin Author Jeff Starr

    (@specialk)

    7 years ago

    Glad to help:

    1) “it looks like you’re modifying the language files a bit”

    No actually they are direct copies. What exactly are you seeing that makes you think otherwise?

    2) “I believe something’s up w/ the Paypal donation link on your site”

    Please let me know which site or where you are finding the link. Also would be useful to know exactly what is happening when you try sending, is it an error, etc.

    Thread Starter perrygovier

    (@perrygovier)

    7 years ago

    On the language files:
    I expected this to look like this if it was a direct copy. They’re similar, but the version in your plugin has some extra regex. Maybe it’s old or compiled somehow in a prism dist version I didn’t see?

    On the donation link:
    Under “SUPPORT DEVELOPMENT OF THIS PLUGIN” in the main description is a link to this page. The “Dontate” link takes me to Paypal, but I get a general error.

    Plugin Author Jeff Starr

    (@specialk)

    7 years ago

    1) Language files:

    What you are seeing at github is the code for a single language *without* dependencies. To see the dependencies you can grab the code from the Prism download page. For example select only Typescript and then scroll down to the output code; you will find exactly what is included in the Prismatic plugin. I.e., the plugin includes the dependencies for each language.

    2) Donation link:

    Thanks. I’ve tested from numerous locations and it seems to be working normally. I wish I had more control over PayPal side of things but alas I do not. Either way thanks for the infos.

    • This reply was modified 7 years ago by Jeff Starr. Reason: clarity
    Plugin Author Jeff Starr

    (@specialk)

    6 years, 9 months ago

    Just to follow up with this, TSX language is added for Prism.js as of Prismatic plugin version 2.2, now available. Thanks for again for the feedback, @perrygovier.

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘TSX support’ is closed to new replies.