I am creating a child theme, but it’s impossible.
Take a look at the css – it’s horrid.
Themes like this one shouldn’t be allowed in WordPress themes unless they learn to write code properly.
I can’t use a custom css plugin because this theme isn’t going to stay on this site. Trying to move custom CSS that was creating using those plugins is ridiculous.
If they can’t proved a properly coded CSS file, I may take the time to rate this theme.
Have you never seen a minified CSS file before? You might want to google up on it.
There is absolutely nothing wrong with the CSS files in this theme.
I know what it is, it creates junk css. It’s all on one line. It’s almost impossible to write a child theme with that mess.
WordPress needs to have some standards.
ww.wp.xz.cn does. Those guidelines are available at http://make.ww.wp.xz.cn/themes/guidelines/
And every theme submitted to (or updated on) ww.wp.xz.cn has to undergo an extensive, human, quality review against those guidelines. Unfortunately for you, there is nothing in the guidelines that forbids (or even recommends against) minified CSS. Probably because it is sometimes thought to be good practice to reduce file sizes. You should be able to “beautify” the CSS using a decent text editor and a macro or two – if that’s what you want. But please do not accuse the theme’s developers of bad practice when it is nothing of the sort.
BTW, If you take the time to go through the junk CSS you’d know there are errors in the CSS. I’ve found 3 thus far.
I thought you wrote “There is absolutely nothing wrong with the CSS files in this theme.” Did you not review the code before you made the statement?
The errors are in virtue.css & bootstrap.css
The errors are on line 1 and line 25 – as they are written.
Did you not review the code before you made the statement?
Yes – I did. Did you not notice:
*!
* Bootstrap v3.0.0
*
* Copyright 2013 Twitter, Inc
* Licensed under the Apache License v2.0
* http://www.apache.org/licenses/LICENSE-2.0
*
* Designed and built with all the love in the world by @mdo and @fat.
*//*! normalize.css v2.1.0 | MIT License | git.io/normalize */
in bootstrap.css? Have you not come across bootstrap before? Perhaps this will help: http://getbootstrap.com/
Additionally, validity as determined by dumb parsers is also not mandated by the theme review guidelines. I really do encourage you to try reading them. You might find them helpful.
Howdy!
Randomly I was pinged on this issue because of my username in the Bootstrap CSS banner. Perhaps I can shed some light on a few things for @keeperbay.
First, Bootstrap is an HTML/CSS/JS framework for building sites, even WordPress themes. Basically it provides folks with well styled and documented components so they can build things faster. It’s mobile first and responsive, meaning it works great on your phone and all the way up to your laptop/desktop.
Second, the minified CSS is a super great way to serve up your CSS in a production environment. The purpose of minified CSS is to reduce file size and concatenate (combine) multiple files into one. For themes, and folks who are looking to build on existing CSS like those in WordPress, it’s obviously a bit tougher to work with.
You have a couple options though for dealing with that. You could appeal to the theme designer to provide the unminified CSS. You could also copy-paste the minified CSS into a CSS linter, which could reformat all the code for readability.
Lastly, not all CSS is expected to validate (at least to the W3C’s validation specs). In Bootstrap in particular, we have to support lots of odd browser behavior. Sometimes that requires browser hacks and weird syntax that chokes the validators and parsers. There’s little we can do about that, but the CSS does work.
Hope that helps! If you do find an issue in Bootstrap, give our bug tracker on GitHub a search. If you don’t see an open issue, feel free to open one of your own at https://github.com/twbs/bootstrap/issues/.
<3
Yes, I’ve heard of bootstrap. If you look you’ll see that I posted the bootstrap.css as the css with the issue. (one of the css)
Regardless if it’s bootstrap or not – errors are errors. There are errors in the css and the junked up css didn’t help me find them.
Trying to create a Child theme with errors in the original CSS is nearly impossible.
There is nothing in the WP guidelines that allows errors in the CSS as long as it’s hidden in bad coding practices.
Bootstrap is great, but far from foolproof. If you can’t code stay out of the coding business.
Now if the creator of the theme would like to provide me with the properly coded CSS using best practices, that would be great. If not, I’m not sure why anyone is still responding.
I asked for a properly coded version of the CSS using best practices. Not an opinion.
What part of creating a child theme are you having trouble with in particular? Perhaps a link to your site would help, as well.
Hey @keeperbay
This sounds like a pretty heated topic thread. Hopefully I can help and give you want you want. Lets start with the Errors. I am always looking to improve this theme if you can let me know the errors I would be happy to fix in the next version.
As for the minified css (junked up as you put it) that was used on purpose to help the speed of the theme and therefor the speed of websites using it, its considered “best practice” to use minified css in all websites.
What esmi stated at the beginning is also “best practice”. Using a child theme, with it you can override css in the theme with css you create in the child theme. Not to copy the parent theme css into the child theme and not to edit the parent theme css. It would make it impossible to update the theme without have to re-edit each time.
If you are certain you want to edit the theme css and you want it un-minifed you can simply paste the css here : http://cssunpacker.com/ and it will output the css in a more readable format.
I sincerely hope that helps,
Kadence Themes
