Title: WP 4.5 Javascript errors / popups no longer working.
Last modified: August 31, 2016

---

# WP 4.5 Javascript errors / popups no longer working.

 *  ResolvedPlugin Author [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * (@danieliser)
 * [10 years, 1 month ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/)
 * WordPress 4.5 saw the bundled jQuery version being updated from 1.11.3 to 1.12.2.
   Some themes are not compatible with this change and cause errors, which affect
   all scripts loaded on your pages. This includes popups.
 * Read [https://wordpress.org/support/topic/read-this-first-wordpress-45-master-list?replies=7](https://wordpress.org/support/topic/read-this-first-wordpress-45-master-list?replies=7)
 * To view jQuery/Javascript errors, open up your error console (in chrome, view
   > developer > javascript console) and see what is shown.
 * If there are errors shown, check for updates from your theme author or contact
   the theme author for support if none exist and that is where the error is coming
   from.
 * This is not a Popup Maker issue just to clarify; Popup Maker is compatible with
   jQuery 1.12.2.
 * See this thread for possible solutions provided by our users: [https://wordpress.org/support/topic/stopped-working-suddenly-wp-45?replies=27](https://wordpress.org/support/topic/stopped-working-suddenly-wp-45?replies=27)

Viewing 13 replies - 1 through 13 (of 13 total)

 *  [Hristo Pandjarov](https://wordpress.org/support/users/hristo-sg/)
 * (@hristo-sg)
 * SiteGround Representative
 * [10 years ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-7332062)
 * Doesn’t this mean that the plugin is not enqueued properly? Is there a proper
   way to move the script inclusion before the mentioned flawed themes?
 *  Plugin Author [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * (@danieliser)
 * [10 years ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-7332064)
 * [@hristo](https://wordpress.org/support/users/hristo/) Pandjarov – Popup Maker
   definitely leverages as many WP apis as possible, we 100% do it correctly :).
   See [here](https://github.com/PopupMaker/Popup-Maker/blob/master/includes/scripts.php#L39).
 * The problem isn’t with load orders or anything like that. It is simply that their
   code has a Fatal JS error in it.
 * In jQuery v1.11 this was ok and would result in the correct selection:
 *     ```
       jQuery('a[href=#]');
       ```
   
 * But in jQuery v1.12 which was included with WP 4.5 declared that an invalid selector.
   The truth is it always was based on CSS standards, but before v1.12 it didn’t
   throw an error and still returned a valid result.
 * Now it needs to look like this:
 *     ```
       jQuery('a[href="#"]');
       ```
   
 * Problem is they didn’t document this breaking change in the jQuery changelogs,
   so WP core team wasn’t able to notify any of the offending themes until they 
   broke.
 * The fix is simple though but none the less, once the error is triggered no further
   JS is run, so our scripts either don’t run at all or initialize but before the
   popup triggers the error occurs.
 * So moving our scripts before / after won’t have an effect. If we load it before,
   then the error occurs, your popups likely won’t trigger on click or even delay
   since JS stops processing.
 * Some errors do not trigger the fatal stop, but this one in particular is an invalid
   selector which does.
 * There are several discussions on the jQuery github about it, including one where
   I convinced them to not only communicate with the WP Core team in the future 
   as breakages can be widespread, but also to get this patched via jQuery Migrate
   for backward compatibility which should be included in the next WP core update
   as well.
 * Hope that helps.
 *  [ashokvas](https://wordpress.org/support/users/ashokvas/)
 * (@ashokvas)
 * [9 years, 1 month ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9045484)
 * I set up the pop up on my test landing page ( which I have made with elementor–
   but it does not seem to open
    [http://diabetesvault.com/learn-control-diabetes-30-days/](http://diabetesvault.com/learn-control-diabetes-30-days/)
 * I have not put any shortcode in the pop up content since i am only testing
 * The pop up is opening when I am logged into my WP account and when I view the
   selected page, on the top bar there is a link to Pop up maker> Popup> open
 * Then the popup is opening
 * When I try to click on the button I have created ( using a css selector for the
   button to trigger the pop up )
 * I have also taken a screenshotof the js error that is showing
 * [https://www.screencast.com/t/LdbtT64SB7](https://www.screencast.com/t/LdbtT64SB7)
 * I also disabled all my installed plugins and even then it did not work.
 * So there is no clash with any plugin
 * Can you please tell what to do
 * Thanks
 *  [ashokvas](https://wordpress.org/support/users/ashokvas/)
 * (@ashokvas)
 * [9 years, 1 month ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9056170)
 * Hi [@danieliser](https://wordpress.org/support/users/danieliser/)
 * Would request some suggestions from you on my problem
 * Thanks
 *  [prativa42](https://wordpress.org/support/users/prativa42/)
 * (@prativa42)
 * [9 years ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9211501)
 * Hey There
    I am facing same issue. My site popup stopped working suddenly. IO
   am a non coder, so wonder what to do. My site (talenteye dot in) . Big shout 
   for help. Pl help
 *  [Biggytv](https://wordpress.org/support/users/biggytv/)
 * (@biggytv)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9317149)
 * I am having the same issue. Contacted Popup Maker through support ticket and 
   they said it wasn’t their problem which, from these posts, it is. If anyone has
   solved this issue, please let me know too.
 *  Plugin Author [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * (@danieliser)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9322519)
 * [@biggytv](https://wordpress.org/support/users/biggytv/) – See [https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-7332064](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-7332064)
 * The issue described throughout this topic was never in our plugin. It has to 
   be fixed in your theme or wherever it is occuring and in fact breaks our plugin.
 * The reply above tells what to look for and how to fix it but it specifically 
   describes modifying your theme not our plugin.
 * Also of not most of all of these users in this single thread have solved thier
   issue with the proposed solution.
 * If you read it fully you will see that jQuery team actually caused it by not 
   properly documenting a change that WP core team then included into core, which
   lead to many themes that were doing it wrong before without error now showing
   errors. Something I was personally responsible for digging up and reporting to
   the jQuery team which they subsequently patched it. I did this purely because
   of the constant wave of users blaming us for JS errors in their themes. Also 
   spent days assisting users and theme authors in patching it.
 * And to your last point, if you emailed our support with any error related to 
   a[href=#] then we would have pointed you to this ticket which outlines the solution
   multiple times on nearly every page.
 * Hope that helps, but likely if your using a popular theme or updating regularly
   this isn’t the same issue your having as WP is now at v4.8 which is nearly 1.5
   years later and the issue has long been resolved for most products.
 *  [Biggytv](https://wordpress.org/support/users/biggytv/)
 * (@biggytv)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9324175)
 * Hi Daniel-
 * I am still having the issue with Gravity Forms and Popup Maker. Popup Maker no
   longer closes upon Successful completion of the Gravity Form. The beta fix v2
   that you sent me did not work.
 * Please help, I am getting killed by my boss. The plugin worked find for months,
   even after implement the new version with Gravity Form support, then it broke.
 * Thanks man!
 *  Plugin Author [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * (@danieliser)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9326476)
 * [@biggytv](https://wordpress.org/support/users/biggytv/) – See my reply, your
   site is still loading the older version. I can tell because the version number
   is added to the script url. Also that is completely unrelated to this 1.5 year
   old issue which you keep bumping.
 *  [Biggytv](https://wordpress.org/support/users/biggytv/)
 * (@biggytv)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9326638)
 * Hi-
 * I downloaded the new version you provide at WordPress.org 1.6.5. It is loading,
   so there is no cache issue.
 * My issue relates to Gravity Forms, which you mentioned July 16, was an issue 
   with Popup Maker, although it did work before.
 * I have reinstalled everything, even on another developer machine. Only issue 
   I find is that Popup is no longer setting up a Cookie event when selecting “On
   Gravity Forms Success”
 * Your product is awesome and worked for me with Gravity Forms when you released
   1.6.0, but am at a deadend.
    -  This reply was modified 8 years, 11 months ago by [Biggytv](https://wordpress.org/support/users/biggytv/).
 *  [Biggytv](https://wordpress.org/support/users/biggytv/)
 * (@biggytv)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9327771)
 * Hi-
 * Also, I did a completely new install on my local machine and a different server
   with just WordPress, Gravity Forms and Popup Maker with the same results. When
   I complete the form, the popup does not close.
 * Any help is appreciated.
 *  [Biggytv](https://wordpress.org/support/users/biggytv/)
 * (@biggytv)
 * [8 years, 11 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9329692)
 * Thank you for fixing this. Clearly NOT a issue with Popup Maker. The change that
   Gravity Forms made of adding a single letter within their confirmation code without
   notifying their (you) development partners was a nightmare.
 * I can’t thank you enough for sticking with me to debug this issue.
 * Your product is fantastic and the only Popup on the market that does exactly 
   what I need.
    -  This reply was modified 8 years, 11 months ago by [Biggytv](https://wordpress.org/support/users/biggytv/).
 *  Plugin Author [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * (@danieliser)
 * [8 years, 10 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9329884)
 * [@biggytv](https://wordpress.org/support/users/biggytv/) – Awesome! Happy I could
   help you out. Btw, If you have a moment, I would very much appreciate if you 
   could quickly click that it [Works](https://wordpress.org/plugins/popup-maker/#compatibility)
   for you and [rate the plugin](https://wordpress.org/support/plugin/popup-maker/reviews/?rate=5#rate-response),
   just to help us spread the word.

Viewing 13 replies - 1 through 13 (of 13 total)

The topic ‘WP 4.5 Javascript errors / popups no longer working.’ is closed to new
replies.

 * ![](https://ps.w.org/popup-maker/assets/icon-256x256.gif?rev=3097653)
 * [Popup Maker - Boost Sales, Conversions, Optins, Subscribers with the Ultimate WP Popup Builder](https://wordpress.org/plugins/popup-maker/)
 * [Frequently Asked Questions](https://wordpress.org/plugins/popup-maker/#faq)
 * [Support Threads](https://wordpress.org/support/plugin/popup-maker/)
 * [Active Topics](https://wordpress.org/support/plugin/popup-maker/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/popup-maker/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/popup-maker/reviews/)

## Tags

 * [jquery](https://wordpress.org/support/topic-tag/jquery/)

 * 13 replies
 * 5 participants
 * Last reply from: [Daniel Iser](https://wordpress.org/support/users/danieliser/)
 * Last activity: [8 years, 10 months ago](https://wordpress.org/support/topic/wp-45-javascript-errors-popups-no-longer-working/#post-9329884)
 * Status: resolved