wp_insert_user on init duplicate created user

Hello @bcworkz! I have think the same, but i have come out crazy after hours on understand how it can happen.

As said, if i stop the execution before:

exit;
$user_id = wp_insert_user( $userdata );

nothing happen at this point, no user inserted.
If i do this:
$user_id = wp_insert_user( $userdata );exit;
double user happen.
https://plugins.trac.ww.wp.xz.cn/export/HEAD/wp-w3all-phpbb-integration/trunk/class.wp.w3all-phpbb.php
line 1660:
$user_id = wp_insert_user( $userdata );
The verify_credentials function of course execute in sequence two times, because when user come with right credentials, then it is added, and a redirect happen.
After insertion, the redirect happen with an exit. But the user seem to be added at one time, twice, at same moment. May there is on queue in the stack, and already a call to this? I’ve so try out to comment out the wp_insert_user to look if it happen somewhere and not in this exact time/line of code.
Nothing to do, there is no insertion if the line removed. No other in the stack seem to interfere.

I will try to look around again, i’m sure it is something like you describe. But how it happen, it is a mistery at moment, which i resolved with a trick that i would like, of course, to resolve in different common way.
I’m on tewntytwenty at moment.
I will return over asap.

after_setup_theme
seem to work fine in front end.
The problem seem to disappear and all work smooth … testing more and move to this then. Or have a better or further suggestion?

I will try to understand why it was happening if possible

Hello!

So to anyone may fall on this, i would like to just leave a note, since i think i resolved, also thank to your hint.

The problem, isn’t when you just insert an user on init with priority 1,2 or 3 or 10, but,
the problem come out instead, if you immediately after do the follow:

 	wp_set_current_user( $user->ID, $user->user_login );
        wp_set_auth_cookie( $user->ID, $remember, is_ssl() );
        do_action( 'wp_login', $user->user_login, $user );

This seem to cause the double insertion of the user, i assume because into file
/wp-includes/user.php
where
$user = new WP_User( $user_id );
at this time the new WP_User still will not be may available for some other process, that execute the login (may i’m wrong on this but i will follow on reverse if i can asap) and on redirect, the mess come up.

So i resolved doing this, into the init (ordered to be executed as first of all) that execute before (the define is not a required thing, only needed for my needs in this case):
if(!defined(“WPUSERJUSTINSDATA”)){
$udata = serialize($user);
define(“WPUSERJUSTINSDATA”,$udata);
return;
}

Then into another place, ordered to be executed after, init 10:
add_action( 'init', array( 'WP_w3all_phpbb','w3_wplogin_after_ins'), 10, 0 );
then the function can be like this (note that the define is always just for this case and totally custom way), as example that need to be little improved, do this:

public static function w3_wplogin_after_ins(){
	 if(defined("WPUSERJUSTINSDATA")){
     	$user = unserialize(WPUSERJUSTINSDATA);
     	$remember = 1;
     	wp_set_current_user( $user->ID, $user->user_login );
        wp_set_auth_cookie( $user->ID, $remember, is_ssl() );
        do_action( 'wp_login', $user->user_login, $user );
     	wp_redirect(home_url()); exit();
     }
}

That resolve the issue.
Thank you again, your thought helped me a lot.
If any news, and still problems, i will return over again to just let you know.