Wrong add_action, needs fix

  • Resolved Arnan

    (@adegans)


    6 years, 10 months ago

    Everytime someone abandons the cart I get this in my error_log:
    [02-Aug-2019 22:53:03 UTC] PHP Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'on_action_cart_updated' not found or invalid function name in /my/path/to/wordpress/wp-includes/class-wp-hook.php on line 286

    Which leads back to the file woo-cart-abandonment/modules/cart-abandonment/class-cartflows-ca-cart-abandonment.php line 47:

    add_action( 'woocommerce_update_cart_action_cart_updated', 'on_action_cart_updated', 20, 1 );

    Aparently the on_action_cart_updated doesn’t exist. So this line serves no purpose and should be removed.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Support CartFlows Team

    (@cartflows)

    6 years, 10 months ago

    @adegans Thank you for reaching out.

    That’s a great catch. I have informed this problem to our dev team.

    They have removed the unnecessary code and will release this fix in the next update.

    Meanwhile, you can download the latest updates with above problem fix from here.

    Once again thank you, we really appreciate your suggestions.

    If you have any questions in the future, please feel free to contact us at support.

    sanchitgoyal

    (@sanchitgoyal)

    6 years, 10 months ago

    What does this error break and where I can check this log? On My website it seems to work fine!

    Thread Starter Arnan

    (@adegans)

    6 years, 10 months ago

    @cartflows Not that great or difficult of a find… as It’s plainly visible in the error_log.

    @sanchitgoyal In the error_log file of your server.
    It doesn’t actually break things as it’s just a warning for most cases. But it’s a bug and useless piece of code none-the-less.
    If your site works fine, don’t worry about it and just let it be fixed 🙂

    Thread Starter Arnan

    (@adegans)

    6 years, 10 months ago

    @cartflows Another thing – While you’re at it, can you change the dates in the dashboard to match the WordPress format?
    I find your hardcoded format really hard to read 🙁

    Visible in WooCommerce > Cart Abandonment > Report, column on the right.
    If you can make it follow the setting of Settings > General, Date Format.
    Much more readable and uniform.

    Plugin Support CartFlows Team

    (@cartflows)

    6 years, 10 months ago

    @adegans I completely agree with your suggestion.

    I have added this improvement in our queue and will release this in the next update surely.

    @sanchitgoyal As @adegans said, It doesn’t break anything on your site and we have already fixed this problem and will release this in next update.

    Plugin Support CartFlows Team

    (@cartflows)

    6 years, 10 months ago

    @adegans We have released the update officially.

    Did you see, the issue is resolved now?

    If still, you are facing the issue, please let us know by creating the support ticket so that we can fix it ASAP.

    Looking forward to hearing from you.

    Thank you.

    Thread Starter Arnan

    (@adegans)

    6 years, 10 months ago

    Yea I think it’s resolved, I didn’t notice the error anymore since update 1.1.7.
    Didn’t see the dates change though 🙂

    Plugin Support CartFlows Team

    (@cartflows)

    6 years, 9 months ago

    @adegans Thanks for the confirmation.

    I can see the changes for dates on the Report dashboard ( https://cl.ly/9ee6cd7f5d33 ).

    Can you please confirm this?

    Thread Starter Arnan

    (@adegans)

    6 years, 9 months ago

    Looking again the dates indeed are now better.

    • This reply was modified 6 years, 9 months ago by Arnan.
Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘Wrong add_action, needs fix’ is closed to new replies.