ab-tools

Hello,

I see that this issue got marked as “Resolved” here which is great to see!

Could you please confirm in which version of PPOM this bug is fixed?

Best regards
Andreas

Hello Poonam,

first thanks for your quick reply which is appreciated!

I saw that after your post there were a few minor updates to the PPOM plug-in and the changelog description sounded like it might contain a fix for this, but I just tested with version 33.0.10 and it is still broken.

Can you confirm if you would expect this to be fixed with the latest 33.0.10 version or your development team is still working on a fix for that?

Best regards and again thanks for your support
Andreas

Hello Christian,

first thanks for your quick reply, appreciated!

I’ve tried just copying the HTML code directly, but despite I use the HTML editor (not the visual one), WordPress always adds a “<pre>” around the code I enter which just displays the code again instead of executing it.

When I use the “[language-switcher]” tag, it does execute the code at this location, just shows the code to the user additionally.

When I copy in the HTML code directly, it does not even execute it, just shows it to the user…

Is there any way to work around this issue?

Best regards and thanks again for your support
Andreas

… for whatever reasons it does not upload the screenshots, but it simple shows this JavaScript as visible(!) browser output right next to the flags:

    // need to have the same with set from JS on both divs. Otherwise it can push stuff around in HTML
    var trp_ls_shortcodes = document.querySelectorAll('.trp_language_switcher_shortcode .trp-language-switcher');
    if ( trp_ls_shortcodes.length > 0) {
        // get the last language switcher added
        var trp_el = trp_ls_shortcodes[trp_ls_shortcodes.length - 1];

        var trp_shortcode_language_item = trp_el.querySelector( '.trp-ls-shortcode-language' )
        // set width
        var trp_ls_shortcode_width                                               = trp_shortcode_language_item.offsetWidth + 16;
        trp_shortcode_language_item.style.width                                  = trp_ls_shortcode_width + 'px';
        trp_el.querySelector( '.trp-ls-shortcode-current-language' ).style.width = trp_ls_shortcode_width + 'px';

        // We're putting this on display: none after we have its width.
        trp_shortcode_language_item.style.display = 'none';
    }

The flags are working, but why this JavaScript code is shown to the user?

Best regards
Andreas

Hello Dominik,

first thanks for your quick reply!

If I would apply this filter as you wrote, wouldn’t this affect all WordPress plug-ins?

If that’s the case, this obviously would not be a very good idea, because maybe some plug-ins really need this for security reasons.

But I absolutely don’t see why this public preview link needs to expire as I
1. explicitly enable the link (and I can disable it again at any time) and
2. this is not a public link, but I only send it to few people directly (that should review my post) and I want it to be active till I disable it again or I just publish my post.

Therefore there is no need for automatic expiration – at least there should be an option to disable it.

Best regards and thanks again
Andreas