bosseal
Forum Replies Created
-
Forum: Plugins
In reply to: [Stop Spammers Classic] Horrible PluginThe plug-in is extremely useful and efficient. I agree with all comments here. Keith, I think most of people like the plugin, plus it is confirmed with the good marks you received.
ian3145 is really not fair and immature. If he is not happy, then he should either write his own plugin, use other plugins or deal with spam manually.
Best regards
Alexandre 8)
Great, perfect, thanks a lot !
Hi, thanks for this, indeed it’s working correctly like this !
Perfect !
Will you add this fix in your next release or is it something I’ll have to patch every time there is a new release ?
Thanks a lot,
Alexandre 8)
OK thanks for your help, we’ll find a solution to avoid forking 🙂
But I’m a bit confused now as everything is mixed… so could I kindly ask you to post the content of your files:
- /admin/your_subscriptions.php for the line starting with $user_ID = $wpdb->get_var($wpdb->prepare(“SELECT ID FROM[…]
- /classes/class-s2-list-table.php for the line starting with
$actions = array(‘edit’ => sprintf(‘%s‘, ‘s2’,[…]
And I’ll then give a new test
Thanks a lot and sorry for the inconvenience,
Alexandre 8)
OK thanks for your testing. I tried again (with IE, FF, GC) with the urlencode / urldecode methods but it didn’t work with my configuration (WP3.8.1, Subscribe2 9.2 and PHP 5.3.21).
So for now I have to fork with this rawurlencode / rawurlcdoe – won’t make my maintenance easy 🙁
Alexandre
Thanks for the quick fix, unfortunately it didn’t work. But I applied a similar fix that worked for me (but can’t guarantee it meets all expected requirements):
In the /admin/your_subscriptions.php – Replace
$user_ID = $wpdb->get_var($wpdb->prepare("SELECT ID FROM $wpdb->users WHERE user_email = %s", urldecode($_GET['email'])));
with
$user_ID = $wpdb->get_var($wpdb->prepare("SELECT ID FROM $wpdb->users WHERE user_email = %s", rawurldecode($_GET['email'])));And in the /classes/class-s2-list-table.php – Replace
$actions = array('edit' => sprintf('<a href="?page=%s&email=%s">%s</a>', 's2', $item['email'], __('Edit', 'subscribe2')));
with
$actions = array('edit' => sprintf('<a href="?page=%s&email=%s">%s</a>', 's2', rawurlencode($item['email']), __('Edit', 'subscribe2')));Gonna complete my testing now…
Best regards,
Alexandre 8)
sorry for the typo in my initial message:
“[…]put in the good IP cache. And then, unfortunately, they CAN spam as much as they want[…]”Forum: Plugins
In reply to: [Stop Spammers Classic] Red Herring forms for comments KO – signup / login OKWell, after further investigation, it looks that an instruction was missing in the code:
<?php do_action( 'comment_form_before' ); ?>So make sure you have the above instruction after
<div id="respond">And then the red herring form will display in the comments page.
Alexandre 8)
Forum: Plugins
In reply to: [Stop Spammers Classic] Improvement – Reformatting codeYes it makes sense, especially if you’re the only developer and code on the run on your free time.
Plus you’re right, the code is clean, organized and commented.
Once again it was not a criticism nor anything, I know that every coder has his own rules and approach, it was just a thought after browsing the code and an idea in case the project was developed with several hands.
So forget about it, and my apologies if my message seemed a bit rough.
Best regards,
Alexandre 8)
Just tried now with Beta Version (5.0): working fine, can set the value to 0 for these 2 parameters.
Thanks a lot,
Alexandre
Thanks Keith,
Will definitely give it a try.
Best regards,
Alexandre 8)
Forum: Plugins
In reply to: [Stop Spammers Classic] Spammer let through – is on Stop Forum SpamWell, after further testing it appears that:
* if the IP address is not marked as spam and the e-mail address is marked as spam in SFS => registration is blocked
* if the IP address is marked as spam and the e-mail address is not marked as spam in SFS => registration is blockedSo it’s all good for me 🙂
Alexandre 8)
Forum: Plugins
In reply to: [Stop Spammers Classic] Spammer let through – is on Stop Forum SpamHello,
I had the same question here… Indeed, it is possible to check SFS against IP address + e-mail address.
For instance, the plug-in could check over such IP and e-mail address on http://www.stopforumspam.com/api?ip=192.99.7.102&[email protected] – if you check the XML result, you’ll find that you have 2 tags “appears”, “lastseen” and “frequency”.
So which tags are used ? The tags appears / lastseen / frequency of the IP address ? or the ones related to the e-mail address ? or both ?
In other words, what happened if the IP address is NOT marked as spammer but the e-mail address is marked as spammer ? Does it allow the registration or not ?
Anyway, thanks for the plug-in, it’s excellent work.
Best regards,
Alexandre 8)