Forum Replies Created

Viewing 15 replies - 16 through 30 (of 54 total)
  • Same error triggered from broken-link-checker. Passed null to esc_attr_e

    Which does not have strict type checking.

    broken-link-checker/app/admin-modals/local/class-view.php(60): esc_attr_e()

    Passed variable is self::$unique_id might by null. I think that should be an empty string, but who should I blame on this?

    • This reply was modified 2 years, 9 months ago by brbrbr.
    • This reply was modified 2 years, 9 months ago by brbrbr.
    brbrbr

    (@brbrbr)

    The constructor of wfScanPath does not validate the realpath output. This is set to false for the none-existing wp-content/blogs.dir/1/files. Resulting in the mix-up of folders.

    To work around, I created wp-content/blogs.dir/1/files manually and then the scan runs fine.

    • This reply was modified 4 years ago by brbrbr.
    • This reply was modified 4 years ago by brbrbr.
    Thread Starter brbrbr

    (@brbrbr)

    Appears to be fixed in today’s release

    thanks

    A bit more:

    I think ‘c4wp_same_settings_for_all_sites’ should be true for multisite and/or it should be possible to enable the plugin for individual sites instead of network only.

    • This reply was modified 4 years, 4 months ago by brbrbr.

    Hi,

    Got the same problem and lot of spam registrations. Had to reenter the setting, still didn’t work for multisite

    all thought I’m not the OP in response to your question 3)
    the plugin is network only for multisite environments

    I digged a bit into the code.

    One issue is that the option to enable the captcha for multisite signup is not working

    ms_user_signup is used in “anr-captcha-class.php” but is missing from “enabled_forms” in admin/settings.php.

    in the same admin/settings.php “network_admin_menu” should be used for multisite instead of “admin_menu”

    If “c4wp_same_settings_for_all_sites” is used in a multisite environment ANY user with a website can change the keys for ALL sites. I think only the super-admin should be allowed to do that. (this issue is resolved by using network_admin_menu)

    For now I patched the files as follows:

    #To move the menu to network only (will need a is_multisite) :
    admin/settings.php:20:
    add_action( 'network_admin_menu', [ $this, 'network_menu_page' ] );

    #to enable captcha on registration/signup on multisite ignoring the ms_user_signup
    anr-captcha-class.php:25:
    if ( c4wp_is_form_enabled( 'registration' ) && !is_multisite() ) {
    anr-captcha-class.php:30:
    if ( c4wp_is_form_enabled( 'registration' ) && is_multisite() ) {

    keep up the good work

    • This reply was modified 4 years, 4 months ago by brbrbr.
    • This reply was modified 4 years, 4 months ago by brbrbr.
    • This reply was modified 4 years, 4 months ago by brbrbr.
    • This reply was modified 4 years, 4 months ago by brbrbr.
    • This reply was modified 4 years, 4 months ago by brbrbr.
    Thread Starter brbrbr

    (@brbrbr)

    Hi,
    thanks,

    I overlooked the namespace. I applied your patch manually. However I had to change it.
    (I’m not very familiar with namespaces)

    if ( ! function_exists( 'Easy_Plugins\Table_Of_Contents\String\mb_substr_replace' ) ) :

    I created a file mu-plugins/mb_substr_replace.php and now it works excellent.

    <?php
    
    namespace Easy_Plugins\Table_Of_Contents\String;
    
    function mb_substr_replace( $string, $replacement, $start, $length = null )
    {
        if (is_array($string) ) {
                $num = count($string);
                $replacement = is_array($replacement) ? array_slice($replacement, 0, $num) : array_pad(array( $replacement ), $num, $replacement);
    
                // $start
            if (is_array($start) ) {
                    $start = array_slice($start, 0, $num);
                foreach ( $start as $key => $value ) {
                    $start[ $key ] = is_int($value) ? $value : 0;
                }
            } else {
                    $start = array_pad(array( $start ), $num, $start);
            }
    
                // $length
            if (! isset($length) ) {
                    $length = array_fill(0, $num, 0);
            } elseif (is_array($length) ) {
                    $length = array_slice($length, 0, $num);
                foreach ( $length as $key => $value ) {
                        $length[ $key ] = isset($value) ? ( is_int($value) ? $value : $num ) : 0;
                }
            } else {
                    $length = array_pad(array( $length ), $num, $length);
            }
    
                // Recursive call
                return array_map(__FUNCTION__, $string, $replacement, $start, $length);
        }
            $string_length =  mb_strlen($string);
        if ($start < 0) { $start = max(0, $string_length + $start);
        }
        else if ($start > $string_length) {$start = $string_length;
        }
        if ($length < 0) { $length = max(0, $string_length - $start + $length);
        }
        else if ((is_null($length) === true) || ($length > $string_length)) { $length = $string_length;
        }
        if (($start + $length) > $string_length) {$length = $string_length - $start;
        }
            $string= mb_substr($string, 0, $start) . $replacement . mb_substr($string, $start + $length, $string_length - $start - $length);
            return $string;
    }

    I second that (total cache)

    I disabled the save function for the time being

    
    #assets/ilenframework/core.php
    function save_options(){
    
                    $this->save_status = false;
                    return;
    

    I think you can also the fix the problem by adding a check on the menu creation.
    None-administrators won’t see the menu any more and can’t save either

    
    #assets/ilenframework/core.php
    function menu_free() {
    
                    if ( !current_user_can('administrator') ) {
                            return ;
                    }
    
    brbrbr

    (@brbrbr)

    Is the style code between /* */ indeed obsolete or is this a trick too fool some browsers.

    aka what’s the best solution removing the style completely or just removing the comment pair

    Thread Starter brbrbr

    (@brbrbr)

    Kale recommends the plugin not elementor, I already corrected that mistake and I changed the rating this morning.

    i doubt that your plugin will work correctly if used with different settings on different locations, but I will not spend any more time on it

    And this is getting way to personal

    I wish you all the best with your plugin, hopefully a lot of people will find it usefull.

    Thread Starter brbrbr

    (@brbrbr)

    It’s not elementor but the theme Kale recommends it

    And agreed, your plugin does not deserve a two star rating. But still, it didn’t meet my expectations so for me it won’t be a high rating.

    having more then one instance of your plugin on a site is still an issue if the settings are not identical.

    This is not an attack on your skills or the effort you put into this plugin. It just didn’t work for me.

    regards

    • This reply was modified 8 years, 2 months ago by brbrbr.
    Thread Starter brbrbr

    (@brbrbr)

    Hi Martin,

    Your plugin provides an ID, elementor provides ID’s. I was aware of those and no problem to work around the problem.

    still your plugin comes as recommended-by-elementor. Therefor I expect that your plugin allows (different) multiple instances out of the box, without work-arounds. Your plugin didn’t meet that expectation and that the reason for the poor rating. Maybe 2 is too low, but still.

    Thread Starter brbrbr

    (@brbrbr)

    correct

    Thread Starter brbrbr

    (@brbrbr)

    Yes,

    in that case the plugin would generate and show me a suggested CSS that I can use as custom CSS.

    Or the plugin generates and uses a unique ID for each instance of adresses the CSS accordingly.

    And to put another two cents in :the plugin should use inline css instead of the public.css. The small amount of code isn’t worth the round-trip.

    Thread Starter brbrbr

    (@brbrbr)

    I used your plugin with elementor. with two instances of your plugin. With different settings.

    This resulted in conflicts in the public.css

    After I created to identical instances on the same page problems with the public.css remained. The file was frequently missing and had the default 75px line as last.

    Tee last might be a caching or configuration problem on my site. But the first appeared unsolvable.

    Anyhow I couldn’t track the problem quickly so I switched to a different plugin. That one allowed to disable the css generation.

Viewing 15 replies - 16 through 30 (of 54 total)