codejp3
Forum Replies Created
-
Forum: Plugins
In reply to: [bbp style pack] Astra theme compability issueAstra is a very popular/common theme. I think it makes more sense to ensure bbp Style Pack is compatible with it than to suggest random themes hoping you’ll be happy with them.
I’m not at my dev computer right now, but will be later today. I’ll install Astra theme and dig in to see what’s not compatible with the theme, and make changes to the plugin as needed.
@wbuser2022 – if you describe exactly what issues you had and what wasn’t working, it’ll help greatly!
Forum: Plugins
In reply to: [bbp style pack] Multisite Compatibility@robin-w –
I wish I could release this one in smaller chunks, but it’s a full re-write of how settings are handled so it really needs to be done all at once. Don’t freak out by me saying that either. The settings are largely untouched, but how they’re defined and rendered is completely new. It’ll make the settings page completely versatile where any setting field can be rendered on any tab, and “like” settings can be grouped together regardless of the option group they belong to. It also means that formatting and sanitizing of all settings is handled prior to saving to the DB. You were previously locked into only being able to render fields per-option group on a per-tab basis. This removes that limitation altogether. Changes to tabs/settings is now as simple as changing array values without ever touching any code. Adding a new tab or any new settings is simply defining an array for it. No need to touch any code unless it’s something non-standard. It removes all limitations that previously existed, and standardizes everything that’s currently there. Since less code has to be touched for future updates, it makes overlooked issues far less likely in the future.
I hope it’s near completion, but realistically it may be another two weeks. As usual, I’ll do a video or two covering all the important parts.
Your concerns are being integrated into the new revision.
It won’t get pushed out as an official stable update until we test it with some volunteer BETA testers first and iron out any bugs. Version 5.2.6 was a big learning lesson on that!
If you want/need to release any other updates prior to this one being ready, go for it. I’ll adapt them to the revision I’m doing.
Forum: Plugins
In reply to: [bbp style pack] Future EnhancementsThe goal is to achieve ONE complete plugin with all main features to have a complete and modern bbpress forum, instead of adding XX plugins to achieve that
(@deepblue5)That’s kinda what I have envisioned. It’s the closest plugin to achieving that, but still has areas where it falls short. We’ll get there. A little at a time.
I’m sure profile enhancements will be coming. Whether it’s integrating with another plugin, or built-in is still to-be-determined.
Thank you for your suggestions!
Forum: Plugins
In reply to: [bbp style pack] Google recaptcha on bsp style pack ?I agree that adding pro-active built-in spam prevention is a wonderful idea. Style Pack does include moderation tools that will help address spam AFTER it’s been posted, and has a few language settings that will help prevent SOME spam, but I do see a void for better pro-active spam prevention, and Google recaptcha is a common tool thrown at that void to try to prevent spam.
I personally hate any kind of captcha period and don’t use them. There are scripts/bots that can defeat them, and there are even cheap paid services that spammers use that will easily defeat them. Besides their ineffectiveness, captchas put the burden of spam management on your users, when it’s not their problem in the first place. They also slow down your site in the process. It’s like using a broken sledgehammer to try to accomplish a precision task.
I personally do 3 things to protect my forums, and it’s been more effective than any captcha I’ve ever used.
1.) Add several hidden Project Honey Pot links within the site overall, and within registration/topic/reply forms. Catches a small % of bots, but reports the data so common spam software adds them to their block lists.
2.) Add a hidden required field to registration/topic/reply forms that is set with a specific value that no human user will see. If the value is changed, it indicates a bot or malicious user changed it, so the message is rejected.
3.) Inject a hidden field via JS to registration/topic/reply forms that will only be added to the form if javascript is enabled (most bots don’t have it enabled). If the field doesn’t exist on form submissions, reject the message.
With that layered approach, I don’t get spam, period. And it’s all completely invisible to forum users. No cluncky, ineffective, burdensome captchas, or math puzzles, or “type this phrase” junk. No end user ever wants to see that junk in the first place. Spam control isn’t their problem and site owners should never make it their problem. (Think I made the point… done preaching for now :))
Perhaps, integrating those 3 above into Style Pack would be of interest and valuable to Style Pack users?
If Google ReCapthca is still requested after those are added, then perhaps it would be considered, but I don’t want to spend any time coding for something that’s ineffective and burdensome to users no matter how popular or common it is.
Forum: Plugins
In reply to: [bbp style pack] bbpress “themes”I think I’m following you, and if I understand correctly, it could be a very helpful addition.
What I think makes sense here is adding the ability for any Style Pack user to submit their own custom styling tweaks. A combination of the values specified within the already available Style Pack settings, plus any custom CSS they’ve added.
Those submitted customizations would be pre-built “themes” available to other Style Pack users. You select one of those “themes” and it imports the settings/CSS for that “theme”.
Submitted/available “themes” could simply be JSON files with the data that get imported/applied when a user selects it.
I think there’s a lot more that needs to be figured out, such as enabling/disabling specific features prior to applying a “theme” – like moderation tools, subscriptions, and so on.
This may also require creating a custom javascript capability/setting, and including that within the “theme.”
Also, the values for each specific “theme” should probably be handled on its’ own settings page to make adjusting each specific “theme” easier instead of having to search through each settings tab to adjust things like colors and fonts and so on.
I’ll keep thinking about it, and try to figure out a good way to implement it without introducing security issues, or requiring excessive server needs for submitting/sharing custom “themes.”
A big undertaking, but I see the value in it, and see it being used by a large # of people.
Great suggestion! I’ll discuss this one with @robin-w to figure out if it’s viable/reasonable, and how we should go about it.
Forum: Plugins
In reply to: [bbp style pack] Subscribe to Forum Button not working@fabienmahot777 – checking back in with you. Have you verified that it’s not working for you with Style Pack 5.3.5?
Forum: Plugins
In reply to: [bbp style pack] No space between attributesWell thank you sir!
It’s WP core itself adding it. Crystal clear now.
I suppose we could add a custom filter to address this issue, and only apply it to the latest activity widget and wherever “is_bbpress()” returns true.
Probably add it as an optional “bbPress fix” since it’s not really a feature/styling element, and addresses a WP/bbPress core issue that most people don’t care about in the first place.
Even though it’s not actually resolved, I’m going to mark as resolved since the mystery is cleared up and it’s not directly a Style Pack issue.
I’ll keep this one in mind for a possible future update, but it’s not a top priority to be perfectly honest. Busy working on another large Style Pack revision and don’t want to spend time fixing non-Style Pack issues right now.
Forum: Plugins
In reply to: [bbp style pack] Center align imgur links?Good deal. Marking as resolved, and I’ll keep thinking about the best way to implement this that would be helpful to most forum owners.
Forum: Plugins
In reply to: [bbp style pack] Center align imgur links?I also tested the code I previously gave to you against your site and it does not appear to negatively affect the imgur iframe embeds. I was not able to duplicate the issues you described.
But, based on what you said, you could use the first CSS snippet to align all regular img tags center & one of the second CSS snippets to center imgur embeds, and theoretically, this third snippet should prevent them from conflicting like you described:
/* imgur prevent img tag conflicts */ iframe.imgur-embed-iframe-pub img.post { display: inline-block; width: auto; }Again, I couldn’t duplicate the issues you described so I can’t test this, but it should theoretically work.
Forum: Plugins
In reply to: [bbp style pack] No space between attributesSO after looking into onecom-vcache, apparently that plugin is an interface to the Varnish CDN provided by One.com
That does make it a suspect. However, I was not able to find anything that Varnish does specifically affecting images, so that makes it slightly less suspect.
Admin Menu Editor shouldn’t be affecting it.
It’s SOMETHING that’s lazy-loading images and setting them as asynchronous loading. That’s not the default action of the latest activity widget images, so it’s something external to Style Pack.
- This reply was modified 3 years, 3 months ago by codejp3.
Forum: Plugins
In reply to: [bbp style pack] Center align imgur links?OK. Imgur is actually an iframe embed, not a direct img tag. This will center ONLY imgur embeds:
/* imgur center image embeds */ iframe.imgur-embed-iframe-pub { display: block; margin-left: auto !important; margin-right: auto !important; }Bonus: set the width to 100% too:
/* imgur center image embeds with 100% width */ iframe.imgur-embed-iframe-pub { display: block; margin-left: auto !important; margin-right: auto !important; min-width: 100% !important; }Forum: Plugins
In reply to: [bbp style pack] No space between attributesI’ve checked out both Autoptimize and WebP Converter for Media and don’t see either of them injecting the itemprop value.
I looked for the one.com Performance Cache plugin but I’m guessing that’s a default plugin that gets installed as a MU plugin for your hosting (not available in the WP plugin repo). That’s still suspect.
By chance are you running your site through a CDN like CloudFlare? Those are suspect too.
Forum: Plugins
In reply to: [bbp style pack] Center align imgur links?In other words :
1.) a global option for site owners to setup forum-wide default image alignment (would just add CSS to the generated bspstyle.css file) , and an the ability to choose whether users can override.
2.) if per-user override allowed, an option within the topic/reply form that allows users to align all images within that reply left/center/right (would add in-line style attributes on a per-div.bbp-reply-content basis).
Just curious, I haven’t tried it, but the align buttons in MCE visual editor should allow aligning images left/center/right on a per-image basis. If that’s not the case then perhaps something can be do with that. That’s kinda why I figured you were looking for a “global center all images” CSS snippet in the first place.
Forum: Plugins
In reply to: [bbp style pack] Subscribe to Forum Button not working@fabienmahot777 – are you using v5.3.5 of Style Pack?
We just added a fix that has been tested and confirmed to work for both with or without BuddyPress.
I just retested myself to verify and it is indeed working for me without BuddyPress.
If you’re using the latest version of Style Pack but still have issues, report back here and we’ll dig into it more. Perhaps it’s another plugin conflicting or something like that.
Forum: Plugins
In reply to: [bbp style pack] No space between attributesFYI, Style Pack does not specifically add “
loading='lazy' decoding='async'itemprop="image". It’s being added elsewhere along the way. If you have any page-speed plugins activated, specifically for image loading speed-ups, they’re the most-likely culprits. Try deactivating those plugins one at a time and re-run w3 validator to see which plugin is doing it.