codejp3

Adding:

19.) “Login” tab settings overhaul:
– Better grouping of related options
– Logged-in redirect options: 1.) back to the previous URL, 2.) custom URL, 3.) Site Home, 4.) Forum Index
– Already Logged-in message/redirect: better setting description for clarity
– Logged-out redirect options: 1.) back to the previous URL, 2.) custom URL, 3.) Site Home, 4.) Forum Index
– Already Logged-out message/redirect
– Conditional check to only show “Select which menus to show XXXX on” if nav_menus array not empty & current theme supports nav_menus
– Conditional checks to only show “Add to nav menu” options if current theme supports nav_menus

Most of that is just re-doing what’s already there, with a few extra redirect options added to improve the login/logout experience.

Dare I say it…. we might FINALLY be sorted and have a good solid “stable” starting point for all future additions 🙂 ….3 updates later 🙁

I do have some other projects to wrap up so I won’t be putting as much time into BSP, but as I use the plugin and notice things, I’ll fix/enhance them and send the code your way.

@robin-w – I looked at the code for 5.2.9 to see what you ended up with. Overall I get it and like it. Serves the purpose of only regenerating files when needed, doesn’t rely on hooks that may or may not fire as intended, and waits until everything necessary is loaded.

One small tweak to the “Handle upgrade actions” code just around line 520-ish to take care of a debug message :

Only change here was adding:

$bsp_name = plugin_basename( __FILE__ );

before:

$network_wide = ( is_multisite() && is_plugin_active_for_network( $bsp_name ) ) ? true : false;

I was getting “WARNING: bsp_name is not defined” debug messages, and since it wasn’t defined, it always made $network_wide = false, so the bsp_plugin_update function didn’t do network-activated version updates or re-generations.

As an extra precaution, I added this check the top of the bsp_plugin_update function:

        if ( ! function_exists( 'get_plugin_data' ) ) {
                require_once( ABSPATH . '/wp-admin/includes/plugin.php' );
        }

Also, since the bsp_plugin_update function is now only called if “($new_version != $curr_version)”, I removed the duplicate check within the bsp_plugin_update function.

I went ahead and posted these changes to github as v5.3.0:
https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.3.0

Direct Download:
https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.3.0.zip

Playing around with it a little more before saying it’s 100% good-to-go, but that was the only issue I encountered on multisite.

Since I think I’m currently the only multisite user, the update probably isn’t critical to publish immediately. However, anyone who has debugging enabled will see the “WARNING: bsp_name is not defined” message, so that may justify publishing it sooner.

@robin-w

GitHub “main” branch updated to the current 5.2.7 version you just published:
https://github.com/codejp3/bbp-style-pack

5.2.8 branch created:
https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.2.8

Side-by-side comparison:
https://github.com/codejp3/bbp-style-pack/compare/pre-pub-5.2.8?expand=1

Direct Download:
https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.2.8.zip

Code Change Highlights:

1.) /bsp-style-pack.php
– activation hook moved to the bottom (probably unnecessary, but did it anyways)
– new plugin update hook added that performs the activation actions on plugin update

2.) /includes/functions.php
– new function added to check custom CSS locations
– now also checks if dir exists, and if dir is writable
– returns empty array if all checks pass
– returns an array of current error messages for specified custom CSS location
– messages re-done to be translatable gettext strings

3.) /includes/generate_css.php
– only generate/enqueue custom CSS location files if there are no errors with the custom location (uses function in #2 above) (prevents 500 server errors I was getting when I intentionally gave bad locations)

4.) /includes/settings_css_location.php
– extra “isset()” checks for text input fields to prevent PHP array index warnings
– direct error handling removed from file
– now displays error messages returned by function in #2 above

5.) /includes/settings_breadcrumbs.php
– extra “isset()” checks for text input fields to prevent PHP array index warnings

6.) Topic count files are identical to what was in the official 5.2.7 (now the main branch) so your changes should be intact.