codejp3

I went ahead and took care of this. Wasn’t as simple as I was expecting, but nothing too serious.

Here’s the exact changes made:

1.) /js/bsp_quote.js
Now checks for which editor is currently visible. This handles all cases, even if both editors are active.

jQuery(document).ready(function($) {
	 
        $('.bsp-quote-link').click(function() {

                var id = $(this).attr("href").substr(1);

                var data = {
                        'action' : 'get_status_by_ajax',
                        'id' : id,
                        'security': bsp_ajax_object.quote
                }
                $.post(bsp_ajax_object.ajax_url, data, function(response) {

                        // if tinymce editor currently visible
                        if( $('.mce-tinymce.mce-container.mce-panel').is(':visible') ) {
                                tinymce.get("bbp_reply_content").execCommand("mceInsertContent", false, response); 
                        }

                        // if default text editor currently visible
                        if( $('textarea#bbp_reply_content').is(':visible') ) {
                                quote = response;
                                replyTextfield = $("#bbp_reply_content");
                                text = replyTextfield.val();
                                if(jQuery.trim(text) != ''){
                                        text += "\n\n";
                                }
                                text += quote;
                                replyTextfield.val(text);
                        }

                        // scroll to new_post form
                        location.hash = "#new-post" ;

                });	        
        });  
 });

2.) /includes/generate_css.php
Now enqueues the bspstyle-quotes CSS file both ways – directly in tinymce (if active) and as a separate stylesheet (if text editor active). Also now includes the versioning timestamps for that file in case it gets enqueued as a separate stylesheet:

//if quotes active	
if ( !empty( $bsp_style_settings_quote['quote_activate'] ) ) {
 
        // determine which editor is currently being used
        // no settings specified, using default text editor
        if ( empty( $bsp_style_settings_form['Show_editorsactivate'] ) ) {
                $text_editor = true;
                $tinymce_editor = false;
        // settings specified, set flags based on settings value
        } else {
                switch ( $bsp_style_settings_form['Show_editorsactivate'] ) {
                        case 0 :
                                $text_editor = true;
                                $tinymce_editor = false;
                                break;
                        case 1 :
                                $text_editor = false;
                                $tinymce_editor = true;
                                break;
                        case 2 :
                                $text_editor = true;
                                $tinymce_editor = true;
                                break;
                }
        }       
    
	/* add the style sheet */
        $quotes_css = bsp_add_custom_editor_style();
        // only if quotes css file exists
        if ( $quotes_css ) {
            
                // if tinymce being used
                if ( $tinymce_editor )
                        add_filter( 'mce_css', 'bsp_add_custom_editor_style' );

                // if default text editor being used
                if ( $text_editor )
                        add_action( 'wp_enqueue_scripts', 'bsp_enqueue_quote_style' );
                        
        }
        
	//and enqueue the js
	add_action( 'wp_enqueue_scripts', 'bsp_enqueue_quote' );
}


//this function creates the style sheet, generated when the quotes tab is accessed.
function generate_quote_style_css() {
	require_once( ABSPATH . 'wp-admin/includes/file.php' );
	global $bsp_css_location ;
	ob_start(); // Capture all output (output buffering)
	require ( BSP_PLUGIN_DIR . '/css/styles-quote.php' );
	$css = ob_get_clean(); // Get generated CSS (output buffering)
        $css_filename = 'bspstyle-quotes'.( is_multisite() ? '-'.get_current_blog_id() : '' ).'.css';
        update_option( 'bsp_style_quote_generation', time(), true );
	if ( !empty($bsp_css_location['activate css location'] ) && !empty( $bsp_css_location['location'] ) ) {
		$location = $bsp_css_location['location'] ;
                // if it starts with '/' -  remove
                if ( 0 === strpos( $location, '/' ) ) {
                $location = substr( $location, 1, strlen( $location ) ) ;
                }
		// if it doesn't end with a '/' add one
		if (substr( $location, strlen( $location )-1, strlen( $location ) ) !== '/' ) {
			$location = $location.'/' ;
		}
		$path = get_home_path();
		$path = $path.'/'.$location ;
		file_put_contents( $path.$css_filename, $css, LOCK_EX ); // Save it
	}
	else 
	file_put_contents( BSP_PLUGIN_DIR . '/css/'.$css_filename, $css, LOCK_EX ); // Save it
}

function bsp_add_custom_editor_style() {
        $css_filename = 'bspstyle-quotes'.( is_multisite() ? '-'.get_current_blog_id() : '' ).'.css';
        if ( !empty( $bsp_css_location['activate css location'] ) && !empty( $bsp_css_location['location'] ) ) {
		$location = $bsp_css_location['location'];
                // if it starts with '/' -  remove
		if (0 === strpos( $location, '/' ) ) {
			$location = substr( $location, 1, strlen( $location ) ) ;
		}
		// if it doesn't end with a '/' add one
		if ( substr( $location, strlen( $location )-1, strlen( $location ) ) !== '/' ) {
			$location = $location.'/' ;
		}
                // return custom URL location
                if ( file_exists( ABSPATH.'/'.$location.$css_filename ) ) {
                        $location = home_url().'/'.$location ;
                        return $location.$css_filename;
                }

	} else {
                // return default URL location
                if ( file_exists( plugin_dir_path( dirname( __FILE__ ) ).'css/'.$css_filename ) ) {
                        return plugins_url( 'css/'.$css_filename, dirname( __FILE__ ) );
                }
        }
        // return false, no file found
        return false;
}

function bsp_enqueue_quote_style() {
        wp_register_style( 'bsp_quotes', bsp_add_custom_editor_style(), array(), get_option( 'bsp_style_quote_generation', time() ) );	
        wp_enqueue_style( 'bsp_quotes' );
}

function bsp_enqueue_quote() {    
        wp_enqueue_script( 'bsp_quote', plugins_url('js/bsp_quote.js',dirname( __FILE__ )), array( 'jquery' ), get_option( 'bsp_version' ) );
        wp_localize_script( 'bsp_quote', 'bsp_ajax_object', array( 'ajax_url' => admin_url( 'admin-ajax.php' ),'quote' => wp_create_nonce('get_id_content') ) );
}

The end result is that quotes are now working regardless of which editor you have active, and if you have BOTH editors active, the quotes functionality will happen based on which editor tab is CURRENTLY ACTIVE in the reply form.

I’m including this in the 5.2.6 release. Uploading to GitHub now. Re-download with these new changes to test it out for yourself:
https://github.com/codejp3/bbp-style-pack/archive/refs/heads/proposed-v5.2.6.zip

Thank you for the quick reply!

I wish I could have given you more information, but no debug messages were being kicked out. It just “broke” all URLs on the page without any indication ‘why’.

Just confirming that this did fix the network admin plugins page issue.

    function enqueue_feedback_scripts() {
        $screen = get_current_screen();
        if ( isset( $screen ) && $screen->id == 'plugins' ) {
            if ( $hook == 'plugins.php' ) {
                wp_enqueue_script( 'atlt-free-feedback-script', $this->plugin_url . 'includes/Feedback/js/admin-feedback.js', array( 'jquery' ), $this->plugin_version );
                wp_enqueue_style( 'cool-plugins-feedback-style', $this->plugin_url . 'includes/Feedback/css/admin-feedback.css', null, $this->plugin_version );
            }
        }
    }

Thank you for the temporary fix until the update is released.

I know that your plugin is an add-on to Loco translate.

How does that address the issue with your plugin breaking the network admin plugins page anytime your plugin is network-activated on multisite?

Loco Translate works fine when network activated. Your plugin breaks the network admin plugins page when it’s network activated.

Here’s a demo video to drive the point home:
https://wp-multisite.local-dev.codejp3.com/temp-videos/automatic-translate-breaks-netowrk-admin-plugins-page.webm

I’ll be around, and offer any support I can. For both my additions/changes, or the plugin as a whole.

@robin-w – As promised, here’s proposed v5.2.6 update info.

Private GitHub Repo:
https://github.com/codejp3/bbp-style-pack

Current 5.2.5 “main” branch:
https://github.com/codejp3/bbp-style-pack/tree/main

Proposed 5.2.6 branch:
https://github.com/codejp3/bbp-style-pack/tree/proposed-v5.2.6

Side-by-side code comparison “pull request”:
https://github.com/codejp3/bbp-style-pack/pull/4/files

Direct Download:
https://github.com/codejp3/bbp-style-pack/archive/refs/heads/proposed-v5.2.6.zip

Explanation & Demo Video:
https://wp-multisite.local-dev.codejp3.com/temp-videos/bbp-style-pack-5-2-6.webm

Multisite Dev Server Account created and password reset sent to you.

GitHub Repo invitation link sent to you.

If you downloaded already…. re-download. I added machine translation files for FR, RU, and JA.

Finalizing Style Pack changes now. Should be today, and ideally both plugin updates get rolled out at the same time….after any additional testing and revisions you may want to do of course!

I think I narrowed this one down some more.

Custom generated files get removed on plugin update. I’ve found myself having to go into BSP and re-click “save options” just to regenerate custom files after an update.

A minor inconvenience for a single site install. A total pain for multisite installs.

I added a plugin_activation hook that will automatically regenerate custom files any time the plugin is updated, for both single site installs and multisite installs.

This will be included in the update I send you later today.