eclev91
Forum Replies Created
-
Forum: Plugins
In reply to: [User Role Editor] Subscribers have capabilities brute-force removed@shinephp oof yes I did, sorry about that! This is the plugin that was _impacted_ by the other one, heh.
Forum: Plugins
In reply to: [Rich Showcase for Google Reviews] Deprecated codeHey @richplugins saw a new release was dropped, which is great, but I would like to bump you on the above versioning issue. The old 1.42 release is technically a “newer” version than 1.9.x, so something needs adjusted for tools like WPackagist that consume version numbers to work properly.
Forum: Plugins
In reply to: [Simple Lightbox] SLB + ACF WYSIWYGLast thing –
If someone wanted to run this site wide, this:
add_filter('acf_the_content', function($content) { if(!function_exists('slb_activate')) return $content; return slb_activate($content); });Might be worth considering building into the plugin by default? Seems reasonable, since according to the team, acf_the_content only varies from the_content when required for a couple bugs, so their expectation is that your logic runs on them.
Forum: Plugins
In reply to: [Simple Lightbox] SLB + ACF WYSIWYGclosed
Forum: Plugins
In reply to: [Simple Lightbox] SLB + ACF WYSIWYGBah nope, found the difference:
https://www.advancedcustomfields.com/resources/wysiwyg-editor/#notes
Forum: Plugins
In reply to: [Advanced Post Manager] Breaks w/ latest WordPress jQuery updatesHey @vicskf any ETA on this?
Forum: Plugins
In reply to: [Rich Showcase for Google Reviews] Scripts not loadingDeleted all plugin data and started from scratch, working now. Oof.
Forum: Plugins
In reply to: [Rich Showcase for Google Reviews] Scripts not loadingHey there – I now see the interface you’ve outlined here. However, the reviews now aren’t appearing in the widget (still placed via Beaver Builder).
Looking at the debug information, it looks like there are reviews in the database. Not sure why they wouldn’t load into the widget.
happy to send over full debug info.
Forum: Plugins
In reply to: [Mailgun for WordPress] Version 1.7.1 and PHP 7.4 compatibility@mailgun something wasn’t done right when you tagged your latest couple releases. Trunk has 1.7.3, but the tagged 1.7.3 is still actually 1.7.1 (see the plugin headers in the main file in
tags/1.7.3), leaving the plugin page saying the latest version is 1.7.1 and that it hasn’t been updated in 2+ years.- This reply was modified 5 years, 4 months ago by eclev91.
Forum: Plugins
In reply to: [AgeVerify] Undefined variable: prompttextdobSeconded
Forum: Plugins
In reply to: [Rich Showcase for Google Reviews] Deprecated codeHey @richplugins, you’re totally right. This could be causing a collection of issues.
The problem is I’m pulling in my dependencies via Composer and WPackagist. At some point, you changed how you were tagging releases. Rather than 1.4.2, you had tagged 1.42, but then eventually tagged 1.5, and then 1.5.1 and so on. 1.42 is technically a newer release than 1.9.1, and would get a patch release of 1.42.1.
I’ll update my dependencies to 1.9.x, which should get me the right version, but technically you would need to release 1.50 to be properly continuing along. If you end up needing to release a 2.0 at some point, that’ll also clear it up, heh.
@beluserra for posterity, can you outline how this was resolved here in the ticket?
Forum: Plugins
In reply to: [Featured Video Plus] Plugin Abandoned?https://github.com/ethanclevenger91/featured-video-plus/
Forked off a guy who did the actual work to fix the deprecation notice. Added composer support to his work.
Forum: Plugins
In reply to: [Redis Object Cache] Non-expiring transients@tillkruess So I’m right in my understanding that by default, Redis may throw out non-expiring transients from time to time?
(and if you have this thing in git somewhere, I’d be happy to work on a pull request to resolve some of these items)