eclev91
Forum Replies Created
-
Forum: Plugins
In reply to: [Redis Object Cache] Edge case with strange default value being returnedRedis v 5.0.7. Redis Cache plugin is up-to-date, as is the drop-in.
Forum: Plugins
In reply to: [WooCommerce] Batch adding images via API causing 504 errorsHey Mike – the issue is not a memory limit, but a PHP timeout. I could increase the timeout, but that only pushes the issue down the road. If someone tried posting 100 images via the REST API, a timeout of 2 minutes or more would probably still fail.
If I try and post a large number of variations via the REST API, the endpoint will return an error. It’s configured to only accept so many, I assume because it knows adding a large number of variations will either be too time-consuming, or will have overall adverse affects on the site, or perhaps there’s a top limit in WooCommerce core. But the limit is there to prevent abuse of the REST API. It seems to me that trying to post 50 images at once would similarly be an abuse of the REST API. Probably why the core REST API doesn’t have _any_ batch media upload endpoint.
Seems to me that batch media uploads to products via the REST API should be similarly limited to prevent abuse. I can increase my timeout, but for consistent results, people utilizing the REST API should, by default, be prevented from abusing it in this way and putting significant strain on the server.
Forum: Plugins
In reply to: [Instant Articles for WP] GA tracking Code@fiqz90 If you’re using the gtag embed, it references an external script:
<script async src="https://www.googletagmanager.com/gtag/js?id=tracking-id"></script>The plugin is a hard no on that for various reasons. Whether FB itself would allow it is another story, but the plugin won’t print it. Re-implement using the analytics.js implementation for better results.
- This reply was modified 6 years, 4 months ago by eclev91.
Forum: Plugins
In reply to: [HUSKY - Products Filter Professional for WooCommerce] PHP noticeI’ll look forward to an update that resolves it.
Forum: Plugins
In reply to: [WooCommerce] Batch adding images via API causing 504 errorsThe request is not too large, and the logs show a timeout (ultimately, HTTP 504). It’s taking too long because it’s trying to process 20+ images. Like I said, in the media library after running this request, I can see that several of the images get uploaded, but eventually it exceeds 30 seconds (the server timeout limit) and quits.
To give you context, my client is using a Printful integration to sell products with custom designs. When a product from Printful is selected to be imported, it also sends along a bunch of images. Some products have a few images, some have many. The reason this issue just recently showed up is my client just recently tried to do phone cases, which come with tons of images (as you see in the above request). One for each phone size, I assume, versus stuff like pillows and t-shirts which may only have a couple photos.
I’ve recommended my client uncheck several variation photos to prevent this from happening, but an actual solution for REST API product imports with a large number of photos would be to do some kind of background processing of photo uploads. That may be a task for WordPress core, however.
Not sure how this is handled in the block editor, which also uses the REST API for photo uploads. What happens when I drag 20+ photos in? Off the cuff, I’m assuming it sends a separate request for each one, which would get around any potential timeouts.
Forum: Plugins
In reply to: [WooCommerce] Batch adding images via API causing 504 errors@phillipwoo wanted to check in and see if your team had any suggestions beyond sending requests with fewer images at a time. 20-some-odd images is probably likely to take a while no matter what unless this triggered some kind of asynchronous process.
Seconded.
Forum: Plugins
In reply to: [WooCommerce] Batch adding images via API causing 504 errorsLike I said, the images are being uploaded just fine. I can look in the media library and see it made it through several of them and successfully uploaded them. Obviously it just isn’t moving very fast.
Forum: Plugins
In reply to: [YITH WooCommerce Compare] PHP 7.4 CompatibilityPerfect. Will look to see that merged into a release. Thanks.
Shoot – just realized this may be a Pro support question. Sorry about that.
Was able to reproduce. I’ve verified that the shipping total sent to PayPal is correct. Something on PayPal’s end is overriding (or adding to) that total. Need to figure out what.
Actually that’s not true. Orders have been placed since I updated that still display this bug.
Specifically, this is an issue for author archive pages in the schema markup, where the @id is set to null for the author archive page.
Resolved in latest AMP beta. See different Github issue.
- This reply was modified 6 years, 10 months ago by eclev91.
I can confirm this is an error with AMP v1.2 and Yoast v11.6 and WP v4.9.10 (< 5.0).
More details here: https://github.com/ampproject/amp-wp/issues/2862