sel
Forum Replies Created
-
I think I get what you mean, but we didn’t put anywhere in any block any <body> or <html> tags in these blocks and I see the code I mentioned in the code of the plugin and it’s inserted directly before the code-blocks that ad inserter inserts.
Hi, @spacetime Thank you, for the reply. Where can I configure this please?
Thanks!
Please confirm this.
According to the code it seems that since v 2.1.2 the polyfill will only be loaded if you have explicitly added a filter to enable it, otherwise it should not be loaded.from 2.1.2: “Enhancement: Disable polyfill for intersectionObserver by default, added a way to activate it instead”
Therefore if the site using this plugin didn’t set up a filter for this it should be fine.
However I still see a reference to polyfill.io in the new version here in the method/function getLazyloadScript while the polyfill doesn’t seem to be enabled at any time since there is no place in the plugins code to change the polyfill arg to true, it’s there.
/rocket-lazy-load/vendor/wp-media/rocket-lazyload-common/src/Assets.php
Hi Peter,
I understand. Thank you for your answer and clarification 🙂
Bests
Hi Peter,
thanks for the help! We’ll check it out for sure 🙂
I’ll keep you posted
Bests
Forum: Plugins
In reply to: [W3 Total Cache] ERROR – Version 2.2.2 update breaks Total cache admin pages@vmarko Thank You for the feedback and effort
We are looking forward to the fixForum: Plugins
In reply to: [W3 Total Cache] ERROR – Version 2.2.2 update breaks Total cache admin pages@kzeni Thank You! 🙂
@wfphil Sure, will do 🙂
I’d just like to add, that this started happening recently for us too. We use CF and the “CF-Connecting-IP” is set. In the All options page, Wordfence seems to get the IP just fine, but on the frontend Query Monitor reports a
Warning: inet_pton(): Unrecognized address
in: wp-content/plugins/wordfence/vendor/wordfence/wf-waf/src/lib/utils.php:28
component: Plugin: query-monitorWF version: 7.5.7
QM version: 3.8.2
WP version: 5.5.8@spacetime Great point with the /section I forgot that I was testing this while the block labels where enabled.
I’ll follow your instructions and try to find the cause.
Thanks!
Thanks for the reply. I cannot share the website nor give access to it for debugging. Ofcourse I understand this makes it really hard to know, if something is behaving differently because of all our other functionality.
Still I really appreciate the help.I checked if the issue is the order in which the blocks are inserted but found no evidence that this could be an issue.
Just wanted to let you know, that after some manual debugging ( latest version of AI, latest version of WP, using block editor) in the plugins code.. I noticed that if I print out the $content on line 7048 in class.php, I get the following output:
<p>Lorem ipsum...</p><div class='code-block code-block-9' style='clear: both;'> <section class='ai-debug-block ai-debug-default'> <section class='ai-debug-bar ai-debug-default '><kbd class="ai-debug-invisible">[AI]</kbd><kbd class='ai-debug-text-left' title=''>9 Mobile - ad after 1. p. = interscroller<kbd data-separator=" - " class="ai-option-name"></kbd></kbd><kbd class='ai-debug-text-center'> <kbd class="ai-debug-name ai-main"></kbd> </kbd><kbd class='ai-debug-text-right' title='Counters: C= Content, N = Block'> C=1 N=1</kbd><kbd class="ai-debug-invisible">[/AI]</kbd></section> <div class='ai-code'> <div id="inventory_container_mob_article_after_5_paragraph"></div> </div> </section> </div>Here you can see, that on that line at that point, the divs with “code-block” class are present in the content… But after I try to print out the $paragraph_code on line 7126 in class.php each time a paragraph is checked, these are the first 2 codes I see that are checked.
1st:
<p>Lorem ipsum...</p>2nd:
</section> </div>Notice that the 2nd $paragraph_code should contain the divs with the “code-block” classes but it does not…
Because of this I tried to change the “Do not contain” text to “/section” because this is the only string that is present when the plugin is looking for the text in the paragraph…
And now the div is correctly NOT counted.
So indeed the class text exclusion works it’s just that the plugin doesn’t see the whole code as I was expecting.
Thanks
BestsHi @spacetime,
I’d just like to give some feedback because the settings don’t work as I need them to and I can’t achieve my intended outcome.
What I need to do is count divs, but don’t count ad-inserter’s own divs that have the “code-block” class and I can’t achieve this.
What I tried was:
- Count “from top” paragraphs with tags “p, figure, img, div” that have between “empty” and “empty” words and “do not contain” “code-block”… Outcome: This doesn’t work and ad-inserter still count’s the divs with the class “code-block” as any other div… It doesn’t seem to exclude divs based on classes that match the text inserted inside the text field
- Same settings, but set minimum number of words to 1 like this: that have between “1” and “empty”… Outcome: This would work but only if the other divs would contain at least one word and I cannot guarantee that
- Same settings as in the 1st option, but setting: and “do not contain” “Advertisement”… Outcome: I also inserted in each ad-inserter block content the text “Advertisement” but it did not ignore the blocks at all, maybe because I don’t count inside divs of divs… so this is not an option either
Any suggestions please? Currently the only option I have is changing my divs that I need to count to something else like section tags but that’s not entirely the nicest solution…
Could you please explain why the 1st option doesn’t work? According to your answer yesterday it should
Really appreciate the help!
Thanks!
BestsThank You, I’ll test one more time with this in mind 🙂
Bests
Hi @spacetime,
thanks for the answer. Does “Do not contain” also check the tag attributes like classes and ids? Because that’s the condition I need to check.
I checked the documentation and I don’t think this is clear in the documentation.
The plugin seems to work correctly I just need to figure out whether it is possible to count divs, but not divs with certain classes.
This is not a bug neither an error, it’s rather a question / feature request.
Thanks!
BestsForum: Plugins
In reply to: [Cloudflare] Pagination issue solved but another issue appearedSame experience here, have to downgrade