Oskari Groenroos
Forum Replies Created
-
Forum: Plugins
In reply to: [SVG Support] Imported SVGs not supportedGotcha! I’ll try it out when it’s released, and report back!
Forum: Plugins
In reply to: [SVG Support] Imported SVGs not supportedThank you! Let me know if you need more specific repro steps!
Forum: Plugins
In reply to: [SVG Support] 2.5.7 – Authenticated (Author+) Cross-Site Scripting via SVGThanks for picking it up so quickly @benbodhi, and for dealing with the unnecessary complaining with poise and professionalism! Looking forward to the update! 👍
I had the a similar problem with installing the plugin on a new site, and after activating the plugin, the entire backend was locked out due to a fatal error.
After turning on
WP_DEBUGto see error messages, it turned out to be because the server did not have thephp-curlpackage installed.It might be helpful to have more graceful error handling in case curl is not available.
Hi @coolcoders
I see – it might be helpful to have the screenshots taken on the same settings, so they’re more directly comparable?
In any case, I would prefer to provide my own template for the cart, so I think if the plugin had an overridable action for loading these templates, it would be a good way to do that. What do you think?
Thanks for your response Rupinder!
I understand where you’re coming from. I had a look at the alternative cart layouts, but looks like option 1 is the only one with adjustable quantities, so it’s the only workable one for me if we’re skipping the cart page.
In this case, I think you could set it up so that the cart layout loading is wrapped inside a custom hook. If it was like that, then any theme that relies on your plugin (like the custom one for my site) can use
remove_actionto unhook the built-in cart layout and thenadd_actionto load their own in its stead. This would allow customisation, while simultaneously preventing any unchecked replacement by themes that aren’t aware of your plugin.Do you think that could work?