yann1ck

Hi Sybre,

thank you very much for your response and your example. Why are you not using the “the_seo_framework_breadcrumb_shortcode_output” filter? Thats what I played with before going with a CSS only solution. Perhaps it is helpful for someone else.

.tsf-breadcrumb .breadcrumb-item:not(:nth-child(-n + 2)):last-of-type {
    display:none;
}

.tsf-breadcrumb .breadcrumb-item:not(:nth-child(-n + 1)):nth-last-of-type(2)::after {
    display:none;
}

I just add a pull request for my suggestions.

While doing that I saw that you accounted for the prefixes. I have missed that before

• This reply was modified 3 years, 6 months ago by yann1ck.

Hi Phi,

thank you for your fast response!

I have on more suggestion. To get the name of an archive you use $post_type->labels->singular_name, but the singular name is not the same as the archive title. If I have an archive listing books there is an important difference in meaning between ‘books’ and ‘book’. So perhaps name would be better? (There is also the problem with prefixes, but I think there is no easy solution for it.

Is there a Github repo? I can write a pull request for both suggestions.

Kind regards
Yannick

Hi, thank you for considering my suggestion!

Hi Robert, thank you for the reminder. I totally forgot to change the status.

Hi, thank you very much for looking into the error and creating a bug report! 🙂

Hi Lap,

thank ou very much for your response and I am super sorry that I didnt answer las week, but it was a busy week.

I am not using anything to combine and minify JS.

You can test on this site: https://masterliste.psyfako.org/test-formular/

The forms are exactly the two forms from above. Its a Divi site but I have the same problem on a staging site that using a clean install.

Do you need more information?

Hi,

I already change the duplicate names and also added some server side validation.

Playing around with the data-hide-if attribute I think I encountered a bug when using a required input.

In that case HTMLForms removes the required attribute from the input element and replaces it with a data-was-required:true attribute. Thats a nice solution to add detect if a ‘required’ tag needs to be added back, but it is not added back. That leads to problems with front-end form validation, because fields that were set as required are not required anymore.

I build a simple example with data-hide-if, to show the problem.

<p>
  <label for="SELECT_1">Select a option</label>
  <select name="SELECT_1" required id="SELECT_1">
    <option value="" disabled selected hidden>Select</option>
    <option value="One">One (hides the text field)</option>
    <option value="Two">Two</option>
  </select>
</p>
<p data-hide-if="SELECT_1:One">
	<label for="HIDDEN_TEXT">Text field (is hidden if you select one)</label>
	<input type="text" name="HIDDEN_TEXT" required id="HIDDEN_TEXT" />
</p>
<p>
	<input type="submit" value="Absenden" />
</p>

In this example the text field is set as required, but this attribute is remove by HTMLForms on page load an replaced with data-was-required:true. I would expect the text field to required, so that the form valdiation works and it is not possible to submit the form with an empty text field.

If I use data-show-if it works as expected. But it is not always possible to use data-show-if instead of data-hide-if:

<p>
  <label for="SELECT_1">Select a option</label>
  <select name="SELECT_1" required id="SELECT_1">
    <option value="" disabled selected hidden>Select</option>
    <option value="One">One (shows the text field)</option>
    <option value="Two">Two</option>
  </select>
</p>
<p data-show-if="SELECT_1:One">
	<label for="HIDDEN_TEXT">Text field (is visible if you select one)</label>
	<input type="text" name="HIDDEN_TEXT" required id="HIDDEN_TEXT" />
</p>
<p>
	<input type="submit" value="Absenden" />
</p>

• This reply was modified 3 years, 8 months ago by yann1ck.