launchinteractive
Forum Replies Created
-
Forum: Plugins
In reply to: [Merge + Minify + Refresh] URLs replacedIt looks like you are using wordpress fastest cache. I think MMR might be conflicting with it. Are you able to try disabling it and see if that helps?
Thanks Héctor, I was looking at the previous version of the code. I’ve been trying to think of a way that we could make this work and I haven’t come up with a good solution. The reason is that MMR changes the enqueue handles so your convert_inline_js_into_json function won’t do anything. What could work is if your function is changed from checking the handle to checking the $src. Do you think that would be an option?
I haven’t looked into the way Autoptimize works but I suspect it is different to MMR. MMR bundles enqueued scripts and can’t see the script tags to check if they are application/json.
I think we should change our code to handle wp_add_inline_script better but it doesn’t look like your using it. Am I missing something?
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Does not minifyAfter looking at this again I believe the issue relates to PHP Minify having trouble minifying javascript that is already minified. I suggest enqueing the unminified version of your javascript as that should solve the issue.
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Does not minifyAfter reviewing the MMR code it looks like MMR will minify files every time if there are more than 1 file to merge.
It looks like flickity.js and script.js have minified ok. Are you waiting for the background cron to complete before reviewing the files?
It doesn’t look like jquery.unveil.min.js has minified which I find interesting. I wonder if it’s an encoding issue. Are you able to check if those files are saved as UTF-8?
Thanks for providing that extra information Hector. I’ve had a read through the WordPress Popular Posts code and I’m not sure there is a way we can detect that you are going to modify the script tag.
A potential workaround is adding the wpp-js script file to the MMR ignore list eg. https://DOMAIN.COM/wp-content/plugins/wordpress-popular-posts/assets/js/wpp-5.2.1.min.js
I’m not entirely happy with this as the user needs to know to do this and will need to do it every time your javascript file path changes.Is there any reason you can’t output your json file using the wp_head action?
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Does not minifyAhh, its because the files you are including have .min.js in their file extension. MMR assumes the files are already minified when the extension is .min.js or .min.css.
Can you rename your files?
- This reply was modified 5 years, 10 months ago by launchinteractive.
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Minify CSS/JS issuesHi,
It looks like closure supports important comments and PHP Minify doesn’t. I’ve added a request for this to be looked at. You can comment on it here: https://github.com/matthiasmullie/minify/issues/334
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Does not minifyOn the MMR Settings page can you click on each merge and see if any errors are listed?
To ignore the jquery file get the full path from the merge list and add it to the ignore box on the settings page.
Thanks, I’ve rolled this out in a new update today.
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Does not minifyMinification is done using WordPress cron. Do you have that turned off?
Also, check the settings page and expand the javascript items. It will say if it had issues minifying files.Forum: Plugins
In reply to: [Merge + Minify + Refresh] Failure after using plugin URGENT TO SOLVE ISSUEDid you do anything else when you installed MMR? I can’t think of any reason that MMR would cause disconnects. Hardly anything is written to the database.
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Failure after using plugin URGENT TO SOLVE ISSUEDo you use a can or other caching plugins? If so please clear your cache and the problem will be solved.
Forum: Plugins
In reply to: [Merge + Minify + Refresh] Exclude all woocommerce jsHi Jean, you can exclude the woocommerce javascript by reviewing the included scripts and working out which scripts are coming from woocommerce. For example you can see that these three scripts come from woocommerce because they are in the woocommerce plugin folder:
https://website.com/wp-content/plugins/woocommerce/assets/js/frontend/add-to-cart.min.js
https://website.com/wp-content/plugins/woocommerce/assets/js/js-cookie/js.cookie.min.js
https://website.com/wp-content/plugins/woocommerce/assets/js/frontend/cart-fragments.min.jsYou should be able to simply add those urls (and adjust the domain) to the ignore textbox.
However, you shouldn’t need to disable minification for woocommerce as MMR should be smart enough to enqueue plugins correctly after the woocommerce scripts have been enqueued. Are you having trouble with files not minifying correctly?
Forum: Plugins
In reply to: [Merge + Minify + Refresh] SubdomainAny chance you can grant me access to have a look? You can contact me here: https://launchinteractive.com.au/enquiry