Nextendweb

@thegentatwpforum, I’m sorry, but it is not that easy. As I see in that documentation you must be a JavaScript developer or you need one to display texts in sync with a video.

I suggest you to use YouTube with subtitle or write a custom HTML5 video tag with subtitle.

Hi @paucompany,
Smart Slider does not open ports and do not use anything external resource without user interaction. Smart Slider use the in-built WordPress update system, which connects to ww.wp.xz.cn servers. Also if you use the in-built sample sliders features, it imports the chosen slider from api.nextendweb.com.

What kind of firewall do you use? Could you check the firewall logs of for clues? If you activate your firewall, the whole website is black or just the slider is not showing up on your site?

@a223123131, all of these changes what we will do for better score take some time. We know the key points where we can improve. This is our main priority and I’m sure we will be able to release it before Google starts to really use these metrics in the SEO ranking algorithm (That will happen in May 2021).

These are the main points where we want to improve:

• Reduce JavaScript usage
• Reduce HTML footprint
• Leverage JavaScript usage
• Grid based layouts
• Native lazy loading
• Explicit image sizes
• Device specific image optimization

I think the complete solution will be released in January/February 2021. Until that I need to ask your patience and I will try to publish test versions for you in this topic before the final release.

@oganianarman, the fix for this issue is out in version 3.4.1.12. Thank you for reporting it!

@oganianarman, I just bought one of your theme and checked your code. I will make a fix tomorrow in Smart Slider for Themify themes.

BTW.: class TFCache:
I do understand that your implementation works, but it’s wrong! You open an output buffer in template_include and you want to close the same output buffer at late shutdown. If there are multiple plugins installed, there is a chance that you are closing someone else’s output buffer. It might not result in bugs most of the times, but it might…

The fail-safe solution on your side would be the following. Only drawback is that you can not start new output buffer inside tf_cache_end and you can not echo anything there:

    private static function tf_cache_start() {
        // ....
		define('TF_CACHE',true);
		ob_start(array(__CLASS__,'tf_cache_end'));
    }

    
    public static function tf_cache_end($html, $phase) {

        if ($phase & PHP_OUTPUT_HANDLER_FINAL || $phase & PHP_OUTPUT_HANDLER_END) {
            //.....
            $html=preg_replace(..., ..., $html);
            //.....
		}
        return $html;
    }

I do not mind if you do not implement it. I just wanted to let you know.

@oganianarman

https://prnt.sc/vfq0o2

in_array checking if our callback is in the ob_list_handlers() -> array.

Also if we reach our callback, we break the loop so no other output buffer handlers gets closed.

If you check your last screenshot, you can see that Smart Slider’s output buffer was opened sooner than yours. Also it seems likes Smart Slider closes the buffer closes earlier than you. This is how it looks like:

<?php
ob_start(); // Smart Slider opens
ob_start(); // Themify opens

ob_get_clean(); // Smart Slider closes as its not our callback
ob_get_clean(); // Smart Slider closes as its our callback and breaks the loop
ob_get_clean(); // Themify tries, but there is no output buffer left. Smart Slider closed it.

I’m open for changes, but without sending you an installer of your theme where I could test I can not change anything. Proper testing is important for me.

Hi @oganianarman,
thank you for reporting this issue, we will investigate it. What I need is an installer to one of your theme and any special things to enable in your theme if needed. I will check how do you handle output buffering and based on that I will fix this issue in Smart Slider.

​​Few years ago I had a thorough research about output buffering in plugins and themes. There are a lot of misunderstanding about output buffers. Here you can read about my findings: https://github.com/nextend/wp-ob-plugins-themes
​It turned out that the only failsafe way of using output buffers if you use ob_start with callback function. If you start a new output buffer somewhere around template_redirect action, you can not be sure that the same output buffer will be accessible at shutdown for example.

@mmhgloba, that’s great. I’m happy that it works as expected! 🙂