rsmith4321
Forum Replies Created
-
Forum: Plugins
In reply to: [Photo Engine (Media Organizer & Lightroom)] Reduce size of Galleries PageI just tried the update, that is just what I needed. With that I don’t think there is any need to go into the gallery page anymore.
Forum: Plugins
In reply to: [Contact Form Block] RedirectI was trying out the contact form it’s been a while. When you say you added this is it a shortcode attribute? Or do you need the below filter? If so how can this be modified to redirect to the url whenever the message sending is successful? Thanks!
add_filter( 'mcfb_redirect_url', function ( $url, $success, $error, $form ) { if ( $form['from'] === '[email protected]' ) return 'https://myfamily.com/hellomybrother'; return $url; }, 10, 4 );Forum: Plugins
In reply to: [Contact Form Block] RedirectA shortcode attribute would work for me but a block setting would probably be easier for most users. I assumed it could be done with a filter I just didn’t know how.
Forum: Plugins
In reply to: [Contact Form Block] Reply To:I tried the latest version, it looks like I either missed it before or you implemented the suggestion to have the name field added to the subject line. Thanks! The only other thing is the reply to: field needs to contain the name and email address of the sender. That is typical for contact forms because they all come from your website address but you want the reply to the name and email address of the sender. I actually tried uncommenting the line
$headers = "From: ${name} <${from}>;" . "\r\n";I thought maybe that would do it you just didn’t want it by default, but it still didn’t change the header. Besides that it seems fully amp compatible so I would love to use it, thanks!- This reply was modified 6 years, 8 months ago by rsmith4321.
Forum: Plugins
In reply to: [AMP] Classic block galleries amp issuesThat’s fantastic, I searched everywhere and could not find that documented.
Forum: Plugins
In reply to: [AMP] Classic block galleries amp issuesThe gallery is added just like this in a classic block.
<p>[gallery link="file" ids="30151,30150,30149,30148,28682,30147,28684,30146,30145,28683,30144,30143,30142,30141,30140,30139,30138,28685,30137,30136,30135,30134,30133,28681,30132,30131,30130,30129,30128,30127,30126,30125,30124,30123,30122,30121,30120,30119,30118,30117,30116,28686"]</p>. I’m actually not even sure why it is being turned into a amp-carousel. A gallery shortcode should just default to a standard column of images. I wonder if amp was ever tested with classic block galleries like this? By the way is there any way to set the default attributes for gallery shortcodes, for example if I want the default to be size=”large” columns=”1″ without adding it to every shortcode? Thanks!Forum: Plugins
In reply to: [AMP] Amp Carousel doesn’t have alt tagsThanks for the help. Just to explain a bit better on the second issue and I can add it to GitHub. I have a gallery shortcode like [gallery ..... link="file"] so each image should be linked to its source image. And without any amp options selected it works correctly. However, on that example page, I have the amp option to add lightbox selected in the editor. If the lightbox selection is on, then the the links to the source images disappears and the lightbox doesn’t work. It’s the same as if link=”file” is not in the shortcode. Hopefully that makes sense.
Forum: Plugins
In reply to: [AMP] Post-Processor cache keeping getting disabledActually that is what I was thinking since I had full page caching I didn’t know if it would make a difference. That is good to know I’ll just not worry about it then.
Forum: Plugins
In reply to: [AMP] Post-Processor cache keeping getting disabledI’m having the same issue, I can’t find anything dynamic in my pages that would cause the cache to be disabled. Yet it will just randomly report a different page each time including my homepage that is causing the problem so it seems to be something on every page. If anyone can check it out and find the reason that would be great https://www.ryansmithphotography.com.
Forum: Plugins
In reply to: [AMP] Amp Carousel doesn’t have alt tagsAnother issue I’ve noticed, if I have a gallery shortcode with link=”file” in the shortcode, if add lightbox effect is selected but display as carousel is not selected, the link on the images no longer appears in the html. I created a test page so you can see both types of galleries and their issues. The only thing that works correctly is if neither checkbox is selected, then the gallery works properly with alt tags and links on the images.
You can view the test page here https://www.ryansmithphotography.com/amp-gallery-test/Forum: Plugins
In reply to: [AMP] Amp Carousel doesn’t have alt tagsYes all the images have alt text. I’m using a wordpress gallery shortcode to embed and then selecting display as carousel in the sidebar. Here is the html with a standard gallery you can see the alt tag.
<div class="gallery-icon landscape"> <a href="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation.jpg"><amp-img width="1500" height="1058" src="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" class="attachment-large size-large amp-wp-enforced-sizes i-amphtml-element i-amphtml-layout-intrinsic i-amphtml-layout-size-defined i-amphtml-layout" alt="Couple walking with horse drawn carriage in background Wachesaw Plantation" aria-describedby="gallery-2-30428" srcset="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg 1500w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-300x212.jpg 300w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-600x423.jpg 600w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1100x776.jpg 1100w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-450x317.jpg 450w" layout="intrinsic" i-amphtml-layout="intrinsic"><i-amphtml-sizer class="i-amphtml-sizer"> <img alt="" role="presentation" aria-hidden="true" class="i-amphtml-intrinsic-sizer" src="data:image/svg+xml;charset=utf-8,<svg height="1058px" width="1500px" xmlns="http://www.w3.org/2000/svg" version="1.1"/>"> </i-amphtml-sizer><noscript><img width="1500" height="1058" src="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" class="attachment-large size-large" alt="Couple walking with horse drawn carriage in background Wachesaw Plantation" aria-describedby="gallery-2-30428" sizes="(max-width: 1500px) 100vw, 1500px"></noscript><img decoding="async" alt="Couple walking with horse drawn carriage in background Wachesaw Plantation" aria-describedby="gallery-2-30428" srcset="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg 1500w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-300x212.jpg 300w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-600x423.jpg 600w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1100x776.jpg 1100w, https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-450x317.jpg 450w" src="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" class="i-amphtml-fill-content i-amphtml-replaced-content" sizes="(max-width: 1707px) 490px, 100vw"></amp-img></a> </div>And here is the same gallery but with display as carousel selected.
<div class="i-amphtml-slide-item i-amphtml-slide-item-show"><a href="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" class="amp-carousel-slide" aria-hidden="false"><amp-img src="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" width="1500" height="1058" layout="responsive" class="i-amphtml-element i-amphtml-layout-responsive i-amphtml-layout-size-defined i-amphtml-layout" i-amphtml-layout="responsive"><i-amphtml-sizer style="padding-top: 70.5333%;"></i-amphtml-sizer><img decoding="async" src="https://www.ryansmithphotography.com/wp-content/uploads/2017/09/couple-walking-with-horse-drawn-carriage-in-background-wachesaw-plantation-1500x1058.jpg" class="i-amphtml-fill-content i-amphtml-replaced-content"></amp-img></a></div>Yes it does
I would highly suggest this be the default until ios updates to support intersectionobserver. It took me a while to notice this wasn’t working on safari. On desktop Safari isn’t popular but it very much is on mobile.
Just because you don’t understand PageSpeed is no reason to rate a properly working plugin as one star.
I disabled rocketloader on cloudflare and that fixed the problem, it might be something you want to check out. Thanks!