smerriman
Forum Replies Created
-
Forum: Reviews
In reply to: [AWS for WordPress] (Pending re-review)I haven’t had a chance to test out the new version yet, but reviews can’t be deleted, so will amend the rating from 1 to 3 in the meantime.
Forum: Plugins
In reply to: [WP Recipe Maker] Disable inline CSS?This works for the time being in functions.php but will it cause future issues with the plugin?
if (class_exists('WPRM_Template_Manager')) { remove_action('wp_head',array('WPRM_Template_Manager','custom_css')); }- This reply was modified 9 years ago by smerriman.
Forum: Plugins
In reply to: [Favicon by RealFaviconGenerator] Doesn’t handle site migrations wellBut on second thought, probably still better to show a prompt (the favicon files are out of date, click here to fix) than write to files without the user knowing, especially on high traffic sites where you may get a lot of people visiting at the same time. But for now I probably won’t forget to update them anymore anyway!
Forum: Plugins
In reply to: [Favicon by RealFaviconGenerator] Doesn’t handle site migrations wellA bit hacky but you could store a base64-encoded version of the site URL as an autoloaded option as a validator. Then it wouldn’t be updated by the search/replace, so all you need is one line of code to check if the value matches that correct value rather than using regular file I/O.
Forum: Plugins
In reply to: [Favicon by RealFaviconGenerator] Doesn’t handle site migrations wellYeah, dynamic is probably not a good idea performance wise. I was thinking that this would only happen when a developer migrates a site, so a prompt would just be a reminder that something (not obvious at first sight, if ever!) isn’t working and needs fixing – but of course having it automatically edit the file is just as ideal.
- This reply was modified 9 years, 7 months ago by smerriman.
Forum: Plugins
In reply to: [EasyRecipe] Plugin not working@all – I’m not associated with this plugin at all, but wanted to share some thoughts in case they help you. I’ve been noticing several issues, but all when EasyRecipe is combined with *other* plugins and WP 4.6 – specifically, any that may introduce a new visual editor anywhere on the page.
While this suggests EasyRecipe is at fault as it is common on all of them, I suspect it may not be – having done a lot of debugging, I discovered that WP4.6’s changed behavior affected the other plugins, where *their* code ends up setting their Visual editor as the ‘active’ editor, and not the main content editor, due to changes in the editor behavior in WP4.6. This in turn causes EasyRecipe to break, as it assumes the main content editor is the active one when the page loads.
I would suggest looking for any other plugins which introduce visual editors on the page and seeing if disabling them fixes the problem. If so, try contacting that plugin author with this information. The Advanced Custom Fields plugin, which was the one causing the conflict for me, has already released a fix.
Forum: Plugins
In reply to: [Simple Page Ordering] Row height on drag / widthThe get_post_thumbnail_id function is not defined if the theme does not support post thumbnails, and causes a fatal error. The plugin should check for this rather than assuming every theme has add_theme_support(‘post-thumbnails’).
Hm, maybe I’m not being clear, because the title would never normally be ‘Home – Website Name’ for what I’m talking about.
Just in case you are misunderstanding, here is how I would set up a website for any company at all where the blog is just one part of the larger company website:
Homepage – title tag is ‘Company ABC’
About page – title tag is ‘About – Company ABC’
FAQ page – title tag is ‘FAQ – Company ABC’
Blog page – title tag is ‘Our Blog – Company ABC’.Can’t imagine any scenario where you would want the last one in that list to be ‘Company ABC’ like the plugin does, or ‘Home – Company ABC’ like you mentioned above.
As it stands, the plugin is completely ignoring the title you give to the blog page you create in WordPress – that seems wrong to me. But if you think this is how it should work, fair enough – I’ll just have to keep overriding it. Just means if a company wants to change the name of their blog, they have to do it in two separate places – the title of the page, and then the manually overridden SEO title.
OK, sorry, I had just looked at b), which is still broken – it’s still just showing the name of the website, which as mentioned above doesn’t make any sense. a) is indeed fixed.
Still broken 4 months later. Very simple to fix too.
The plugin also says that any field it can’t determine is added to ‘Staff Comments’.. again, comparing this plugin to previous versions it looks like it used to do that, but that code got deleted too like the above code (which used to exist).. in fact, adding a field it can’t match seems to prevent any data getting through at all.
Related to http://ww.wp.xz.cn/support/topic/plugin-wordpress-seo-by-yoast-page-titles-still-not-working-properly?replies=1 – have been waiting a month for the core issue to be fixed so don’t get your hopes up 🙁
OK – the filter works for that part, but the javascript file still gets enqueued, which breaks all javascript on the page when the co-authors plus meta box doesn’t exists. Hacking in
&& $this->current_user_can_set_authors()in the enqueue_scripts function seems to work – hopefully that can be there in a future version (I see there’s a comment in that function that it should be inserted, so hopefully there wasn’t any specific reason you didn’t :))Just the website name for the static homepage would suffice too, since now that I think about it, Home – xxx isn’t normally needed. But definitely not nothing.