Jason Coleman
Forum Replies Created
-
Thank you for the review. I will forward your kind words on to the support team.
Thank YOU for the kind review. Good luck with everything.
Thanks so much for the kind review. I’m glad we are able to help. Good luck with the site.
Forum: Reviews
In reply to: [LifterLMS - WP LMS for eLearning, Online Courses, & Quizzes] Works greatThanks so much for the kind review.
Hi there. I’ve decided to revert the change. We will keep looking into this.
Version 2.11.2 of PMPro is out now. You can upgrade to that version now to get the other enhancements and fixes in 2.11.1 without that new code that broke things.
The code in question here is in a JS file, which is sometimes cached by performance plugins. So be sure to also refresh your caches.
Let me know if things are working again for you or if you are still having issues.
We will go back to the drawing board RE how to get the benefits of the required attribute without breaking things for some browsers.
Thanks. I see the error on your page. You can revert back to 2.11. I need to recreate it on my own dev sites so I can continue to test revisions.
I am *sometimes* getting the error, which is alarming. I might just revert this change if the attribute is inconsistent like this. Every fix I think of feels a bit hacky and likely to have edge cases for folks using certain add ons and customizations.
Thanks for the heads up on this. We are looking into it.
This sounds like it may be related to this change from 2.11.1 (https://github.com/strangerstudios/paid-memberships-pro/pull/2511) which adds the “required” field attribute to required fields at checkout. This is a good idea for accessibility and other reasons, but perhaps some of those fields with the required attribute are hidden (this is normal when using discount codes or multiple gateways; even free levels might have billing fields rendered and hidden on the page because a discount code might change it to be paid – an odd edge case) and being required by your browser to submit the form.
FYI I tested checkout on that page, but then realized you had reverted to 2.11, so I wouldn’t see the issue anyway. :/
I am having some trouble reproducing this. I think it may be browser dependent. Let me know what OS and browser you were testing in.
We are working on a fix in PMPro Courses. It should be ready in a week or so.
In the meantime, here is a gist that hooks into a filter in PMPro Courses and overrides that redirect_to if the current $post is a lesson and a preview. The main idea here is to set the $redirect_to to null so it doesn’t redirect.
https://gist.github.com/ideadude/1f1b17491f16eca1359a66644fcd58fe
I am unsure if this is the correct code to detect a preview, because I don’t have a copy of the Tutor LMS add on to make preview lessons, but it seems like Tutor stores that info in that post meta field. There may be other issues with the code as I did not test it, but this is the general idea to fix this.
Let us know if it works.
Thanks for reaching out. Sorry you’ve run into this issue. It seems the Tutor LMS module for our PMPro Courses add on does not check for those “preview” lessons.
We would need to update our code around here to account for that. I’ll reach out to the team and see what we can come up with. In the meantime, a work around is to create a copy of the course that is public and has copies of the preview courses available to the public.
Another option if you are a developer, would be to unhook our template redirect method there and code up your own.
I think we should try to fix this use case in our plugin, but I wanted to give work arounds so you don’t have to wait on us. These fixes can sometimes take a while.
- This reply was modified 3 years ago by Jason Coleman.
@isdoo, sorry I missed your last post here. Every single plugin that we release is available for free on GitHub.
I’m quoting my earlier reply here:
You can also find it and our other plugins for free on GitHub: https://github.com/orgs/strangerstudios/repositories
@isdoo Find the repositories there, look for “Releases” in the right sidebar, click on those and download the zip files from there.
Sorry for the slow reply. Can you find the PHP error in your error logs and share with us. That will give us the information we need to figure out what is happening.
FYI there is a known issue when using the latest version of LifterLMS with EITHER PHP < 8.0 or WP < 5.9. If that is the case, and easier fix if possible would be to upgrade WP to 5.9 or higher and try again.
But without the actual error message text, we can’t diagnose this further.
Here is an article with some info on how to find the PHP error log: https://lifterlms.com/docs/how-to-debug-a-white-screen/
The email we sent explained things. Please follow up by email and limit your questions here on .org to questions about the plugin. Thanks.
- This reply was modified 3 years, 1 month ago by Jason Coleman.
In addition, you can look into the PMPro Akismet plugin that we just launched. This limits spam a lot at checkout. You can find it on our site here: https://www.paidmembershipspro.com/add-ons/pmpro-akismet/
Also make sure the “Spam Protection” option is set on the advanced settings. This will block an IP address for a while if they try to checkout more than 10 times in a row. This works well in conjunction with the Akismet add on. You can even tighten up the spam protection a bit using this code to change the parameters:
https://gist.github.com/ideadude/f64ce8aaa3b0a0579034082144cc2220
Let us know if this helps.
Update: The pmpro-akismet plugin is available now. It is free. It, along with our spam protection feature, goes a long way toward preventing spam users at checkout. You can find it on our site here: https://www.paidmembershipspro.com/add-ons/pmpro-akismet/
You can also find it and our other plugins for free on GitHub: https://github.com/orgs/strangerstudios/repositories
@isdoo Find the repositories there, look for “Releases” in the right sidebar, click on those and download the zip files from there.We are working on the code to automatically delete abandoned checkout users after some time. The current plan is to include this in a v2.11 core PMPro release that may be out next month. We’re building and testing.
Hi, everyone. I am very sorry for the issues this update has caused. In hindsight, we should have given more warning of the upcoming change, so folks had time to adjust to the change. We’re working hard now to release updates and documentation to help mitigate the downsides of this change.
There is no way to reverse this change. PMPro will always create users before payments now. There are many reasons for this. Kim White shared some above. We have many planned updates to the checkout experience and how we integrate with gateways, that will depend on the WP user being created before the payment step. I’m working on a blog post that goes into more detail, but the bottom line is that this change is here to stay and there’s no easy way to opt out with PMPro. (@isdoo I think most other WP membership plugins work this way already, but feel free to try them out and see if they are a better fit.)
RE the spam issue, Google Recaptcha v3 and our Spam Protection setting go a long way toward stopping this. If you have the Spam Protection on, you may notice up to 10 spam users from the same IP address and then it stops as the protection clamps down on that IP.
We are pretty conservative about how quickly we lock folks out, because this code doesn’t differentiate between someone who just entered the wrong number vs someone who is testing fake credit cards, but you can “tighten” the protection by setting a couple constants in your wp-config.
https://gist.github.com/ideadude/f64ce8aaa3b0a0579034082144cc2220
We are also fast tracking our Akismet integration to release it as soon as possible. Feel free to use the version Kim linked to on GitHub in the meantime. It won’t change much. The plugin basically integrates with the Akismet API and blocks checkout and user registration if Akismet thinks the email and other data indicates spam.
We are also working on a setting in PMPro which will delete users who never completed checkout after some time, say 24 hours or 7 days. It should be a setting. This is taking some time to develop and test. We want to make sure that this script does not delete valid users who fail PMPro checkout then do something else on your site (via a form or WooCommerce or BuddyPress) where you wouldn’t want their data deleted.
You also should be making sure that your site is set up so that users do not have the same access members do. These users who fail at checkout do not receive a membership level. Require a membership level to view content. Update your integrations to sync on level change instead of user creation.
Folks are encouraged to consider our Email Confirmation and Approvals Add Ons, which can be used to have further control over user access after checkout. ,
These add ons can be configured so that while users are still created and can login, they won’t have access to member content until they are approved or confirm their email. Also remember that even these premium add ons are available for free on GitHub from our official repositories.
Stay tuned to the updates RE pmpro-akismet and the abandoned user/cart cleanup script. And if you let me know about specific issues coming up from this change, we can figure out how to address those together.
Sorry again. Thanks for your understanding and patience.
- This reply was modified 3 years, 2 months ago by Jason Coleman.