Andrew Munro / AffiliateWP

Great!

Give this a shot – I’ve tested to confirm the issue first using your theme’s CSS and also that the CSS below correctly hides that first empty ::before selector, but only for any grid of downloads outputted by EDD:

.edd_downloads_list::before {
    display: none;
}

Thanks, very helpful.

1. How many downloads have you set to show? 2, or 3?
2. Are both your sites that you tested on using the same theme?
3. Can you do a quick test for me and temporarily activate another theme such as Twenty Nineteen, or Twenty Seventeen and then see if that blank box is still there?

The reason for 3 above is because your theme’s CSS is outputting this rule:

div::before, article::before, aside::before, details::before, figcaption::before, figure::before, footer::before, header::before, hgroup::before, menu::before, nav::before, section::before, div::after, ul::after, article::after, aside::after, details::after, figcaption::after, figure::after, footer::after, header::after, hgroup::after, menu::after, nav::after, section::after {
    content: "";
    display: table;
}

The selector that is being executed is the div::before, a pseudo selector.

Essentially, the content line is inserting a blank element before every single div on the website. Because the Downloads grid uses CSS Grid, the empty space is being treated as part of the grid and thus becomes a grid element with the same dimensions as the others. Since there’s no content it just appears as a blank space.

The downloads shortcode in the current version of EDD does not yet use CSS grid, but it will in the next major upgrade. This is why you don’t see the blank space when using the downloads shortcode (since it uses floats to layout the downloads).

Let me know if the issue persists with the theme swap and we’ll go from there. You can change your theme back of course after we’ve confirmed the issue.

• This reply was modified 7 years, 4 months ago by Andrew Munro / AffiliateWP.

Thanks for the suggestion!

You’re welcome!

I replicated the issue and worked out why it’s not showing (both the column and the quick edit setting). FES is clearing out the columns on the main downloads screen before setting its own custom columns. This means that any extension that adds custom columns to that screen will have theirs removed.

FES shouldn’t be doing this IMO so I’ve submitted a patch to the FES repo to prevent this behaviour. After it has been reviewed and a new version released, EDD Featured Downloads will work correctly with FES installed.

Hi,

Sorry, I can’t seem to replicate the issue you are experiencing, I see both the featured column and the quick edit option. For the column, can you check it’s not simply turned off via the “Screen Options” tab?

It’s certainly possible that another plugin is interfering. If that’s the case, I can dig in and find out why. Could you please temporarily deactivate all other plugins except EDD and EDD Featured Downloads and then see if the column and quick edit option show?

If so, activate your plugins again in small batches until the problem comes back and you can identity the plugin that is causing the issue. Post back here with the plugin name and I’ll do my best to replicate the issue and find the cause.

Thanks, great suggestion, I can certainly see how that could be helpful. It’s possible for a customer to purchase while logged out so there won’t be an ID to rely on. It could either be a “logged-in” option or it might be better to approach this from a payment ID angle. The Payment stores the email address of the person who purchased, which then fetches their gravatar.

Thanks for doing that Jack – I’ve now replicated the issue. I’ll dig in and get a patch going. Cheers!